[3.10] Validate nodeName during upgrade #10397

michaelgugino · 2018-10-12T14:17:01Z

Fail early on upgrade if we're going to run into nodeName
problems.

michaelgugino · 2018-10-12T14:17:41Z

/hold for #10392

michaelgugino · 2018-10-12T14:18:04Z

/hold

Fail early on upgrade if we're going to run into nodeName problems.

vrutkovs

/lgtm

vrutkovs · 2018-10-12T16:49:18Z

/retest

vrutkovs · 2018-10-12T16:49:37Z

/hold cancel
/retest

vrutkovs

/lgtm cancel

vrutkovs · 2018-10-12T17:42:55Z

playbooks/init/cluster_facts.yml

+
+    # if using openshift_kubelet_name_override, l_kubelet_node_name will be
+    # set to that value.
+    - name: Fail when nodeName is wrong


Fails during upgrade:

The conditional check 'l_nodeconfig_nodename != l_kubelet_node_name' failed. The error was: error while evaluating conditional (l_nodeconfig_nodename != l_kubelet_node_name): 'l_kubelet_node_name' is undefined

vrutkovs · 2018-10-12T17:45:11Z

nvm, this would pass once #10392 is merged
/lgtm

openshift-ci-robot · 2018-10-12T17:45:17Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michaelgugino, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [michaelgugino,vrutkovs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2018-10-12T17:54:30Z

/retest

Please review the full test history for this PR and help us cut down flakes.

sdodson · 2018-10-12T18:57:05Z

/retest

vrutkovs · 2018-10-12T20:42:19Z

/retest

openshift-bot · 2018-10-12T21:56:16Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2018-10-12T23:57:17Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2018-10-13T01:58:15Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2018-10-13T03:59:14Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2018-10-13T06:00:23Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2018-10-13T10:02:16Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2018-10-13T12:02:14Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2018-10-13T14:03:15Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2018-10-13T16:04:13Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2018-10-13T18:05:14Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2018-10-13T20:06:18Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2018-10-13T22:07:14Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2018-10-14T00:08:14Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2018-10-14T02:09:14Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2018-10-14T04:10:15Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2018-10-14T06:11:16Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2018-10-14T08:12:16Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2018-10-14T10:13:13Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2018-10-14T12:14:13Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2018-10-14T14:15:13Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2018-10-14T16:16:14Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2018-10-14T18:17:14Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2018-10-14T20:18:16Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2018-10-14T22:19:11Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2018-10-15T00:20:13Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2018-10-15T02:21:13Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2018-10-15T04:22:13Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2018-10-15T06:23:13Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2018-10-15T08:24:19Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2018-10-15T10:25:13Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2018-10-15T12:26:15Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2018-10-15T14:27:16Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2018-10-15T16:28:14Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2018-10-15T16:37:12Z

@michaelgugino: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/gcp-major-upgrade	`a70de46`	link	`/test gcp-major-upgrade`
ci/prow/images	`a70de46`	link	`/test images`
ci/prow/gcp	`a70de46`	link	`/test gcp`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 12, 2018

openshift-ci-robot requested review from sdodson and vrutkovs October 12, 2018 14:17

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 12, 2018

michaelgugino force-pushed the nodename-check branch from 5a83c3a to 2d25a8c Compare October 12, 2018 14:20

Validate nodeName during upgrade

a70de46

Fail early on upgrade if we're going to run into nodeName problems.

michaelgugino force-pushed the nodename-check branch from 2d25a8c to a70de46 Compare October 12, 2018 14:24

vrutkovs approved these changes Oct 12, 2018

View reviewed changes

openshift-ci-robot assigned vrutkovs Oct 12, 2018

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2018

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 12, 2018

vrutkovs suggested changes Oct 12, 2018

View reviewed changes

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2018

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2018

sdodson merged commit 5da6258 into openshift:release-3.10 Oct 15, 2018

[3.10] Validate nodeName during upgrade #10397

[3.10] Validate nodeName during upgrade #10397

Uh oh!

Conversation

michaelgugino commented Oct 12, 2018

Uh oh!

michaelgugino commented Oct 12, 2018

Uh oh!

michaelgugino commented Oct 12, 2018

Uh oh!

vrutkovs left a comment

Choose a reason for hiding this comment

Uh oh!

vrutkovs commented Oct 12, 2018

Uh oh!

vrutkovs commented Oct 12, 2018

Uh oh!

vrutkovs left a comment

Choose a reason for hiding this comment

Uh oh!

vrutkovs Oct 12, 2018

Choose a reason for hiding this comment

Uh oh!

vrutkovs commented Oct 12, 2018

Uh oh!

openshift-ci-robot commented Oct 12, 2018

Uh oh!

openshift-bot commented Oct 12, 2018

Uh oh!

sdodson commented Oct 12, 2018

Uh oh!

vrutkovs commented Oct 12, 2018

Uh oh!

openshift-bot commented Oct 12, 2018

Uh oh!

openshift-bot commented Oct 12, 2018

Uh oh!

openshift-bot commented Oct 13, 2018

Uh oh!

openshift-bot commented Oct 13, 2018

Uh oh!

openshift-bot commented Oct 13, 2018

Uh oh!

openshift-bot commented Oct 13, 2018

Uh oh!

openshift-bot commented Oct 13, 2018

Uh oh!

openshift-bot commented Oct 13, 2018

Uh oh!

openshift-bot commented Oct 13, 2018

Uh oh!

openshift-bot commented Oct 13, 2018

Uh oh!

openshift-bot commented Oct 13, 2018

Uh oh!

openshift-bot commented Oct 13, 2018

Uh oh!

openshift-bot commented Oct 14, 2018

Uh oh!

openshift-bot commented Oct 14, 2018

Uh oh!

openshift-bot commented Oct 14, 2018

Uh oh!

openshift-bot commented Oct 14, 2018

Uh oh!

openshift-bot commented Oct 14, 2018

Uh oh!

openshift-bot commented Oct 14, 2018

Uh oh!

openshift-bot commented Oct 14, 2018

Uh oh!

openshift-bot commented Oct 14, 2018

Uh oh!

openshift-bot commented Oct 14, 2018

Uh oh!

openshift-bot commented Oct 14, 2018

Uh oh!

openshift-bot commented Oct 14, 2018

Uh oh!

openshift-bot commented Oct 14, 2018