Skip to content

[3.10] Hostname fixes backport#10392

Merged
sdodson merged 3 commits intoopenshift:release-3.10from
mgugino-upstream-stage:hostname-fixes-bp-3.10-2
Oct 12, 2018
Merged

[3.10] Hostname fixes backport#10392
sdodson merged 3 commits intoopenshift:release-3.10from
mgugino-upstream-stage:hostname-fixes-bp-3.10-2

Conversation

@michaelgugino
Copy link
Contributor

@michaelgugino michaelgugino commented Oct 12, 2018 •
edited
Loading

Backports: #10356

@michaelgugino
Fail on openshift_hostname defined; add openshift_kubelet_name_override
5ce5800 
Adding openshift_kubelet_name_override as a stand-in for
various places we will need to account for possible hostname
overrides.

(cherry picked from commit 1faee09)
(cherry picked from commit 8d35098)
@michaelgugino
Replace openshift.node.nodename with l_kubelet_node_name
71151ac 
This allows us to optionally use override as we see fit.

(cherry picked from commit 0411517)
(cherry picked from commit ac0b5b7)
@michaelgugino
Modify sync pod to check for KUBELET_HOSTNAME_OVERRIDE
b3e6cf0 
Sync pod should check for existence of /etc/sysconfig/KUBELET_HOSTNAME_OVERRIDE
and if present, cat value into nodeconfig.

(cherry picked from commit a225f97)
(cherry picked from commit ef259f7)
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 12, 2018
@michaelgugino michaelgugino mentioned this pull request Oct 12, 2018
Closed
@sdodson
Copy link
Member

sdodson commented Oct 12, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2018
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 12, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michaelgugino, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [michaelgugino,sdodson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michaelgugino
Copy link
Contributor Author

michaelgugino commented Oct 12, 2018

/retest

@openshift-bot
Copy link

openshift-bot commented Oct 12, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@michaelgugino michaelgugino mentioned this pull request Oct 12, 2018
Merged
@sdodson sdodson added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. priority/P0 labels Oct 12, 2018
@michaelgugino
Copy link
Contributor Author

michaelgugino commented Oct 12, 2018

/test gcp

@michaelgugino
Copy link
Contributor Author

michaelgugino commented Oct 12, 2018

/test gcp-major-upgrade

@openshift-bot
Copy link

openshift-bot commented Oct 12, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@sdodson
Copy link
Member

sdodson commented Oct 12, 2018

/retest

@sdodson
Copy link
Member

sdodson commented Oct 12, 2018

Infra flake.

@sdodson sdodson merged commit d4caa79 into openshift:release-3.10 Oct 12, 2018
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 12, 2018

@michaelgugino: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/gcp-major-upgrade b3e6cf0 link /test gcp-major-upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jarrpa jarrpa Awaiting requested review from jarrpa

@luis5tb luis5tb Awaiting requested review from luis5tb

@vrutkovs vrutkovs Awaiting requested review from vrutkovs

@sdodson sdodson Awaiting requested review from sdodson

Assignees

@sdodson sdodson

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. priority/P0 size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@michaelgugino @sdodson @openshift-ci-robot @openshift-bot