Refactor genericclioptions.Context #5198
Conversation
feloy
requested review from
valaparthvi and
dharmit
and removed request for
dharmit and
mohammedzee1000
feloy
force-pushed
the
refactor-context
branch
from
62da028 to
5807d37
Compare
|
/test unit |
feloy
force-pushed
the
refactor-context
branch
from
5807d37 to
d26d0b4
Compare
feloy
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
feloy
force-pushed
the
refactor-context
branch
from
2902959 to
3d1474b
Compare
|
✔️ Deploy Preview for odo-docusaurus-preview ready! 🔨 Explore the source changes: 5e029f7 🔍 Inspect the deploy log: https://app.netlify.com/sites/odo-docusaurus-preview/deploys/6194a8a81dbdd10008042b76 😎 Browse the preview: https://deploy-preview-5198--odo-docusaurus-preview.netlify.app |
feloy
force-pushed
the
refactor-context
branch
2 times, most recently
from
f5eb35a to
2fbfab3
Compare
feloy
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/test psi-kubernetes-integration-e2e |
openshift-ci
bot
added
the
needs-rebase
feloy
force-pushed
the
refactor-context
branch
from
8c9c6b6 to
05b657c
Compare
openshift-ci
bot
removed
the
needs-rebase
| if err != nil { | ||
| util.LogErrorAndExit(err, "") | ||
| } |
There was a problem hiding this comment.
Can we fix this function to return the error as well so that we can avoid abrupt exit calls?
There was a problem hiding this comment.
This function is called during completion, and I'm not sure if we can modify its signature easily. I would prefer the change is part of another PR concerning completion.
pkg/odo/genericclioptions/context.go
Outdated
| return CreateParameters{cmd: cmd} | ||
| } | ||
|
|
||
| func (o CreateParameters) CheckRouteAvailability() CreateParameters { |
There was a problem hiding this comment.
Optional: Can we rename this method to something like RequireRouteAvailability? I understand your reasoning behind naming it CheckRouteAvailability, but I still find it a little non-intuitive. Intuitively I think it would be a function that checks if the route is available to use.
feloy
force-pushed
the
refactor-context
branch
from
05b657c to
5e029f7
Compare
|
SonarCloud Quality Gate failed.
|
|
/test v4.9-integration-e2e |
openshift-ci
bot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: valaparthvi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
* Make context.project immutable * Make context.application immutable * Make context.outputFlag immutable * Make context.ComponentContext immutable + dont store command * Doc + kclient/occlient * Refactor New* * More refactoring * Remove DevfilePath parameter * genericclioptions.NewCreateParameters * private consts * Refactor use of context * Make CreateParameters exported * Refactor build-images * Remove SetComponentcontext * resolveProjectAndNamespace * temp fix * Rename RequireRouteAvailability
What type of PR is this?
/kind cleanup
What does this PR do / why we need it:
Which issue(s) this PR fixes:
Fixes #5176
PR acceptance criteria:
Unit test
Integration test
Documentation
I have read the test guidelines
How to test changes / Special notes to the reviewer: