Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/odo/genericclioptions usability #5176

Closed
2 tasks
feloy opened this issue Oct 26, 2021 · 0 comments · Fixed by #5198
Closed
2 tasks

pkg/odo/genericclioptions usability #5176

feloy opened this issue Oct 26, 2021 · 0 comments · Fixed by #5198
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@feloy
Copy link
Contributor

feloy commented Oct 26, 2021

/kind bug

the package pkg/odo/genericclioptions is difficult to use, for the following reasons:

  • there are different New* functions to initialize the context (New, NewContext, NewContextCreatingAppIfNeeded, NewContextCompletion, NewOfflineContext) and it is not clear which one to use on which situation
  • The context contains a series of values (component context, project, app, kclient, occlient, ...), it is not clear where these information come from and what we can do with.
@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 26, 2021
@feloy feloy mentioned this issue Oct 29, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor genericclioptions.Context feloy/odo
1 participant
@feloy