Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix json in describe component #4506

Conversation

kadel
Copy link
Member

@kadel kadel commented Mar 11, 2021

What type of PR is this?

/kind bug

What does does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #4474
Fixes #4463

PR acceptance criteria:

How to test changes / Special notes to the reviewer:

run odo catalog describe component nodejs -o json
the output should be a valid json struct (array)

@openshift-ci-robot openshift-ci-robot added kind/bug Categorizes issue or PR as related to a bug. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. labels Mar 11, 2021
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Mar 11, 2021
@kadel kadel force-pushed the fix-catalog-describe-component-json branch from 652db8a to bd96a44 Compare March 11, 2021 14:20
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Mar 11, 2021
@kadel
Copy link
Member Author

kadel commented Mar 11, 2021

/retest
timeouts

@prietyc123
Copy link
Contributor

@kadel Can we validate this scenario by adding tests with similar behaviour?

Copy link
Contributor

@prietyc123 prietyc123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kadel kadel force-pushed the fix-catalog-describe-component-json branch from bd96a44 to df80ec9 Compare March 15, 2021 16:32
@kadel
Copy link
Member Author

kadel commented Mar 15, 2021

@kadel Can we validate this scenario by adding tests with similar behaviour?

done

Copy link
Contributor

@mik-dass mik-dass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Mar 16, 2021
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link

openshift-ci bot commented Mar 16, 2021

@kadel: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/v4.7-e2e-4x-psi bd96a44 link /test v4.7-e2e-4x-psi
ci/prow/psi-kubernetes-integration-e2e e4c79da link /test psi-kubernetes-integration-e2e
ci/prow/psi-openshift-integration-e2e e4c79da link /test psi-openshift-integration-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 59a6ea3 into redhat-developer:master Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
6 participants