Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

odo catalog component describe should allow registry parameter #4463

Closed
jeffmaury opened this issue Feb 27, 2021 · 5 comments · Fixed by #4506
Closed

odo catalog component describe should allow registry parameter #4463

jeffmaury opened this issue Feb 27, 2021 · 5 comments · Fixed by #4506
Labels
kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation priority/Medium Nice to have issue. Getting it done before priority changes would be great.

Comments

@jeffmaury
Copy link
Member

/kind bug

What versions of software are you using?

Operating System:
Win10Pro

Output of odo version:
odo v2.0.5 (e8030b19a)

How did you run odo exactly?

odo catalog component describe

Actual behavior

Component from first registry is displayed ?

Expected behavior

We should be able to specifiy the registry to lookup

Any logs, error output, etc?

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 27, 2021
@dharmit
Copy link
Member

dharmit commented Mar 1, 2021

@jeffmaury I'm marking this as a feature instead of a bug since it's something that never existed. Ideally we should have thought of this at the time of v2 release, but evidently we missed that.

@dharmit dharmit added kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation and removed kind/bug Categorizes issue or PR as related to a bug. labels Mar 1, 2021
@dharmit
Copy link
Member

dharmit commented Mar 1, 2021

@jeffmaury on a call today, @kadel mentioned that registry implementation is up for some change. So I have removed this one from consideration for upcoming sprint.

@kadel if there's an issue on devfile repo, can you please link it here so that we can look into this request when it's done?

/priority medium

@openshift-ci-robot openshift-ci-robot added the priority/Medium Nice to have issue. Getting it done before priority changes would be great. label Mar 1, 2021
@kadel
Copy link
Member

kadel commented Mar 9, 2021

After discussing this with @jeffmaury and understanding more about this issue I think that we can safely implement this as it shouldn't change with the new registry implementation.

The problem is this:
When I add my own registry to odo

odo registry add my-registry https://raw.githubusercontent.com/kadel/registry/master

and my-registry has the devfile with the same name as the default odo registry, I won't be able to run odo catalog describes component on devfile from default registry.

odo catalog describe component should have the --registry flag similar to how odo create has it. To allow forcing the specific registry instead of always using the highest priority one.

@kadel
Copy link
Member

kadel commented Mar 16, 2021

@jeffmaury
Wouldn't implementing this #4474 (comment) also solve your problem.

If there are multiple components with the same name, it still prints them both, but now the JSON output has the registry name.

@jeffmaury
Copy link
Member Author

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation priority/Medium Nice to have issue. Getting it done before priority changes would be great.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants