Implement PVC for odo source volume

[adisky]

What type of PR is this?

/kind feature

What does does this PR do / why we need it:
This PR proposes to create a PVC for odo source code volume, Uptil now we were using emptyDir to store source code.
It makes PVC as a default option to store source code, If user wants to use emptyDir as source code, it can use
odo preference set ephemeral true

Which issue(s) this PR fixes:

Fixes #3775

PR acceptance criteria:

• Unit test

• Integration test

• Documentation

• I have read the test guidelines

How to test changes / Special notes to the reviewer:

• odo create nodejs --starter
• odo push
• check if it has created source pvc using oc get pvc or kubectl get pvc

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adisky

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [adisky]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-robot]

@adisky: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/v4.6-integration-e2e	cbed088	link	/test v4.6-integration-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[adisky]

not able to reproduce the failure locally

 Should ensure that files are correctly synced on pod redeploy, without force push specified [It]
    /go/src/github.com/openshift/odo/tests/integration/devfile/cmd_devfile_push_test.go:715
    Expected
      
        <[]string | len:15, cap:16>: [
            "config",
            "devfile.yaml",
            "pom.xml",
            "src",
            "src/main",
            "src/main/java",
            "src/main/java/application",
            "src/main/java/application/Info.java",
            "src/main/java/application/SBApplication.java",
            "src/main/java/application/rest",
            "src/main/java/application/rest/v1",
            "src/main/java/application/rest/v1/Example.java",
            "src/main/resources",
            "src/main/resources/application-local.properties",
            "src/main/resources/application.properties",
        ]
    to equal
        <[]string | len:16, cap:16>: [
            "config",
            "devfile.yaml",
            "lost+found",
            "pom.xml",
            "src",
            "src/main",
            "src/main/java",
            "src/main/java/application",
            "src/main/java/application/Info.java",
            "src/main/java/application/SBApplication.java",
            "src/main/java/application/rest",
            "src/main/java/application/rest/v1",
            "src/main/java/application/rest/v1/Example.java",
            "src/main/resources",
            "src/main/resources/application-local.properties",
            "src/main/resources/application.properties",
        ]

don't know from where this directory lost+found coming up

/retest

[dharmit]

Overall the code does what it's meant for, but I'm facing some issues with setting and unsetting the value of Ephemeral in ~/.odo/preference.yaml using odo preference commands. Opening a separate issue to address that.

/lgtm

[dharmit]

Opening a separate issue to address that.

#4327

[adisky]

/hold

[dharmit]

Thanks for fixing odo preference related points. 👍

/hold cancel
/lgtm