View, set and unset "Ephemeral" using "odo preference" commands

[dharmit]

Which functionality do you think we should add?

PR #4316 adds feature to ensure that odo uses a PVC by default for storing the source code on remote k8s/ocp cluster. The way this happens is by referring the value of Ephemeral in odo's preference file (~/.odo/preference.yaml).

However, odo doesn't correctly view, set or unset this setting in the preference file.

# built odo from the PR #4316 code
$ odo version
odo v2.0.3 (30ef28053)

Server: https://api.crc.testing:6443
Kubernetes: v1.19.0+43983cd

# set the Epehemeral value to true
$ odo preference set Ephemeral true
Global preference was successfully updated

# Don't see "Epehemeral" value in the output below
$ odo preference view
PARAMETER             CURRENT_VALUE
UpdateNotification    
NamePrefix            
Timeout               
BuildTimeout          3000
PushTimeout           480
Experimental          
PushTarget            

# not able to unset the value using below command
$ odo preference unset Ephemeral
 ✗  preference already unset, cannot unset a preference which is not set

# unsetting it forcefully complains that the parameter doesn't exist
$ odo preference unset Ephemeral -f
 ✗  unknown parameter :'ephemeral' is not a parameter in odo config

# Ephemeral is set to true as seen in below output
$ cat ~/.odo/preference.yaml    
kind: Preference
apiversion: odo.dev/v1alpha1
OdoSettings:
  BuildTimeout: 3000
  PushTimeout: 480
  RegistryList:
  - Name: DefaultDevfileRegistry
    URL: https://raw.githubusercontent.com/odo-devfiles/registry/master
    secure: false
  Ephemeral: true

Why is this needed?

This is needed so that users can view, set and unset the value of "Ephemeral" in odo preferences.

/kind bug (since it should have ideally been added as a part of #4316)
/kind feature (since it's still something new that doesn't exist in odo code)
/area config (since we don't have "preference" label)
/good-first-issue

[openshift-ci-robot]

@dharmit:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

Which functionality do you think we should add?

PR #4316 adds feature to ensure that odo uses a PVC by default for storing the source code on remote k8s/ocp cluster. The way this happens is by referring the value of Ephemeral in odo's preference file (~/.odo/preference.yaml).

However, odo doesn't correctly view, set or unset this setting in the preference file.

# built odo from the PR #4316 code
$ odo version
odo v2.0.3 (30ef28053)

Server: https://api.crc.testing:6443
Kubernetes: v1.19.0+43983cd

# set the Epehemeral value to true
$ odo preference set Ephemeral true
Global preference was successfully updated

# Don't see "Epehemeral" value in the output below
$ odo preference view
PARAMETER             CURRENT_VALUE
UpdateNotification    
NamePrefix            
Timeout               
BuildTimeout          3000
PushTimeout           480
Experimental          
PushTarget            

# not able to unset the value using below command
$ odo preference unset Ephemeral
✗  preference already unset, cannot unset a preference which is not set

# unsetting it forcefully complains that the parameter doesn't exist
$ odo preference unset Ephemeral -f
✗  unknown parameter :'ephemeral' is not a parameter in odo config

# Ephemeral is set to true as seen in below output
$ cat ~/.odo/preference.yaml    
kind: Preference
apiversion: odo.dev/v1alpha1
OdoSettings:
 BuildTimeout: 3000
 PushTimeout: 480
 RegistryList:
 - Name: DefaultDevfileRegistry
   URL: https://raw.githubusercontent.com/odo-devfiles/registry/master
   secure: false
 Ephemeral: true

Why is this needed?

This is needed so that users can view, set and unset the value of "Ephemeral" in odo preferences.

/kind bug (since it should have ideally been added as a part of #4316)
/kind feature (since it's still something new that doesn't exist in odo code)
/area config (since we don't have "preference" label)
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@dharmit: The label(s) kind/(since, kind/it, kind/should, kind/have, kind/ideally, kind/been, kind/added, kind/as, kind/a, kind/part, kind/of, kind/#4316), kind/(since, kind/it's, kind/still, kind/something, kind/new, kind/that, kind/doesn't, kind/exist, kind/in, kind/odo, kind/code), area/(since, area/we, area/don't, area/have, area/"preference", area/label) cannot be applied, because the repository doesn't have them

In response to this:

Which functionality do you think we should add?

PR #4316 adds feature to ensure that odo uses a PVC by default for storing the source code on remote k8s/ocp cluster. The way this happens is by referring the value of Ephemeral in odo's preference file (~/.odo/preference.yaml).

However, odo doesn't correctly view, set or unset this setting in the preference file.

# built odo from the PR #4316 code
$ odo version
odo v2.0.3 (30ef28053)

Server: https://api.crc.testing:6443
Kubernetes: v1.19.0+43983cd

# set the Epehemeral value to true
$ odo preference set Ephemeral true
Global preference was successfully updated

# Don't see "Epehemeral" value in the output below
$ odo preference view
PARAMETER             CURRENT_VALUE
UpdateNotification    
NamePrefix            
Timeout               
BuildTimeout          3000
PushTimeout           480
Experimental          
PushTarget            

# not able to unset the value using below command
$ odo preference unset Ephemeral
✗  preference already unset, cannot unset a preference which is not set

# unsetting it forcefully complains that the parameter doesn't exist
$ odo preference unset Ephemeral -f
✗  unknown parameter :'ephemeral' is not a parameter in odo config

# Ephemeral is set to true as seen in below output
$ cat ~/.odo/preference.yaml    
kind: Preference
apiversion: odo.dev/v1alpha1
OdoSettings:
 BuildTimeout: 3000
 PushTimeout: 480
 RegistryList:
 - Name: DefaultDevfileRegistry
   URL: https://raw.githubusercontent.com/odo-devfiles/registry/master
   secure: false
 Ephemeral: true

Why is this needed?

This is needed so that users can view, set and unset the value of "Ephemeral" in odo preferences.

/kind bug (since it should have ideally been added as a part of #4316)
/kind feature (since it's still something new that doesn't exist in odo code)
/area config (since we don't have "preference" label)
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dharmit]

Well this got addressed already in #4316

/close

[openshift-ci-robot]

@dharmit: Closing this issue.

In response to this:

Well this got addressed already in #4316

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.