Skip to content

Support ibmcloud provider in release extract #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jul 21, 2021
Merged

Support ibmcloud provider in release extract #852

openshift-merge-robot merged 1 commit into from
Jul 21, 2021

Conversation

@BobbyRadford
Copy link
Contributor

@BobbyRadford BobbyRadford commented Jun 15, 2021

This PR enables "ibmcloud" to be specified as part of the cloud argument to `oc adm release extract". An example would look like this:

oc adm release extract --credentials-requests --cloud=ibmcloud --to=./credrequests <RELEASE_IMAGE>

This is related to this CCO PR: openshift/cloud-credential-operator#356
...and this enhancement: openshift/enhancements#773

@openshift-ci openshift-ci bot requested review from deads2k and smarterclayton June 15, 2021 20:13
@BobbyRadford
Copy link
Contributor Author

BobbyRadford commented Jun 15, 2021

/retest unit

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 15, 2021

@BobbyRadford: The /retest command does not accept any targets.
The following commands are available to trigger jobs:

  • /test build-rpms-from-tar
  • /test e2e-agnostic-cmd
  • /test e2e-aws
  • /test e2e-aws-builds
  • /test e2e-aws-serial
  • /test e2e-aws-upgrade
  • /test e2e-metal-ipi-ovn-ipv6
  • /test images
  • /test rpm-build
  • /test unit
  • /test verify
  • /test verify-deps

Use /test all to run the following jobs:

  • pull-ci-openshift-oc-master-build-rpms-from-tar
  • pull-ci-openshift-oc-master-e2e-agnostic-cmd
  • pull-ci-openshift-oc-master-e2e-aws
  • pull-ci-openshift-oc-master-e2e-aws-serial
  • pull-ci-openshift-oc-master-e2e-aws-upgrade
  • pull-ci-openshift-oc-master-e2e-metal-ipi-ovn-ipv6
  • pull-ci-openshift-oc-master-images
  • pull-ci-openshift-oc-master-rpm-build
  • pull-ci-openshift-oc-master-unit
  • pull-ci-openshift-oc-master-verify
  • pull-ci-openshift-oc-master-verify-deps
Details

In response to this:

/retest unit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BobbyRadford
Copy link
Contributor Author

BobbyRadford commented Jun 15, 2021

/test unit

@BobbyRadford
Copy link
Contributor Author

BobbyRadford commented Jun 15, 2021

/retest

@BobbyRadford BobbyRadford changed the title Support ibmcloud cloud provider for release extract Support ibmcloud provider in release extract Jun 16, 2021
@BobbyRadford BobbyRadford marked this pull request as draft June 22, 2021 13:28
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 22, 2021
@BobbyRadford BobbyRadford marked this pull request as ready for review July 20, 2021 15:40
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 20, 2021
soltysh
soltysh approved these changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BobbyRadford, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2021
@openshift-merge-robot openshift-merge-robot merged commit 5f88601 into openshift:master Jul 21, 2021
@akhil-rane akhil-rane mentioned this pull request Nov 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

1 more reviewer

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@soltysh soltysh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BobbyRadford @soltysh @openshift-merge-robot