Skip to content

BUILD-87: bumping openshift/api with new fields for build volumes#843

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
coreydaley:jira_build_87_secret_configmap_volume_mounts_in_builds
Jun 28, 2021
Merged

BUILD-87: bumping openshift/api with new fields for build volumes#843
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
coreydaley:jira_build_87_secret_configmap_volume_mounts_in_builds

Conversation

@coreydaley
Copy link

@coreydaley coreydaley commented Jun 8, 2021

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 8, 2021
@openshift-ci openshift-ci bot requested review from smarterclayton and soltysh June 8, 2021 15:50
@xiuwang xiuwang mentioned this pull request Jun 15, 2021
Merged
@xiuwang
Copy link

xiuwang commented Jun 15, 2021

Test on PR launched cluster launch openshift/builder#245,openshift/openshift-controller-manager#183,openshift/openshift-apiserver#208,#843 following test cases https://url.corp.redhat.com/buildvolumes , no critical issues found.

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jun 15, 2021
@coreydaley coreydaley changed the title [WIP] BUILD-87: bumping openshift/api with new fields for build volumes BUILD-87: bumping openshift/api with new fields for build volumes Jun 18, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 18, 2021
@coreydaley
Copy link
Author

coreydaley commented Jun 18, 2021

/retest

1 similar comment
@coreydaley
Copy link
Author

coreydaley commented Jun 18, 2021

/retest

@coreydaley
Copy link
Author

coreydaley commented Jun 18, 2021

Blocked by #860

@coreydaley
Copy link
Author

coreydaley commented Jun 19, 2021

/retest

@coreydaley
Copy link
Author

coreydaley commented Jun 20, 2021

/assign @deads2k @mfojtik
ptal, this supports adding build volumes to the build/buildconfig api
/cc @adambkaplan

@openshift-ci openshift-ci bot requested a review from adambkaplan June 20, 2021 01:27
@coreydaley
Copy link
Author

coreydaley commented Jun 20, 2021

/hold
Waiting on openshift/api#943

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 20, 2021
@coreydaley
Copy link
Author

coreydaley commented Jun 20, 2021

blocked by openshift/api#944

@coreydaley
Copy link
Author

coreydaley commented Jun 21, 2021

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 21, 2021
@coreydaley
Copy link
Author

coreydaley commented Jun 21, 2021

/retest

5 similar comments
@coreydaley
Copy link
Author

coreydaley commented Jun 21, 2021

/retest

@coreydaley
Copy link
Author

coreydaley commented Jun 21, 2021

/retest

@coreydaley
Copy link
Author

coreydaley commented Jun 21, 2021

/retest

@coreydaley
Copy link
Author

coreydaley commented Jun 22, 2021

/retest

@coreydaley
Copy link
Author

coreydaley commented Jun 22, 2021

/retest

@coreydaley
Copy link
Author

coreydaley commented Jun 22, 2021

@deads2k @soltysh ptal
This pull request bumps the openshift/api/build to include support for the new BuildVolumes

adambkaplan
adambkaplan approved these changes Jun 23, 2021
View reviewed changes
Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@rolfedh @RickJWagner need docs and PX approval

@RickJWagner
Copy link
Contributor

RickJWagner commented Jun 24, 2021

/label px-approved

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Jun 24, 2021
@RickJWagner
Copy link
Contributor

RickJWagner commented Jun 24, 2021

PLM approves.

@coreydaley
Copy link
Author

coreydaley commented Jun 24, 2021

Pulled in API updates from openshift/api#954

@coreydaley
Copy link
Author

coreydaley commented Jun 24, 2021

/retest

5 similar comments
@coreydaley
Copy link
Author

coreydaley commented Jun 24, 2021

/retest

@coreydaley
Copy link
Author

coreydaley commented Jun 24, 2021

/retest

@coreydaley
Copy link
Author

coreydaley commented Jun 24, 2021

/retest

@coreydaley
Copy link
Author

coreydaley commented Jun 25, 2021

/retest

@coreydaley
Copy link
Author

coreydaley commented Jun 26, 2021

/retest

@coreydaley
Copy link
Author

coreydaley commented Jun 28, 2021

@deads2k @mfojtik bump
e2e-aws-upgrade failures are unrelated

soltysh
soltysh approved these changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 28, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, coreydaley, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2021
@coreydaley
Copy link
Author

coreydaley commented Jun 28, 2021

/retest

1 similar comment
@coreydaley
Copy link
Author

coreydaley commented Jun 28, 2021

/retest

@openshift-merge-robot openshift-merge-robot merged commit 4ce5bfa into openshift:master Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adambkaplan adambkaplan adambkaplan approved these changes

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

+1 more reviewer

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mfojtik mfojtik

@soltysh soltysh

@deads2k deads2k

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@coreydaley @xiuwang @RickJWagner @soltysh @adambkaplan @mfojtik @deads2k @openshift-merge-robot

Comments