removing conversion-gen=false for BuildVolumeSource.Type field#943
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom Jun 20, 2021
coreydaley:jira_build_87_fix_type_conversion_gen
Merged
removing conversion-gen=false for BuildVolumeSource.Type field#943openshift-merge-robot merged 1 commit intoopenshift:masterfrom coreydaley:jira_build_87_fix_type_conversion_gen
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
coreydaley:jira_build_87_fix_type_conversion_gen
Conversation
Author
|
/assign @adambkaplan @bparees |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, coreydaley The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need to remove the
+k8s:conversion-gen=falseso that openshift/openshift-apiserver can auto-generate the conversions.Tested this in the openshift/openshift-apiserver repo locally and it worked.