Skip to content

Comments

Bug 1946839: Revert: Split work of oc image mirror#780

Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
sallyom:revert-plan-split
Apr 8, 2021
Merged

Bug 1946839: Revert: Split work of oc image mirror#780
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
sallyom:revert-plan-split

Conversation

@sallyom
Copy link
Contributor

@sallyom sallyom commented Mar 24, 2021

Reverting this change, as --skip-multiple-scopes is the workaround for the issue outlined in the bug. With this workaround, we can take time to investigate a fix that is more targeted to specific situations.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 24, 2021

@sallyom: This pull request references Bugzilla bug 1874106, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Revert: Bug 1874106: Split work of oc image mirror

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 24, 2021
@sallyom sallyom mentioned this pull request Mar 24, 2021
Merged
@sallyom sallyom changed the title Revert: Bug 1874106: Split work of oc image mirror Revert: Split work of oc image mirror Mar 24, 2021
@openshift-ci-robot openshift-ci-robot removed bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 24, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 24, 2021

@sallyom: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

Revert: Split work of oc image mirror

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sallyom sallyom mentioned this pull request Mar 24, 2021
Closed
@sallyom
Copy link
Contributor Author

sallyom commented Mar 24, 2021

/test e2e-agnostic-cmd

@sallyom
Copy link
Contributor Author

sallyom commented Mar 25, 2021

/retest

1 similar comment
@sallyom
Copy link
Contributor Author

sallyom commented Mar 26, 2021

/retest

@sallyom
Copy link
Contributor Author

sallyom commented Mar 26, 2021

/test e2e-agnostic-cmd

1 similar comment
@sallyom
Copy link
Contributor Author

sallyom commented Mar 29, 2021

/test e2e-agnostic-cmd

@sallyom
Copy link
Contributor Author

sallyom commented Mar 29, 2021

/retest

@sallyom
skip-multiple-scopes with adm catalog mirror
511ab52 
'oc adm catalog mirror' often fails with server error
'414 Request-URI Too Large' This is because mirroring the
catalog pushes a lot of content in parallel. To avoid this,
set the mirroring flag --skip-multiple-scopes to true.
@sallyom sallyom force-pushed the revert-plan-split branch from 4d20ed9 to 511ab52 Compare March 29, 2021 16:36
@sallyom sallyom mentioned this pull request Mar 29, 2021
Closed
@sallyom
Copy link
Contributor Author

sallyom commented Mar 29, 2021

/retest

6 similar comments
@sallyom
Copy link
Contributor Author

sallyom commented Mar 30, 2021

/retest

@sallyom
Copy link
Contributor Author

sallyom commented Mar 30, 2021

/retest

@sallyom
Copy link
Contributor Author

sallyom commented Mar 31, 2021

/retest

@sallyom
Copy link
Contributor Author

sallyom commented Mar 31, 2021

/retest

@sallyom
Copy link
Contributor Author

sallyom commented Apr 1, 2021

/retest

@sallyom
Copy link
Contributor Author

sallyom commented Apr 5, 2021

/retest

@soltysh soltysh changed the title Revert: Split work of oc image mirror Bug 1946839: Revert: Split work of oc image mirror Apr 7, 2021
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Apr 7, 2021
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 7, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 7, 2021

@sallyom: This pull request references Bugzilla bug 1946839, which is invalid:

  • expected the bug to target the "4.8.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1946839: Revert: Split work of oc image mirror

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@soltysh
Copy link
Contributor

soltysh commented Apr 7, 2021

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 7, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 7, 2021

@soltysh: This pull request references Bugzilla bug 1946839, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @zhouying7780

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@smarterclayton
Copy link
Contributor

smarterclayton commented Apr 7, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 7, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 7, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sallyom, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2021
@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 8, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

8 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 8, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 8, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 8, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 8, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 8, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 8, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 8, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 8, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 7cae9e8 into openshift:master Apr 8, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 8, 2021

@sallyom: All pull requests linked via external trackers have merged:

Bugzilla bug 1946839 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1946839: Revert: Split work of oc image mirror

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@soltysh soltysh mentioned this pull request Jun 10, 2021
Closed
This was referenced Jun 25, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mfojtik mfojtik Awaiting requested review from mfojtik

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@zhouying7780 zhouying7780 Awaiting requested review from zhouying7780

Assignees

@smarterclayton smarterclayton

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@sallyom @openshift-ci-robot @soltysh @smarterclayton @openshift-bot @openshift-merge-robot