Bug 1788156: With 'oc adm release new' allow a component image substitution w/ a multi-arch component image by sallyom · Pull Request #513 · openshift/oc

sallyom · 2020-08-08T00:03:34Z

This PR will allow:

oc adm release new --from-release anything --to anythingelse component=multi-arch-image
- this currently fails bc oc image extract can't handle DeserializedManifestList with
  oc adm release new flow

Note: oc image extract|info|append can handle multi-arch images, it defaults to extract system os/arch unless --filter-by-os is passed. It doesn't, however, work with --filter-by-os=.* or with any expandable regex, as it can only handle a literal single filter (linux/amd64 not linux/* ). This PR updates logic around choosing a single manifest from a manifest list w/ oc image append|info|extract.

See sample commands with improved output in comments below.

Also resolves https://bugzilla.redhat.com/show_bug.cgi?id=1906276

openshift-ci-robot · 2020-08-08T00:03:41Z

@sallyom: This pull request references Bugzilla bug 1859452, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

Bug 1859452: With 'oc adm release new' allow a component image substitution w/ a multi-arch component image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-08-08T00:03:59Z

@sallyom: This pull request references Bugzilla bug 1859452, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

Bug 1859452: With 'oc adm release new' allow a component image substitution w/ a multi-arch component image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-08-08T00:20:31Z

@sallyom: This pull request references Bugzilla bug 1859452, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

Bug 1859452: With 'oc adm release new' allow a component image substitution w/ a multi-arch component image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-08-08T00:25:41Z

@sallyom: This pull request references Bugzilla bug 1859452, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

Bug 1859452: With 'oc adm release new' allow a component image substitution w/ a multi-arch component image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-08-08T00:27:42Z

@sallyom: This pull request references Bugzilla bug 1859452, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

Bug 1859452: With 'oc adm release new' allow a component image substitution w/ a multi-arch component image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-08-08T04:56:56Z

@sallyom: This pull request references Bugzilla bug 1859452, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

Bug 1859452: With 'oc adm release new' allow a component image substitution w/ a multi-arch component image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-08-10T01:41:57Z

@sallyom: This pull request references Bugzilla bug 1859452, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

Bug 1859452: With 'oc adm release new' allow a component image substitution w/ a multi-arch component image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-08-10T01:43:30Z

@sallyom: This pull request references Bugzilla bug 1859452, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

Bug 1859452: With 'oc adm release new' allow a component image substitution w/ a multi-arch component image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sallyom · 2020-08-10T01:44:40Z

/assign @smarterclayton

openshift-ci-robot · 2020-08-11T20:34:49Z

@sallyom: This pull request references Bugzilla bug 1788156, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

Bug 1788156: With 'oc adm release new' allow a component image substitution w/ a multi-arch component image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pkg/cli/image/manifest/manifest.go

sallyom · 2021-03-29T19:23:45Z

/retest

sallyom · 2021-03-31T13:56:04Z

/retest

sallyom · 2021-04-08T16:16:07Z

@sallyom this needs a rebase
@smarterclayton bump for review

rebased and included the revert pr, also, since they conflict

This us updated, ready for final review. Please see sample commands with improved output and the fix:
#513 (comment)

sallyom · 2021-04-13T16:56:16Z

/retest

openshift-ci · 2021-06-02T01:21:18Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sallyom, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sallyom · 2021-06-02T01:23:27Z

@sallyom this needs a rebase
@smarterclayton bump for review

This us updated, ready for final review. Please see sample commands with improved output and the fix:
#513 (comment)

@smarterclayton bump for review

sallyom · 2021-08-17T03:20:04Z

/retest

sallyom · 2021-08-20T03:30:16Z

/retest

sallyom · 2021-08-20T12:25:43Z

/retest

openshift-merge-robot · 2021-09-06T07:27:31Z

/bugzilla refresh

The requirements for Bugzilla bugs have changed, recalculating validity.

openshift-ci · 2021-09-06T07:28:38Z

@openshift-merge-robot: This pull request references Bugzilla bug 1788156, which is invalid:

expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Retaining the bugzilla/valid-bug label as it was manually added.

Details

In response to this:

/bugzilla refresh

The requirements for Bugzilla bugs have changed, recalculating validity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-merge-robot · 2021-09-06T08:17:03Z

/bugzilla refresh

The requirements for Bugzilla bugs have changed, recalculating validity.

openshift-ci · 2021-09-06T08:17:07Z

@openshift-merge-robot: This pull request references Bugzilla bug 1788156, which is invalid:

expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Retaining the bugzilla/valid-bug label as it was manually added.

Details

In response to this:

/bugzilla refresh

The requirements for Bugzilla bugs have changed, recalculating validity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sallyom · 2021-09-28T17:51:31Z

/bugzilla refresh

openshift-ci · 2021-09-28T17:51:35Z

@sallyom: This pull request references Bugzilla bug 1788156, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.0) matches configured target release for branch (4.10.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @zhouying7780

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sallyom · 2021-09-28T18:00:31Z

@smarterclayton afaict this doesn't need a /hold, i've updated and this is awaiting review

improved behavior here: Bug 1788156: With 'oc adm release new' allow a component image substitution w/ a multi-arch component image #513 (comment)
as you noted previously, this log should be removed - if this PR will not be merged then I'll open a PR w/ only this change: https://github.com/openshift/oc/pull/513/files#diff-88a19aa652d0dad2300f5b2080f14494546c5036b5b357e07ae150e24d67c072L442

sallyom · 2021-09-29T19:59:54Z

/retest

sallyom · 2021-10-25T20:14:30Z

/retest-required

…tution when image is multi-arch This PR fixes the above bug and also improves logic when passing multi-arch images to 'oc image extract|append|info <image>'. These only handle a single os/arch unlike 'oc image mirror' that can handle wildcard filter-by-os with expanded regex values. This PR adds improved error msg when unable to filter to a single manifest from list with 'oc image info,append,extract'

openshift-ci · 2022-01-14T17:06:33Z

@sallyom: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-agnostic-cmd	`685c688`	link	true	`/test e2e-agnostic-cmd`
ci/prow/e2e-aws-upgrade	`685c688`	link	true	`/test e2e-aws-upgrade`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2022-01-28T18:45:08Z

/bugzilla refresh

The requirements for Bugzilla bugs have changed (BZs linked to PRs on master branch need to target OCP 4.11), recalculating validity.

openshift-ci · 2022-01-28T18:47:15Z

@openshift-bot: This pull request references Bugzilla bug 1788156, which is invalid:

expected the bug to target the "4.11.0" release, but it targets "4.10.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Retaining the bugzilla/valid-bug label as it was manually added.

Details

In response to this:

/bugzilla refresh

The requirements for Bugzilla bugs have changed (BZs linked to PRs on master branch need to target OCP 4.11), recalculating validity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wking · 2022-01-31T21:14:10Z

/bugzilla refresh

openshift-ci · 2022-01-31T21:22:53Z

@wking: This pull request references Bugzilla bug 1788156, which is invalid:

expected the bug to target the "4.11.0" release, but it targets "4.10.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Retaining the bugzilla/valid-bug label as it was manually added.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-05-02T06:08:25Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-ci · 2022-05-02T06:08:33Z

@sallyom: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-06-01T06:32:23Z

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

openshift-bot · 2022-07-01T06:59:19Z

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci · 2022-07-01T07:00:27Z

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-07-01T07:00:35Z

@sallyom: This pull request references Bugzilla bug 1788156. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.
Warning: Failed to comment on Bugzilla bug with reason for changed state.

Details

In response to this:

Bug 1788156: With 'oc adm release new' allow a component image substitution w/ a multi-arch component image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 8, 2020

openshift-ci-robot requested review from deads2k and smarterclayton August 8, 2020 00:03

sallyom force-pushed the multi-arch-bz-1859452 branch from 85930f7 to 3d0435f Compare August 8, 2020 00:25

sallyom force-pushed the multi-arch-bz-1859452 branch from 3d0435f to 484ad3b Compare August 8, 2020 04:52

openshift-ci-robot assigned smarterclayton Aug 10, 2020

sallyom force-pushed the multi-arch-bz-1859452 branch from 484ad3b to 22f21a9 Compare August 10, 2020 16:45

sallyom changed the title ~~Bug 1859452: With 'oc adm release new' allow a component image substitution w/ a multi-arch component image~~ Bug 1788156: With 'oc adm release new' allow a component image substitution w/ a multi-arch component image Aug 11, 2020

openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. and removed bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. labels Aug 11, 2020

sallyom force-pushed the multi-arch-bz-1859452 branch from 22f21a9 to 8c50a28 Compare August 11, 2020 20:37

openshift-ci-robot mentioned this pull request Aug 12, 2020

Bug 1859452: Improve help menu when 'oc image mirror' and multi-arch images #519

Merged

smarterclayton reviewed Aug 24, 2020

View reviewed changes

pkg/cli/image/manifest/manifest.go Outdated Show resolved Hide resolved

smarterclayton reviewed Aug 24, 2020

View reviewed changes

pkg/cli/image/manifest/manifest.go Outdated Show resolved Hide resolved

sallyom force-pushed the multi-arch-bz-1859452 branch 4 times, most recently from d8012c8 to 0088b29 Compare August 28, 2020 14:09

sallyom force-pushed the multi-arch-bz-1859452 branch from 0088b29 to 08584df Compare September 2, 2020 22:12

Conversation

sallyom commented Aug 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Aug 8, 2020

Uh oh!

openshift-ci-robot commented Aug 8, 2020

Uh oh!

openshift-ci-robot commented Aug 8, 2020

Uh oh!

openshift-ci-robot commented Aug 8, 2020

Uh oh!

openshift-ci-robot commented Aug 8, 2020

Uh oh!

openshift-ci-robot commented Aug 8, 2020

Uh oh!

openshift-ci-robot commented Aug 10, 2020

Uh oh!

openshift-ci-robot commented Aug 10, 2020

Uh oh!

sallyom commented Aug 10, 2020

Uh oh!

openshift-ci-robot commented Aug 11, 2020

Uh oh!

Uh oh!

Uh oh!

sallyom commented Mar 29, 2021

Uh oh!

sallyom commented Mar 31, 2021

Uh oh!

sallyom commented Apr 8, 2021

Uh oh!

sallyom commented Apr 13, 2021

Uh oh!

openshift-ci bot commented Jun 2, 2021

Uh oh!

sallyom commented Jun 2, 2021

Uh oh!

sallyom commented Aug 17, 2021

Uh oh!

sallyom commented Aug 20, 2021

Uh oh!

sallyom commented Aug 20, 2021

Uh oh!

openshift-merge-robot commented Sep 6, 2021

Uh oh!

openshift-ci bot commented Sep 6, 2021

Uh oh!

openshift-merge-robot commented Sep 6, 2021

Uh oh!

openshift-ci bot commented Sep 6, 2021

Uh oh!

sallyom commented Sep 28, 2021

Uh oh!

openshift-ci bot commented Sep 28, 2021

Uh oh!

sallyom commented Sep 28, 2021

Uh oh!

sallyom commented Sep 29, 2021

Uh oh!

sallyom commented Oct 25, 2021

Uh oh!

openshift-ci bot commented Jan 14, 2022

Uh oh!

openshift-bot commented Jan 28, 2022

Uh oh!

openshift-ci bot commented Jan 28, 2022

Uh oh!

wking commented Jan 31, 2022

Uh oh!

openshift-ci bot commented Jan 31, 2022

Uh oh!

openshift-bot commented May 2, 2022

Uh oh!

openshift-ci bot commented May 2, 2022

Uh oh!

openshift-bot commented Jun 1, 2022

Uh oh!

openshift-bot commented Jul 1, 2022

Uh oh!

sallyom commented Aug 8, 2020 •

edited

Loading