OTA-1174: upgrade status: Show resources in --details=health - #1737
Conversation
|
@petr-muller: This pull request references OTA-1174 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
@petr-muller: This pull request references OTA-1174 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
Bot
added
the
approved
|
@petr-muller: This pull request references OTA-1174 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
|
|
||
| resourceKindPad int | ||
| // resourceKinds contains keys of resources map | ||
| resourceKinds []string |
There was a problem hiding this comment.
Should we include the group too? Sometimes kind is not sufficient to be unique, e.g. in a TechPreviewNoUpgrade cluster:
$ oc api-resources | grep 'NAME\|^machines '
NAME SHORTNAMES APIVERSION NAMESPACED KIND
machines ma cluster.x-k8s.io/v1beta1 true Machine
machines machine.openshift.io/v1beta1 true MachineAnd folks need to use oc get machines.machine.openshift.io if they want the machine-API type, because oc get machines will give them the cluster-API type.
There was a problem hiding this comment.
/hold
I'll check if I can address that easily
There was a problem hiding this comment.
I agree, adding groups is a good idea.
openshift-ci
Bot
added
the
do-not-merge/hold
|
|
||
| resourceKindPad int | ||
| // resourceKinds contains keys of resources map | ||
| resourceKinds []string |
There was a problem hiding this comment.
I agree, adding groups is a good idea.
d72f24d to
190eddb
Compare
|
/lgtm |
|
I dunno what's behind /retest-required |
openshift-ci
Bot
removed
the
do-not-merge/hold
|
/retest |
|
/retest Maybe the failed build was cached, retrying after deleting |
|
/retest One more shot after deleting all builds |
|
/retest One more shot after openshift/release#51253 merged? |
|
Looks good now |
openshift-merge-robot
added
the
needs-rebase
The insight can contain data about involved resource (of various, and even mixed kinds). The detailed output can display this data.
The node section is a table where node name is a dedicated column, so when the message mentions the name, it creates visual duplicate clutter, especially if the name is long and contains arbitrary string segments. Ellipsize (replace with a placeholder) names longer than 7 characters from the messages.
190eddb to
e945000
Compare
e945000 to
385b964
Compare
|
Let's try a comment |
openshift-merge-robot
removed
the
needs-rebase
|
Good boy |
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Davoska, LalatenduMohanty, petr-muller The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-tools-container-v4.17.0-202404241149.p0.ga08ffc9.assembly.stream.el9 for distgit ose-tools. |
7 participants
Showing resources was a prerequisite to coalescing related insights I tried in #1690 where instead of showing an insight about each individual node, I wanted to display a single insight that would say "7 nodes in pool worker are degraded while draining: failed to..." and have a list of nodes affected by the one condition. I am not happy about my implementation attempt so I am not submitting that change, so that we can proceed and close OTA-1174. I will file a dedicated card for coalescing related insights instead.
upgrade status --detailed=health: show involved resourcesThe insight can contain data about involved resource (of various, and even mixed kinds). The detailed output can display this data.
upgrade status: ellipsize (duplicate) long names in messagesThe node section is a table where node name is a dedicated column, so when the message mentions the name, it creates visual duplicate clutter, especially if the name is long and contains arbitrary string segments.
Ellipsize (replace with a placeholder) names longer than 7 characters from the messages.
upgrade status: hint at using --details=health