Skip to content

pin to github.com/openshift/kubernetes-client-go#60

Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
p0lyn0mial:pin-to-kube-client-go
Nov 9, 2020
Merged

pin to github.com/openshift/kubernetes-client-go#60
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
p0lyn0mial:pin-to-kube-client-go

Conversation

@p0lyn0mial
Copy link
Contributor

we will carry a patch that allows the client to detect broken connections to the api server more quickly than the default TCP timeout of 15 minutes.

this patch will be dropped in future releases once http2/ping is introduced.

@p0lyn0mial
Copy link
Contributor Author

the change was introduced in openshift/library-go#926

@p0lyn0mial p0lyn0mial force-pushed the pin-to-kube-client-go branch from 3c3f599 to 85aaec2 Compare November 9, 2020 08:35
@stlaz
Copy link
Contributor

stlaz commented Nov 9, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 9, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: p0lyn0mial, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

10 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 9775b41 into openshift:master Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants