CNTRLPLANE-1259: Simplified test infrastructure to single-module architecture #154
Conversation
wangke19
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@wangke19: This pull request references CNTRLPLANE-1259 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
wangke19
force-pushed
the
ote-single-module-migration
branch
from
d821e61 to
5bf5686
Compare
|
/test e2e-aws |
wangke19
force-pushed
the
ote-single-module-migration
branch
from
5bf5686 to
e63d0c4
Compare
|
/lgtm |
|
@wangke19: This pull request references CNTRLPLANE-1259 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/verified by CI tests |
openshift-ci-robot
added
the
verified
|
@wangke19: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
wangke19
force-pushed
the
ote-single-module-migration
branch
from
e63d0c4 to
8035c02
Compare
openshift-ci-robot
removed
the
verified
wangke19
force-pushed
the
ote-single-module-migration
branch
from
2530976 to
0a47835
Compare
|
Addressed the OWNER files in PR #158 |
|
@wangke19: This pull request references CNTRLPLANE-1259 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
wangke19
force-pushed
the
ote-single-module-migration
branch
from
0a47835 to
8297e6d
Compare
|
@wangke19: This pull request references CNTRLPLANE-1259 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Infrastructure changes to adopt OTE (OpenShift Tests Extension) framework:
- Simplified cmd/oauth-apiserver-tests-ext/main.go (113 → 54 lines)
- Removed custom suite definitions, test manipulation, and hooks
- Now directly registers extension with OTE framework
- Uses standard OTE command structure
- Updated build configuration:
- Modified Dockerfile.rhel7 to use standard `make build`
- Removed custom test targets from Makefile (tests-ext-build, tests-ext-update)
- Updated .gitignore for .gz test binary
- Enhanced documentation:
- Added comprehensive README.md with:
- API Groups section (OAuth and User APIs)
- Resource types documentation
- Overview of core features
- Tests section following cluster-kube-apiserver-operator pattern
- Cleaned up test directory:
- Removed test/.openshift-tests-extension/openshift_payload_oauth-apiserver.json
- Removed test/extended/README.md and test/extended/main.go
- Updated OWNERS file:
- Removed deads2k, tkashem, and dgrisonnet from reviewers and approvers
Dependency updates following test infrastructure simplification:
- Updated go.mod:
- Moved github.com/onsi/ginkgo/v2 from direct to indirect dependency
- Moved github.com/onsi/gomega from direct to indirect dependency
- Removed github.com/go-task/slim-sprig/v3 (ginkgo CLI dependency)
- Cleaned up vendor/ directory (256 files, ~196K deletions):
- Removed github.com/go-task/slim-sprig/v3 (ginkgo CLI dependency)
- Removed github.com/onsi/ginkgo/v2 (CLI tools and internal packages)
- Removed github.com/onsi/gomega (full package)
- Removed vendor/github.com/openshift-eng/openshift-tests-extension/pkg/ginkgo/*
- Removed transitive dependencies:
- golang.org/x/net/html (gomega dependency)
- golang.org/x/text/encoding (gomega dependency)
- golang.org/x/tools/cover and go/ast/inspector (ginkgo CLI deps)
- Updated vendor/modules.txt
These packages are no longer needed as direct dependencies since the
codebase now uses the OTE framework instead of custom ginkgo integration.
|
@wangke19: This pull request references CNTRLPLANE-1259 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
wangke19
force-pushed
the
ote-single-module-migration
branch
from
8297e6d to
fcc7937
Compare
|
/retest-required |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gangwgr, p0lyn0mial, wangke19 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@wangke19: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/verified by CI tests |
openshift-ci-robot
added
the
verified
|
@wangke19: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
4 participants
after some discussions, we decided to do the following,
Summary
Changes
Infrastructure (Commit 1)
make buildDependencies (Commit 2)
Verification
make buildpassesgo mod tidyandgo mod vendorrun cleanPattern Reference
Follows the pattern from:
gangwgr-test-infrastructure-setup-v2branchMigration Guide
Based on:
ote-single-module-migration-guide.md(Scenario B: Simplifying existing OTE implementation)🤖 Generated with Claude Code
Co-Authored-By: Claude [email protected]