dev: update push-image.sh to use new single mco image #950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/M
openshift-ci-robot
added
the
approved
kikisdeliveryservice
changed the title
openshift-ci-robot
added
the
do-not-merge/work-in-progress
kikisdeliveryservice
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
This was referenced Jul 10, 2019
kikisdeliveryservice
force-pushed
the
up-date-push-image-sh
branch
from
1351083 to
f6af7f0
Compare
Member
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, kikisdeliveryservice The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/retest |
kikisdeliveryservice
added a commit
to kikisdeliveryservice/machine-config-operator
that referenced
this pull request
Jul 11, 2019
Update commands in hacking.md since we now only have 1 Dockerfile/mco image. Also add hack/push-image.sh command to hacking.md Related-to: openshift#739 Related-to: openshift#948 Related-to: openshift#950
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving script change out of #895, since that can't land until ART is sorted out. This can go in now.
We only have 1 image now so updating push-image.sh too.
Related-to: #739