dev: It's just make image now
#948
Conversation
We only have one image, so massively simplify the code. (Note that `make deploy` i.e. `hack/cluster-push` is still not aware of this but fixing that is more involved and this is correct in the interim)
openshift-ci-robot
added
size/M
|
(Now you might ask, what's the value of even having a wrapper script for something so obvious? I think I'd like to continue to have |
|
Nice. You simplified this even more than I did. I'm fine with keeping it in the makefile - I think it keeps it simple by having things in a central place and consistent Just testing this locally... one sec |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, kikisdeliveryservice The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Update commands in hacking.md since we now only have 1 Dockerfile/mco image. Also add hack/push-image.sh command to hacking.md Related-to: openshift#739 Related-to: openshift#948 Related-to: openshift#950
5 participants
We only have one image, so massively simplify the code.
(Note that
make deployi.e.hack/cluster-pushis stillnot aware of this but fixing that is more involved and
this is correct in the interim)