OCPBUGS-65556: [release-4.20] Backport: Add delays to reduce TestOSBuildController failures

[ngopalak-redhat]

- What I did

Description

Backport of #5239 to release-4.20

My PR saw a similar failure #5387 hence needed to backport

Summary

This PR backports the test timing fixes from PR #5239 to the release-4.20 branch.

Problem

The test TestOSBuildController/MachineConfig_changes_creates_a_new_MachineOSBuild is failing in CI on release-4.20 with a timeout error (context deadline exceeded). The test completes in ~24.73 seconds but times out at the 25-second limit.

Root Cause

• Commit 97cecae introduced MOSB reuse logic which added more complex reconciliation
• This increased test execution time beyond the 25-second timeout in CI environments
• PR NO-ISSUE: Add delays to reduce TestOSBuildController failures #5239 added 200ms delays to fix this issue on main/4.21/4.22
• However, these fixes were not backported to release-4.20

Solution

Cherry-pick commit fd87e53 from PR #5239 which adds time.Sleep(200ms) delays at critical points in the test to allow the controller's reconciliation
loops to complete before assertions are checked.

Testing

• ✅ Test passes locally with delays (3.22s)
• ✅ Test was timing out before this fix

Original PR

#5239

cc: @djoshy (original author)

- How to verify it

- Description for the changelog

[openshift-ci-robot]

@ngopalak-redhat: This pull request explicitly references no jira issue.

Details

In response to this:

- What I did

Description

Backport of #5239 to release-4.20

Summary

This PR backports the test timing fixes from PR #5239 to the release-4.20 branch.

Problem

The test TestOSBuildController/MachineConfig_changes_creates_a_new_MachineOSBuild is failing in CI on release-4.20 with a timeout error (context deadline exceeded). The test completes in ~24.73 seconds but times out at the 25-second limit.

Root Cause

• Commit 97cecae introduced MOSB reuse logic which added more complex reconciliation
• This increased test execution time beyond the 25-second timeout in CI environments
• PR NO-ISSUE: Add delays to reduce TestOSBuildController failures #5239 added 200ms delays to fix this issue on main/4.21/4.22
• However, these fixes were not backported to release-4.20

Solution

Cherry-pick commit fd87e53 from PR #5239 which adds time.Sleep(200ms) delays at critical points in the test to allow the controller's reconciliation
loops to complete before assertions are checked.

Testing

• ✅ Test passes locally with delays (3.22s)
• ✅ Test was timing out before this fix

Original PR

#5239

cc: @djoshy (original author)

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[ngopalak-redhat]

/test all

[djoshy]

/lgtm

/label backport-risk-assessed

Thank you for taking this on! Since it is a backport it might need a 4.20 bug dependent on a (dummy) 4.21 bug so the PR gets a jira/valid-bug tag. We could also ask a staff engineer to manually apply the labels, too.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy, ngopalak-redhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [djoshy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ngopalak-redhat]

/verified Fixes the issue with the Test

[openshift-ci-robot]

@ngopalak-redhat: The /verified command must be used with one of the following actions: by, later, remove, or bypass. See https://docs.ci.openshift.org/docs/architecture/jira/#premerge-verification for more information.

Details

In response to this:

/verified Fixes the issue with the Test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[ngopalak-redhat]

/verified by @ngopalak-redhat

[openshift-ci-robot]

@ngopalak-redhat: This PR has been marked as verified by @ngopalak-redhat.

Details

In response to this:

/verified by @ngopalak-redhat

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[ngopalak-redhat]

/retitle NO-JIRA: [release-4.20] NO-ISSUE: Backport: Add delays to reduce TestOSBuildController failures

[ngopalak-redhat]

/retitle OCPNODE-3722: [release-4.20] Backport: Add delays to reduce TestOSBuildController failures

[openshift-ci-robot]

@ngopalak-redhat: This pull request references OCPNODE-3722 which is a valid jira issue.

Details

In response to this:

- What I did

Description

Backport of #5239 to release-4.20

My PR saw a similar failure #5387 hence needed to backport

Summary

This PR backports the test timing fixes from PR #5239 to the release-4.20 branch.

Problem

The test TestOSBuildController/MachineConfig_changes_creates_a_new_MachineOSBuild is failing in CI on release-4.20 with a timeout error (context deadline exceeded). The test completes in ~24.73 seconds but times out at the 25-second limit.

Root Cause

• Commit 97cecae introduced MOSB reuse logic which added more complex reconciliation
• This increased test execution time beyond the 25-second timeout in CI environments
• PR NO-ISSUE: Add delays to reduce TestOSBuildController failures #5239 added 200ms delays to fix this issue on main/4.21/4.22
• However, these fixes were not backported to release-4.20

Solution

Cherry-pick commit fd87e53 from PR #5239 which adds time.Sleep(200ms) delays at critical points in the test to allow the controller's reconciliation
loops to complete before assertions are checked.

Testing

• ✅ Test passes locally with delays (3.22s)
• ✅ Test was timing out before this fix

Original PR

#5239

cc: @djoshy (original author)

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[ngopalak-redhat]

/jira-refresh

[ngopalak-redhat]

/retitle OCPBUGS-65556: [release-4.20] Backport: Add delays to reduce TestOSBuildController failures

[openshift-ci-robot]

@ngopalak-redhat: This pull request references Jira Issue OCPBUGS-65556, which is invalid:

• expected the bug to target only the "4.20.z" version, but multiple target versions were set
• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected Jira Issue OCPBUGS-65556 to depend on a bug targeting a version in 4.21.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

- What I did

Description

Backport of #5239 to release-4.20

My PR saw a similar failure #5387 hence needed to backport

Summary

This PR backports the test timing fixes from PR #5239 to the release-4.20 branch.

Problem

The test TestOSBuildController/MachineConfig_changes_creates_a_new_MachineOSBuild is failing in CI on release-4.20 with a timeout error (context deadline exceeded). The test completes in ~24.73 seconds but times out at the 25-second limit.

Root Cause

• Commit 97cecae introduced MOSB reuse logic which added more complex reconciliation
• This increased test execution time beyond the 25-second timeout in CI environments
• PR NO-ISSUE: Add delays to reduce TestOSBuildController failures #5239 added 200ms delays to fix this issue on main/4.21/4.22
• However, these fixes were not backported to release-4.20

Solution

Cherry-pick commit fd87e53 from PR #5239 which adds time.Sleep(200ms) delays at critical points in the test to allow the controller's reconciliation
loops to complete before assertions are checked.

Testing

• ✅ Test passes locally with delays (3.22s)
• ✅ Test was timing out before this fix

Original PR

#5239

cc: @djoshy (original author)

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[ngopalak-redhat]

/jira refresh

[openshift-ci-robot]

@ngopalak-redhat: This pull request references Jira Issue OCPBUGS-65556, which is invalid:

• expected Jira Issue OCPBUGS-65556 to depend on a bug targeting a version in 4.21.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[ngopalak-redhat]

/jira refresh

[openshift-ci-robot]

@ngopalak-redhat: This pull request references Jira Issue OCPBUGS-65556, which is invalid:

• expected Jira Issue OCPBUGS-65556 to depend on a bug targeting a version in 4.21.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[ngopalak-redhat]

/jira refresh

[openshift-ci-robot]

@ngopalak-redhat: This pull request references Jira Issue OCPBUGS-65556, which is invalid:

• expected Jira Issue OCPBUGS-65556 to depend on a bug targeting a version in 4.21.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[ngopalak-redhat]

/jira refresh

[openshift-ci-robot]

@ngopalak-redhat: This pull request references Jira Issue OCPBUGS-65556, which is invalid:

• expected dependent Jira Issue OCPBUGS-48526 to target a version in 4.21.0, but it targets "4.21" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[ngopalak-redhat]

/jira refresh

[openshift-ci-robot]

@ngopalak-redhat: This pull request references Jira Issue OCPBUGS-65556, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.20.z) matches configured target version for branch (4.20.z)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
• release note text is set and does not match the template
• dependent bug Jira Issue OCPBUGS-48526 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-48526 targets the "4.21.0" version, which is one of the valid target versions: 4.21.0
• bug has dependents

Requesting review from QA contact:
/cc @sergiordlr

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 50712a0 and 2 for PR HEAD 4e665d9 in total

[openshift-ci]

@ngopalak-redhat: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/bootstrap-unit	4e665d9	link	false	/test bootstrap-unit

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[djoshy]

/retest-required

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD e2499c0 and 1 for PR HEAD 4e665d9 in total

[openshift-ci-robot]

@ngopalak-redhat: Jira Issue OCPBUGS-65556 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state.

Details

In response to this:

- What I did

Description

Backport of #5239 to release-4.20

My PR saw a similar failure #5387 hence needed to backport

Summary

This PR backports the test timing fixes from PR #5239 to the release-4.20 branch.

Problem

The test TestOSBuildController/MachineConfig_changes_creates_a_new_MachineOSBuild is failing in CI on release-4.20 with a timeout error (context deadline exceeded). The test completes in ~24.73 seconds but times out at the 25-second limit.

Root Cause

• Commit 97cecae introduced MOSB reuse logic which added more complex reconciliation
• This increased test execution time beyond the 25-second timeout in CI environments
• PR NO-ISSUE: Add delays to reduce TestOSBuildController failures #5239 added 200ms delays to fix this issue on main/4.21/4.22
• However, these fixes were not backported to release-4.20

Solution

Cherry-pick commit fd87e53 from PR #5239 which adds time.Sleep(200ms) delays at critical points in the test to allow the controller's reconciliation
loops to complete before assertions are checked.

Testing

• ✅ Test passes locally with delays (3.22s)
• ✅ Test was timing out before this fix

Original PR

#5239

cc: @djoshy (original author)

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.