Skip to content

Conversation

@djoshy
Copy link
Contributor

@djoshy djoshy commented Aug 11, 2025

This test has been flakey in the past, and we opened https://issues.redhat.com/browse/OCPBUGS-48526 to track it, but its failure count has gotten frequent enough to warrant further investigation. Unsure if some recent changes have made its failure more prevalent.

I've added my conclusions from testing in the jira ticket, please check this comment for more context.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 11, 2025
@openshift-ci-robot
Copy link
Contributor

@djoshy: This pull request explicitly references no jira issue.

Details

In response to this:

This test has been flakey in the past, and we opened https://issues.redhat.com/browse/OCPBUGS-48526 to track it, but its failure count has gotten frequent enough to warrant further investigation. Unsure if some recent changes have made its failure more prevalent.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 11, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2025
@djoshy djoshy force-pushed the fix-flakey-ocl-units branch from 960aafd to 09c7a03 Compare August 22, 2025 12:55
@djoshy
Copy link
Contributor Author

djoshy commented Aug 22, 2025

/test unit

2 similar comments
@djoshy
Copy link
Contributor Author

djoshy commented Aug 22, 2025

/test unit

@djoshy
Copy link
Contributor Author

djoshy commented Aug 22, 2025

/test unit

@djoshy djoshy force-pushed the fix-flakey-ocl-units branch from 09c7a03 to fd87e53 Compare September 15, 2025 19:52
@djoshy djoshy changed the title [DNM] NO-ISSUE: debug TestOSBuildController NO-ISSUE: Add delays to reduce TestOSBuildController failures Sep 15, 2025
@djoshy
Copy link
Contributor Author

djoshy commented Sep 15, 2025

/test unit

@djoshy djoshy marked this pull request as ready for review September 15, 2025 20:06
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 15, 2025
@djoshy
Copy link
Contributor Author

djoshy commented Sep 16, 2025

/verified bypass

Non functional change that only affects unit tests

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 16, 2025
@openshift-ci-robot
Copy link
Contributor

@djoshy: The verified label has been added.

Details

In response to this:

/verified bypass

Non functional change that only affects unit tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Member

@isabella-janssen isabella-janssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

🤞

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy, isabella-janssen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [djoshy,isabella-janssen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 18e8a11 and 2 for PR HEAD fd87e53 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 16, 2025

@djoshy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn-upgrade-out-of-change fd87e53 link false /test e2e-azure-ovn-upgrade-out-of-change
ci/prow/e2e-gcp-mco-disruptive fd87e53 link false /test e2e-gcp-mco-disruptive
ci/prow/e2e-gcp-op-ocl fd87e53 link false /test e2e-gcp-op-ocl
ci/prow/e2e-aws-mco-disruptive fd87e53 link false /test e2e-aws-mco-disruptive
ci/prow/bootstrap-unit fd87e53 link false /test bootstrap-unit
ci/prow/e2e-aws-ovn-upgrade-out-of-change fd87e53 link false /test e2e-aws-ovn-upgrade-out-of-change

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@djoshy
Copy link
Contributor Author

djoshy commented Sep 17, 2025

/override ci/prow/e2e-aws-ovn

This PR only affects unit tests, should not affect functionality (and has passed this test before)

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 17, 2025

@djoshy: Overrode contexts on behalf of djoshy: ci/prow/e2e-aws-ovn

Details

In response to this:

/override ci/prow/e2e-aws-ovn

This PR only affects unit tests, should not affect functionality

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 4219abd into openshift:main Sep 17, 2025
16 of 22 checks passed
@djoshy djoshy deleted the fix-flakey-ocl-units branch September 22, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants