Skip to content

OCPBUGS-59776: Revert "OCPBUGS-52302: Fix timing of Spec.ConfigVersion.Desired update in MCN" #5190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Jul 24, 2025
Merged

OCPBUGS-59776: Revert "OCPBUGS-52302: Fix timing of Spec.ConfigVersion.Desired update in MCN" #5190

openshift-merge-bot merged 1 commit into from
Jul 24, 2025
+116 −152

Conversation

@isabella-janssen
Copy link
Member

@isabella-janssen isabella-janssen commented Jul 24, 2025 •
edited
Loading

Reverts #5121

See this Slack thread for info.

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 24, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 24, 2025

@isabella-janssen: This pull request references Jira Issue OCPBUGS-52302, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Reverts #5121

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@smg247
Copy link
Member

smg247 commented Jul 24, 2025

For: https://issues.redhat.com/browse/OCPBUGS-59776

@isabella-janssen isabella-janssen changed the title Revert "OCPBUGS-52302: Fix timing of Spec.ConfigVersion.Desired update in MCN" OCPBUGS-59776: Revert "OCPBUGS-52302: Fix timing of Spec.ConfigVersion.Desired update in MCN" Jul 24, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 24, 2025

@isabella-janssen: This pull request references Jira Issue OCPBUGS-59776, which is invalid:

  • expected the bug to target the "4.20.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Reverts #5121

See this Slack thread for info.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. label Jul 24, 2025
@isabella-janssen
Copy link
Member Author

isabella-janssen commented Jul 24, 2025

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 24, 2025

@isabella-janssen: This pull request references Jira Issue OCPBUGS-59776, which is invalid:

  • expected the bug to target the "4.20.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2025
@smg247
Copy link
Member

smg247 commented Jul 24, 2025

/skip

@smg247
Copy link
Member

smg247 commented Jul 24, 2025

/override ci/prow/security
/override ci/prow/e2e-aws-ovn-windows
/override ci/prow/e2e-aws-ovn-upgrade-out-of-change
/override ci/prow/e2e-aws-ovn
/override ci/prow/e2e-agent-compact-ipv4
/override ci/prow/okd-scos-e2e-aws-ovn
/override ci/prow/e2e-azure-ovn-upgrade-out-of-change
/override ci/prow/e2e-hypershift
/override ci/prow/e2e-gcp-op-techpreview
/override ci/prow/e2e-azure-ovn-upgrade
/override ci/prow/e2e-aws-serial
/override ci/prow/e2e-aws-ovn-upgrade
/override ci/prow/e2e-gcp-op-single-node
/override ci/prow/e2e-gcp-op-ocl
/override ci/prow/e2e-gcp-op

@smg247
Copy link
Member

smg247 commented Jul 24, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 24, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 24, 2025

@smg247: This pull request references Jira Issue OCPBUGS-59776, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sergiordlr

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from sergiordlr July 24, 2025 14:56
@neisw
Copy link
Contributor

neisw commented Jul 24, 2025

When testing the unrevert let's validate with payload-aggregate periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview-serial 10

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 24, 2025

@smg247: Overrode contexts on behalf of smg247: ci/prow/e2e-agent-compact-ipv4, ci/prow/e2e-aws-ovn, ci/prow/e2e-aws-ovn-upgrade, ci/prow/e2e-aws-ovn-upgrade-out-of-change, ci/prow/e2e-aws-ovn-windows, ci/prow/e2e-aws-serial, ci/prow/e2e-azure-ovn-upgrade, ci/prow/e2e-azure-ovn-upgrade-out-of-change, ci/prow/e2e-gcp-op, ci/prow/e2e-gcp-op-ocl, ci/prow/e2e-gcp-op-single-node, ci/prow/e2e-gcp-op-techpreview, ci/prow/e2e-hypershift, ci/prow/okd-scos-e2e-aws-ovn, ci/prow/security

Details

In response to this:

/override ci/prow/security
/override ci/prow/e2e-aws-ovn-windows
/override ci/prow/e2e-aws-ovn-upgrade-out-of-change
/override ci/prow/e2e-aws-ovn
/override ci/prow/e2e-agent-compact-ipv4
/override ci/prow/okd-scos-e2e-aws-ovn
/override ci/prow/e2e-azure-ovn-upgrade-out-of-change
/override ci/prow/e2e-hypershift
/override ci/prow/e2e-gcp-op-techpreview
/override ci/prow/e2e-azure-ovn-upgrade
/override ci/prow/e2e-aws-serial
/override ci/prow/e2e-aws-ovn-upgrade
/override ci/prow/e2e-gcp-op-single-node
/override ci/prow/e2e-gcp-op-ocl
/override ci/prow/e2e-gcp-op

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@smg247
Copy link
Member

smg247 commented Jul 24, 2025

/override ci/prow/images
/override ci/prow/okd-scos-images
/override ci/prow/unit
/override ci/prow/verify
/override ci/prow/verify-deps

@smg247
Copy link
Member

smg247 commented Jul 24, 2025

/lgtm

@neisw
Copy link
Contributor

neisw commented Jul 24, 2025

/hold

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 24, 2025

@smg247: Overrode contexts on behalf of smg247: ci/prow/images, ci/prow/okd-scos-images, ci/prow/unit, ci/prow/verify, ci/prow/verify-deps

Details

In response to this:

/override ci/prow/images
/override ci/prow/okd-scos-images
/override ci/prow/unit
/override ci/prow/verify
/override ci/prow/verify-deps

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 24, 2025
@smg247
Copy link
Member

smg247 commented Jul 24, 2025

/test ci/prow/images
/test ci/prow/okd-scos-images
/test ci/prow/unit
/test ci/prow/verify
/test ci/prow/verify-deps

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 24, 2025

@smg247: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test e2e-aws-ovn

/test e2e-aws-ovn-upgrade

/test e2e-gcp-op

/test e2e-gcp-op-single-node

/test e2e-hypershift

/test images

/test okd-scos-images

/test unit

/test verify

/test verify-deps

The following commands are available to trigger optional jobs:

/test bootstrap-unit

/test e2e-agent-compact-ipv4

/test e2e-aws-disruptive

/test e2e-aws-ovn-fips

/test e2e-aws-ovn-fips-op

/test e2e-aws-ovn-ocb-techpreview

/test e2e-aws-ovn-serial-ipsec

/test e2e-aws-ovn-upgrade-ipsec

/test e2e-aws-ovn-upgrade-ocb-techpreview

/test e2e-aws-ovn-upgrade-out-of-change

/test e2e-aws-ovn-windows

/test e2e-aws-ovn-workers-rhel8

/test e2e-aws-proxy

/test e2e-aws-serial

/test e2e-aws-single-node

/test e2e-aws-upgrade-single-node

/test e2e-aws-workers-rhel8

/test e2e-azure

/test e2e-azure-ovn-upgrade

/test e2e-azure-ovn-upgrade-out-of-change

/test e2e-azure-upgrade

/test e2e-gcp-op-ocl

/test e2e-gcp-op-techpreview

/test e2e-gcp-ovn-rt-upgrade

/test e2e-gcp-rt

/test e2e-gcp-rt-op

/test e2e-gcp-single-node

/test e2e-gcp-upgrade

/test e2e-hypershift-techpreview

/test e2e-metal-assisted

/test e2e-metal-ipi-ovn-dualstack

/test e2e-metal-ipi-ovn-ipv6

/test e2e-metal-ovn-two-node-arbiter

/test e2e-metal-ovn-two-node-fencing

/test e2e-openstack

/test e2e-openstack-dualstack

/test e2e-openstack-externallb

/test e2e-openstack-hypershift

/test e2e-openstack-parallel

/test e2e-openstack-singlestackv6

/test e2e-ovirt

/test e2e-ovirt-upgrade

/test e2e-ovn-step-registry

/test e2e-vsphere

/test e2e-vsphere-ovn-upi

/test e2e-vsphere-ovn-upi-zones

/test e2e-vsphere-ovn-zones

/test e2e-vsphere-upgrade

/test okd-scos-e2e-aws-ovn

/test security

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-machine-config-operator-main-bootstrap-unit

pull-ci-openshift-machine-config-operator-main-e2e-agent-compact-ipv4

pull-ci-openshift-machine-config-operator-main-e2e-aws-ovn

pull-ci-openshift-machine-config-operator-main-e2e-aws-ovn-upgrade

pull-ci-openshift-machine-config-operator-main-e2e-aws-ovn-upgrade-out-of-change

pull-ci-openshift-machine-config-operator-main-e2e-aws-ovn-windows

pull-ci-openshift-machine-config-operator-main-e2e-aws-serial

pull-ci-openshift-machine-config-operator-main-e2e-azure-ovn-upgrade

pull-ci-openshift-machine-config-operator-main-e2e-azure-ovn-upgrade-out-of-change

pull-ci-openshift-machine-config-operator-main-e2e-gcp-op

pull-ci-openshift-machine-config-operator-main-e2e-gcp-op-ocl

pull-ci-openshift-machine-config-operator-main-e2e-gcp-op-single-node

pull-ci-openshift-machine-config-operator-main-e2e-gcp-op-techpreview

pull-ci-openshift-machine-config-operator-main-e2e-hypershift

pull-ci-openshift-machine-config-operator-main-images

pull-ci-openshift-machine-config-operator-main-okd-scos-e2e-aws-ovn

pull-ci-openshift-machine-config-operator-main-okd-scos-images

pull-ci-openshift-machine-config-operator-main-security

pull-ci-openshift-machine-config-operator-main-unit

pull-ci-openshift-machine-config-operator-main-verify

pull-ci-openshift-machine-config-operator-main-verify-deps
Details

In response to this:

/test ci/prow/images
/test ci/prow/okd-scos-images
/test ci/prow/unit
/test ci/prow/verify
/test ci/prow/verify-deps

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@smg247
Copy link
Member

smg247 commented Jul 24, 2025

/test images
/test okd-scos-images
/test unit
/test verify
/test verify-deps

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: isabella-janssen, smg247

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@neisw
Copy link
Contributor

neisw commented Jul 24, 2025

/test unit

@neisw
Copy link
Contributor

neisw commented Jul 24, 2025

/override ci/prow/unit
/skip
/hold cancel
@isabella-janssen confirmed the unit test failure is unrelated and occurring in other prs

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 24, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 24, 2025

@neisw: Overrode contexts on behalf of neisw: ci/prow/unit

Details

In response to this:

/override ci/prow/unit
/skip
/hold cancel
@isabella-janssen confirmed the unit test failure is unrelated and occurring in other prs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit ab14c8e into openshift:main Jul 24, 2025
22 checks passed
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 24, 2025

@isabella-janssen: Jira Issue OCPBUGS-59776: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-59776 has been moved to the MODIFIED state.

Details

In response to this:

Reverts #5121

See this Slack thread for info.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@isabella-janssen isabella-janssen deleted the revert-5121-ocpbugs-52302-mcnSpecStatus branch July 24, 2025 16:49
@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 24, 2025

[ART PR BUILD NOTIFIER]

Distgit: ose-machine-config-operator
This PR has been included in build ose-machine-config-operator-container-v4.20.0-202507241814.p0.gab14c8e.assembly.stream.el9.
All builds following this will include this PR.

@isabella-janssen isabella-janssen mentioned this pull request Jul 28, 2025
Closed
@openshift-ci-robot openshift-ci-robot mentioned this pull request Oct 17, 2025
Merged
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Oct 19, 2025

Fix included in accepted release 4.21.0-0.nightly-2025-10-18-225958

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RishabhSaini RishabhSaini Awaiting requested review from RishabhSaini

@yuqi-zhang yuqi-zhang Awaiting requested review from yuqi-zhang

@sergiordlr sergiordlr Awaiting requested review from sergiordlr

Assignees

@smg247 smg247

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@isabella-janssen @openshift-ci-robot @smg247 @neisw @openshift-bot @openshift-merge-robot