[release-4.19] OCPBUGS-59766: Fix timing of Spec.ConfigVersion.Desired update in MCN

[isabella-janssen]

Closes: OCPBUGS-59766

- What I did
This moves the MCN spec update function, GenerateAndApplyMachineConfigNodeSpec into the node controller's update function so that the desired config version in the MCN is updated when the node annotation is updated.

- How to verify it

1. Launch a 4.19 techpreview-enabled cluster with this PR build included.

launch 4.19,openshift/machine-config-operator#5189 aws,techpreview

2. Apply a MachineConfig to trigger a node update.
3. Track how the desired configs are updated in the MCN's spec and status. The desired config value in the spec should update before the UpdatePrepared condition is True and before the desired config version is updated in the status.
   Example grep to see the necessary fields:

oc describe machineconfignode/<node-name> | grep -E "Config Version|UpdatePrepared" -A 2

- Description for the changelog
OCPBUGS-59766: Fix timing of Spec.ConfigVersion.Desired update in MCN

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: isabella-janssen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [isabella-janssen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[isabella-janssen]

/jira cherry-pick OCPBUGS-52302

[openshift-ci-robot]

@isabella-janssen: Jira Issue OCPBUGS-52302 has been cloned as Jira Issue OCPBUGS-59766. Will retitle bug to link to clone.
/retitle OCPBUGS-59766: Fix timing of Spec.ConfigVersion.Desired update in MCN

Details

In response to this:

/jira cherry-pick OCPBUGS-52302

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@isabella-janssen: This pull request references Jira Issue OCPBUGS-59766, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.19.z) matches configured target version for branch (4.19.z)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
• release note type set to "Release Note Not Required"
• dependent bug Jira Issue OCPBUGS-52302 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-52302 targets the "4.20.0" version, which is one of the valid target versions: 4.20.0
• bug has dependents

Requesting review from QA contact:
/cc @sergiordlr

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Closes: OCPBUGS-XXXXX

- What I did
This moves the MCN spec update function, GenerateAndApplyMachineConfigNodeSpec into the node controller's update function so that the desired config version in the MCN is updated when the node annotation is updated.

- How to verify it

1. Launch a 4.20 cluster with this PR build included.

launch 4.20,openshift/machine-config-operator#5121 aws

2. Apply a MachineConfig to trigger a node update.
3. Track how the desired configs are updated in the MCN's spec and status. The desired config value in the spec should update before the UpdatePrepared condition is True and before the desired config version is updated in the status.
   Example grep to see the necessary fields:

oc describe machineconfignode/<node-name> | grep -E "Config Version|UpdatePrepared" -A 2

- Description for the changelog
OCPBUGS-52302: Fix timing of Spec.ConfigVersion.Desired update in MCN

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@isabella-janssen: This pull request references Jira Issue OCPBUGS-59766, which is valid.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.19.z) matches configured target version for branch (4.19.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
• release note type set to "Release Note Not Required"
• dependent bug Jira Issue OCPBUGS-52302 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-52302 targets the "4.20.0" version, which is one of the valid target versions: 4.20.0
• bug has dependents

Requesting review from QA contact:
/cc @sergiordlr

Details

In response to this:

Closes: OCPBUGS-59766

- What I did
This moves the MCN spec update function, GenerateAndApplyMachineConfigNodeSpec into the node controller's update function so that the desired config version in the MCN is updated when the node annotation is updated.

- How to verify it

1. Launch a 4.19 techpreview-enabled cluster with this PR build included.

launch 4.19,openshift/machine-config-operator#5189 aws,techpreview

2. Apply a MachineConfig to trigger a node update.
3. Track how the desired configs are updated in the MCN's spec and status. The desired config value in the spec should update before the UpdatePrepared condition is True and before the desired config version is updated in the status.
   Example grep to see the necessary fields:

oc describe machineconfignode/<node-name> | grep -E "Config Version|UpdatePrepared" -A 2

- Description for the changelog
OCPBUGS-59766: Fix timing of Spec.ConfigVersion.Desired update in MCN

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[isabella-janssen]

/test all

[openshift-ci]

@isabella-janssen: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-op-ocl	f8089bb	link	false	/test e2e-gcp-op-ocl
ci/prow/e2e-aws-ovn	f8089bb	link	true	/test e2e-aws-ovn
ci/prow/okd-e2e-aws	f8089bb	link	false	/test okd-e2e-aws
ci/prow/okd-images	f8089bb	link	true	/test okd-images
ci/prow/e2e-azure-ovn-upgrade-out-of-change	f8089bb	link	false	/test e2e-azure-ovn-upgrade-out-of-change
ci/prow/okd-e2e-gcp-op	f8089bb	link	false	/test okd-e2e-gcp-op
ci/prow/e2e-aws-serial	f8089bb	link	false	/test e2e-aws-serial
ci/prow/okd-e2e-upgrade	f8089bb	link	false	/test okd-e2e-upgrade
ci/prow/okd-e2e-vsphere	f8089bb	link	false	/test okd-e2e-vsphere
ci/prow/e2e-azure-ovn-upgrade	f8089bb	link	false	/test e2e-azure-ovn-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[isabella-janssen]

/close

Closing since #5121 was reverted (see #5190) and this will need to be reworked.

[openshift-ci]

@isabella-janssen: Closed this PR.

Details

In response to this:

/close

Closing since #5121 was reverted (see #5190) and this will need to be reworked.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci-robot]

@isabella-janssen: This pull request references Jira Issue OCPBUGS-59766. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

Details

In response to this:

Closes: OCPBUGS-59766

- What I did
This moves the MCN spec update function, GenerateAndApplyMachineConfigNodeSpec into the node controller's update function so that the desired config version in the MCN is updated when the node annotation is updated.

- How to verify it

1. Launch a 4.19 techpreview-enabled cluster with this PR build included.

launch 4.19,openshift/machine-config-operator#5189 aws,techpreview

2. Apply a MachineConfig to trigger a node update.
3. Track how the desired configs are updated in the MCN's spec and status. The desired config value in the spec should update before the UpdatePrepared condition is True and before the desired config version is updated in the status.
   Example grep to see the necessary fields:

oc describe machineconfignode/<node-name> | grep -E "Config Version|UpdatePrepared" -A 2

- Description for the changelog
OCPBUGS-59766: Fix timing of Spec.ConfigVersion.Desired update in MCN

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.