Skip to content

[release-4.19] OCPBUGS-55809: Use auto=start only for IPsec out connections #5035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
May 8, 2025
Merged

[release-4.19] OCPBUGS-55809: Use auto=start only for IPsec out connections #5035

openshift-merge-bot merged 1 commit into from
May 8, 2025

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented May 7, 2025

This is an automated cherry-pick of #5017

/assign pperiyasamy

@pperiyasamy
Use auto=start only for IPsec out connections
212d29b 
We noticed a cross streaming issue with Libreswan 5.2 creating duplicate
child SAs on the node and no matching SA on the other end causing packet
drops.
To fix it, this commit makes wait-for-ipsec-connect.service updates
openshift.conf with auto=start only for out connections.

Signed-off-by: Periyasamy Palanisamy <[email protected]>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 7, 2025
Merged
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 7, 2025

@openshift-cherrypick-robot: Jira Issue OCPBUGS-55262 has been cloned as Jira Issue OCPBUGS-55809. Will retitle bug to link to clone.
/retitle [release-4.19] OCPBUGS-55809: Use auto=start only for IPsec out connections

Details

In response to this:

This is an automated cherry-pick of #5017

/assign pperiyasamy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.19] OCPBUGS-55262: Use auto=start only for IPsec out connections [release-4.19] OCPBUGS-55809: Use auto=start only for IPsec out connections May 7, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 7, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 7, 2025

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-55809, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #5017

/assign pperiyasamy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pperiyasamy
Copy link
Member

pperiyasamy commented May 7, 2025

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 7, 2025

@pperiyasamy: An error was encountered updating to the POST state for bug OCPBUGS-55809 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message. No response returned: Get "https://issues.redhat.com/rest/api/2/issue/16881655/transitions?expand=transitions.fields": GET https://issues.redhat.com/rest/api/2/issue/16881655/transitions?expand=transitions.fields giving up after 5 attempt(s)

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pperiyasamy
Copy link
Member

pperiyasamy commented May 7, 2025

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 7, 2025

@pperiyasamy: An error was encountered updating to the POST state for bug OCPBUGS-55809 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message. No response returned: Get "https://issues.redhat.com/rest/api/2/issue/16881655/transitions?expand=transitions.fields": GET https://issues.redhat.com/rest/api/2/issue/16881655/transitions?expand=transitions.fields giving up after 5 attempt(s)

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 7, 2025 •
edited
Loading

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn-upgrade-out-of-change 212d29b link false /test e2e-azure-ovn-upgrade-out-of-change
ci/prow/e2e-gcp-op-ocl 212d29b link false /test e2e-gcp-op-ocl

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@pperiyasamy
Copy link
Member

pperiyasamy commented May 7, 2025

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 7, 2025

@pperiyasamy: An error was encountered updating to the POST state for bug OCPBUGS-55809 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message. No response returned: Post "https://issues.redhat.com/rest/api/2/issue/16881655/transitions": POST https://issues.redhat.com/rest/api/2/issue/16881655/transitions giving up after 5 attempt(s)

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pperiyasamy
Copy link
Member

pperiyasamy commented May 7, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 7, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 7, 2025

@pperiyasamy: This pull request references Jira Issue OCPBUGS-55809, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-55262 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-55262 targets the "4.20.0" version, which is one of the valid target versions: 4.20.0
  • bug has dependents

Requesting review from QA contact:
/cc @anuragthehatter

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from anuragthehatter May 7, 2025 14:53
@pperiyasamy
Copy link
Member

pperiyasamy commented May 7, 2025

/assign @yuqi-zhang @igsilya @tssurya

igsilya
igsilya approved these changes May 7, 2025
View reviewed changes
Copy link

@igsilya igsilya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean cherry-pick. And we have the same libreswan on 4.19 as in 4.20.
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2025
yuqi-zhang
yuqi-zhang approved these changes May 8, 2025
View reviewed changes
Copy link
Contributor

@yuqi-zhang yuqi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label backport risk assessed

Should be a safe backport

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: igsilya, openshift-cherrypick-robot, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2025
@pperiyasamy
Copy link
Member

pperiyasamy commented May 8, 2025

/assign @anuragthehatter @huiran0826

@anuragthehatter
Copy link

anuragthehatter commented May 8, 2025

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 8, 2025
@pperiyasamy
Copy link
Member

pperiyasamy commented May 8, 2025

/retest-required

@yuqi-zhang
Copy link
Contributor

yuqi-zhang commented May 8, 2025

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label May 8, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit a9859b6 into openshift:release-4.19 May 8, 2025
19 of 21 checks passed
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 8, 2025

@openshift-cherrypick-robot: Jira Issue OCPBUGS-55809: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-55809 has been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #5017

/assign pperiyasamy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

openshift-bot commented May 8, 2025

[ART PR BUILD NOTIFIER]

Distgit: ose-machine-config-operator
This PR has been included in build ose-machine-config-operator-container-v4.19.0-202505081950.p0.ga9859b6.assembly.stream.el9.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented May 9, 2025

Fix included in accepted release 4.19.0-0.nightly-2025-05-09-024134

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yuqi-zhang yuqi-zhang yuqi-zhang approved these changes

@dkhater-redhat dkhater-redhat Awaiting requested review from dkhater-redhat

@RishabhSaini RishabhSaini Awaiting requested review from RishabhSaini

@anuragthehatter anuragthehatter Awaiting requested review from anuragthehatter

+1 more reviewer

@igsilya igsilya igsilya approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rbbratta rbbratta

@eurijon eurijon

@tssurya tssurya

@igsilya igsilya

@yuqi-zhang yuqi-zhang

@pperiyasamy pperiyasamy

@anuragthehatter anuragthehatter

@huiran0826 huiran0826

@mhanss mhanss

@ptalgulk01 ptalgulk01

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.