Skip to content

Conversation

@pperiyasamy
Copy link
Member

We noticed a cross streaming issue with Libreswan 5.2 creating duplicate child SAs on the node and no matching SA on the other end causing packet drops. To fix it, this commit makes wait-for-ipsec-connect.service updates openshift.conf with auto=start only for out connections.

We noticed a cross streaming issue with Libreswan 5.2 creating duplicate
child SAs on the node and no matching SA on the other end causing packet
drops.
To fix it, this commit makes wait-for-ipsec-connect.service updates
openshift.conf with auto=start only for out connections.

Signed-off-by: Periyasamy Palanisamy <[email protected]>
@pperiyasamy
Copy link
Member Author

/assign @igsilya @The-Mule @tssurya

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 29, 2025

@pperiyasamy: GitHub didn't allow me to assign the following users: The-Mule.

Note that only openshift members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

Details

In response to this:

/assign @igsilya @The-Mule @tssurya

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pperiyasamy pperiyasamy changed the title Use auto=start only for IPsec out connections OCPBUGS-55262: Use auto=start only for IPsec out connections May 2, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 2, 2025
@openshift-ci-robot
Copy link
Contributor

@pperiyasamy: This pull request references Jira Issue OCPBUGS-55262, which is invalid:

  • expected the bug to target either version "4.20." or "openshift-4.20.", but it targets "4.19.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

We noticed a cross streaming issue with Libreswan 5.2 creating duplicate child SAs on the node and no matching SA on the other end causing packet drops. To fix it, this commit makes wait-for-ipsec-connect.service updates openshift.conf with auto=start only for out connections.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pperiyasamy
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 2, 2025
@openshift-ci-robot
Copy link
Contributor

@pperiyasamy: This pull request references Jira Issue OCPBUGS-55262, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @huiran0826

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from huiran0826 May 2, 2025 10:48
Copy link

@igsilya igsilya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 2, 2025
@pperiyasamy
Copy link
Member Author

ipsec upgrade jobs seems to be running stable now with the fix: https://prow.ci.openshift.org/job-history/gs/test-platform-results/logs/multi-pr-openshift-cluster-network-operator-2695-openshift-machine-config-operator-5017-e2e-aws-ovn-ipsec-upgrade.
Thanks @igsilya for the suggesting this workaround ! Let's get this removed once we land openvswitch-ipsec systemd service.

@pperiyasamy
Copy link
Member Author

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label May 5, 2025
Copy link
Contributor

@yuqi-zhang yuqi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logically seems fine to me

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: igsilya, pperiyasamy, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2025
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD bed31f4 and 2 for PR HEAD debbcf2 in total

1 similar comment
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD bed31f4 and 2 for PR HEAD debbcf2 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 6, 2025

@pperiyasamy: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 0e18d46 into openshift:main May 6, 2025
15 of 18 checks passed
@openshift-ci-robot
Copy link
Contributor

@pperiyasamy: Jira Issue OCPBUGS-55262: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-55262 has been moved to the MODIFIED state.

Details

In response to this:

We noticed a cross streaming issue with Libreswan 5.2 creating duplicate child SAs on the node and no matching SA on the other end causing packet drops. To fix it, this commit makes wait-for-ipsec-connect.service updates openshift.conf with auto=start only for out connections.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-machine-config-operator
This PR has been included in build ose-machine-config-operator-container-v4.20.0-202505061310.p0.g0e18d46.assembly.stream.el9.
All builds following this will include this PR.

@pperiyasamy
Copy link
Member Author

/cherry-pick release-4.19

@openshift-cherrypick-robot

@pperiyasamy: new pull request created: #5035

Details

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants