-
Notifications
You must be signed in to change notification settings - Fork 462
OCPBUGS-55262: Use auto=start only for IPsec out connections #5017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-55262: Use auto=start only for IPsec out connections #5017
Conversation
We noticed a cross streaming issue with Libreswan 5.2 creating duplicate child SAs on the node and no matching SA on the other end causing packet drops. To fix it, this commit makes wait-for-ipsec-connect.service updates openshift.conf with auto=start only for out connections. Signed-off-by: Periyasamy Palanisamy <[email protected]>
|
@pperiyasamy: GitHub didn't allow me to assign the following users: The-Mule. Note that only openshift members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. |
|
@pperiyasamy: This pull request references Jira Issue OCPBUGS-55262, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@pperiyasamy: This pull request references Jira Issue OCPBUGS-55262, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
igsilya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
ipsec upgrade jobs seems to be running stable now with the fix: https://prow.ci.openshift.org/job-history/gs/test-platform-results/logs/multi-pr-openshift-cluster-network-operator-2695-openshift-machine-config-operator-5017-e2e-aws-ovn-ipsec-upgrade. |
|
/label acknowledge-critical-fixes-only |
yuqi-zhang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logically seems fine to me
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: igsilya, pperiyasamy, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
@pperiyasamy: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
0e18d46
into
openshift:main
|
@pperiyasamy: Jira Issue OCPBUGS-55262: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-55262 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: ose-machine-config-operator |
|
/cherry-pick release-4.19 |
|
@pperiyasamy: new pull request created: #5035 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
We noticed a cross streaming issue with Libreswan 5.2 creating duplicate child SAs on the node and no matching SA on the other end causing packet drops. To fix it, this commit makes
wait-for-ipsec-connect.serviceupdatesopenshift.confwithauto=startonly for out connections.