Skip to content

Conversation

@QiWang19
Copy link
Member

@QiWang19 QiWang19 commented Jul 18, 2024

Bump API to get the ClusterImagePolicy doc update openshift/api#1927
Run hack/crds-sync.sh to update the manifests

- What I did

- How to verify it

- Description for the changelog

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 18, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 18, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@QiWang19
Copy link
Member Author

/test all

@QiWang19 QiWang19 changed the title bump API and update CRD manifests OCPNODE-2438: bump API and update CRD manifests Jul 18, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 18, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 18, 2024

@QiWang19: This pull request references OCPNODE-2438 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

Details

In response to this:

Bump API to get the ClusterImagePolicy doc update
Run hack/crds-sync.sh to update the manifests

- What I did

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@QiWang19 QiWang19 marked this pull request as ready for review July 18, 2024 18:41
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 18, 2024
@openshift-ci openshift-ci bot requested review from cdoern and jkyros July 18, 2024 18:41
@QiWang19
Copy link
Member Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 18, 2024

@QiWang19: This pull request references OCPNODE-2438 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 22, 2024

@QiWang19: This pull request references OCPNODE-2438 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

Details

In response to this:

Bump API to get the ClusterImagePolicy doc update openshift/api#1927
Run hack/crds-sync.sh to update the manifests

- What I did

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@QiWang19
Copy link
Member Author

@yuqi-zhang Could you review?

@yuqi-zhang
Copy link
Contributor

I see another bump via @djoshy 's #4477 (which is 2 days behind yours).

Would you be ok with doing it as part of that PR instead? Would you need the bump to 07-17 or is 07-15 fine?

Bump API to get the ClusterImagePolicy doc update
Run hack/crds-sync.sh to update the manifests

Signed-off-by: Qi Wang <qiwan@redhat.com>
@QiWang19 QiWang19 force-pushed the clusterimagepolicy-crd branch from 030fa9c to 1c62b64 Compare July 23, 2024 16:04
@QiWang19
Copy link
Member Author

ClusterImagePolicy updates is not in #4477. I also need to bump to 7-17 to get openshift/api#1964

Copy link
Contributor

@yuqi-zhang yuqi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: QiWang19, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 112e225 and 2 for PR HEAD 1c62b64 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 24, 2024

@QiWang19: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-ovn-zones 1c62b64 link false /test e2e-vsphere-ovn-zones
ci/prow/e2e-vsphere-ovn-upi-zones 1c62b64 link false /test e2e-vsphere-ovn-upi-zones
ci/prow/e2e-vsphere-ovn-upi 1c62b64 link false /test e2e-vsphere-ovn-upi

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit b0e577b into openshift:master Jul 24, 2024
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-machine-config-operator
This PR has been included in build ose-machine-config-operator-container-v4.17.0-202407241046.p0.gb0e577b.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-machine-config-operator
This PR has been included in build ose-machine-config-operator-container-v4.18.0-202407241046.p0.gb0e577b.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants