MCO-1227: Run boot image controller only when required

[djoshy]

- What I did
This PR ensures that the boot image controller only runs on the correct combination of platform and feature gates.

- How to verify it
Bring up a cluster in techpreview. The boot image controller should only run on GCP and AWS platforms. This can be verified from the machine-config-controller logs.

oc logs -n openshift-machine-config-operator -f "$(oc get pod -o name -l='k8s-app=machine-config-controller' -n openshift-machine-config-operator)" | grep machine_set

Output should look something like:

I0717 14:13:22.580249       1 machine_set_boot_image_controller.go:275] Bootimages management configuration has been added, reconciling enrolled machine resources
I0717 14:13:22.580273       1 machine_set_boot_image_controller.go:361] No MAPI machinesets were enrolled, so no MAPI machinesets will be enqueued.
I0717 14:13:22.581460       1 machine_set_boot_image_controller.go:171] MAPI MachineSet djoshy20-rwm98-worker-a added, reconciling enrolled machine resources
I0717 14:13:22.581541       1 machine_set_boot_image_controller.go:171] MAPI MachineSet djoshy20-rwm98-worker-b added, reconciling enrolled machine resources
I0717 14:13:22.581576       1 machine_set_boot_image_controller.go:171] MAPI MachineSet djoshy20-rwm98-worker-c added, reconciling enrolled machine resources
I0717 14:13:22.582006       1 machine_set_boot_image_controller.go:221] configMap coreos-bootimages added, reconciling enrolled machine resources
I0717 14:13:22.661888       1 machine_set_boot_image_controller.go:161] Starting MachineConfigController-MachineSetBootImageController
I0717 14:13:22.730355       1 machine_set_boot_image_controller.go:361] No MAPI machinesets were enrolled, so no MAPI machinesets will be enqueued.
I0717 14:13:23.021122       1 machine_set_boot_image_controller.go:361] No MAPI machinesets were enrolled, so no MAPI machinesets will be enqueued.
I0717 14:13:23.404167       1 machine_set_boot_image_controller.go:361] No MAPI machinesets were enrolled, so no MAPI machinesets will be enqueued.
I0717 14:13:23.789165       1 machine_set_boot_image_controller.go:361] No MAPI machinesets were enrolled, so no MAPI machinesets will be enqueued.

On the default feature set, or any other platform in tech preview, the boot image controller should not come up, so no logs should show up.

Note: This PR only affects the enabling/disabling of the boot image controller - it does not affect its functionality. It should pass the existing e2es.

[openshift-ci-robot]

@djoshy: This pull request references MCO-1227 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

Details

In response to this:

- What I did
This PR ensures that the boot image controller only runs on the correct combination of platform and feature gates.

- How to verify it
Bring up a cluster in techpreview. The boot image controller should only run on GCP and AWS platform. This can be verified from the machine-config-controller logs.

Note: This PR only affects the enabling/disabling of the boot image controller - it does not affect its functionality. It should pass the existing e2es.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@djoshy: This pull request references MCO-1227 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

Details

In response to this:

- What I did
This PR ensures that the boot image controller only runs on the correct combination of platform and feature gates.

- How to verify it
Bring up a cluster in techpreview. The boot image controller should only run on GCP and AWS platforms. This can be verified from the machine-config-controller logs.

Note: This PR only affects the enabling/disabling of the boot image controller - it does not affect its functionality. It should pass the existing e2es.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@djoshy: This pull request references MCO-1227 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

Details

In response to this:

- What I did
This PR ensures that the boot image controller only runs on the correct combination of platform and feature gates.

- How to verify it
Bring up a cluster in techpreview. The boot image controller should only run on GCP and AWS platforms. This can be verified from the machine-config-controller logs.

On the default feature set, or any other platform in tech preview, the boot image controller should not come up.

Note: This PR only affects the enabling/disabling of the boot image controller - it does not affect its functionality. It should pass the existing e2es.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@djoshy: This pull request references MCO-1227 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

Details

In response to this:

- What I did
This PR ensures that the boot image controller only runs on the correct combination of platform and feature gates.

- How to verify it
Bring up a cluster in techpreview. The boot image controller should only run on GCP and AWS platforms. This can be verified from the machine-config-controller logs.

oc logs -n openshift-machine-config-operator -f "$(oc get pod -o name -l='k8s-app=machine-config-controller' -n openshift-machine-config-operator)" | grep machine_set

Output should look something like:

I0717 14:13:22.580249       1 machine_set_boot_image_controller.go:275] Bootimages management configuration has been added, reconciling enrolled machine resources
I0717 14:13:22.580273       1 machine_set_boot_image_controller.go:361] No MAPI machinesets were enrolled, so no MAPI machinesets will be enqueued.
I0717 14:13:22.581460       1 machine_set_boot_image_controller.go:171] MAPI MachineSet djoshy20-rwm98-worker-a added, reconciling enrolled machine resources
I0717 14:13:22.581541       1 machine_set_boot_image_controller.go:171] MAPI MachineSet djoshy20-rwm98-worker-b added, reconciling enrolled machine resources
I0717 14:13:22.581576       1 machine_set_boot_image_controller.go:171] MAPI MachineSet djoshy20-rwm98-worker-c added, reconciling enrolled machine resources
I0717 14:13:22.582006       1 machine_set_boot_image_controller.go:221] configMap coreos-bootimages added, reconciling enrolled machine resources
I0717 14:13:22.661888       1 machine_set_boot_image_controller.go:161] Starting MachineConfigController-MachineSetBootImageController
I0717 14:13:22.730355       1 machine_set_boot_image_controller.go:361] No MAPI machinesets were enrolled, so no MAPI machinesets will be enqueued.
I0717 14:13:23.021122       1 machine_set_boot_image_controller.go:361] No MAPI machinesets were enrolled, so no MAPI machinesets will be enqueued.
I0717 14:13:23.404167       1 machine_set_boot_image_controller.go:361] No MAPI machinesets were enrolled, so no MAPI machinesets will be enqueued.
I0717 14:13:23.789165       1 machine_set_boot_image_controller.go:361] No MAPI machinesets were enrolled, so no MAPI machinesets will be enqueued.

On the default feature set, or any other platform in tech preview, the boot image controller should not come up, so no logs should show up.

Note: This PR only affects the enabling/disabling of the boot image controller - it does not affect its functionality. It should pass the existing e2es.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@djoshy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-vsphere-ovn-upi	c1cc9e0	link	false	/test e2e-vsphere-ovn-upi

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[djoshy]

Chatted with Sergio on slack, and we decided QE testing is not necessary as this is mostly a gate for the controller running and not anything functional. I've tested it locally on a few platforms and it is working as expected.

[djoshy]

/tide refresh

[yuqi-zhang]

/lgtm

Seems like a safe change 👍

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [djoshy,yuqi-zhang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-machine-config-operator
This PR has been included in build ose-machine-config-operator-container-v4.17.0-202407230841.p0.ga2f5c74.assembly.stream.el9.
All builds following this will include this PR.