MCO-1125: OCPBUGS-35277: Allow paths to be defined for non-disruptive updates #4472

djoshy · 2024-07-11T19:46:38Z

- What I did

Add support for paths in file based NodeDisruptionPolicies. If multiple policies apply to a file being updated, the closest match will be considered.
Moved some of the "backdoor" directory based exceptions into the MCO's default policies.
Added a new default policy for the user CA cert to maintain feature parity until it moves to cert_writer.
Updated docs to reflect new defaults and path support.

- How to verify it

All previous NodeDisruptionPolicy behavior should still behave the same(node disruption e2e should pass)
The daemon should now behave correctly for user CA cert changes instead of rebooting.
To test the multi-path based policies:

Define more than one file based policy:

apiVersion: operator.openshift.io/v1
kind: MachineConfiguration
metadata:
  name: cluster
  namespace: openshift-machine-config-operator
spec:
  nodeDisruptionPolicy:
    files:
      - path: /etc/example/test
        actions:
          - type: None
      - path: /etc/example/
        actions:
          - reload:
              serviceName: crio.service
            type: Reload

Create an MC targeting the infra/worker pool that adds a file under /etc/example. Observe the daemon logs, this should cause a CRIO reload.

apiVersion: machineconfiguration.openshift.io/v1
kind: MachineConfig
metadata:
  labels:
    machineconfiguration.openshift.io/role: infra
  name:  111-test-file
spec:
  config:
    ignition:
      version: 3.2.0
    storage:
      files:
      - contents:
          source: data:text/plain;charset=utf-8;base64,SSBhbSB2ZXJzaW9uIDEKasas
        path: /etc/example/file
        user:
          name: core

Now create another MC targeting the same pool that adds a file under /etc/example/test. Observe the daemon logs, this should not cause any action.

apiVersion: machineconfiguration.openshift.io/v1
kind: MachineConfig
metadata:
  labels:
    machineconfiguration.openshift.io/role: infra
  name:  112-test-file
spec:
  config:
    ignition:
      version: 3.2.0
    storage:
      files:
      - contents:
          source: data:text/plain;charset=utf-8;base64,SSBhbSB2ZXJzaW9uIDEKasas
        path: /etc/example/test/file
        user:
          name: core

Note: Be sure to add a new MC, and not to overwrite the previous one from step (2). If you overwrite the first test MC, it will cause both policies to be in effect, as you are removing the old test file.

That's it! Nice job! 🚀

openshift-ci-robot · 2024-07-11T19:46:41Z

@djoshy: This pull request references MCO-1125 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

Details

In response to this:

- What I did

Add support for paths in file based NodeDisruptionPolicies. If multiple paths apply to a a path, the closest match will be considered.

Moved some of the "backdoor" directory based exceptions into the MCO's default policies.

Updated docs to reflect new defaults and di

- How to verify it

All previous NodeDisruptionPolicy behavior should still behave the same(node disruption e2e should pass)

To test the multi-path based policies:

Define more than one file based policy:
apiVersion: operator.openshift.io/v1
kind: MachineConfiguration
metadata:
 name: cluster
 namespace: openshift-machine-config-operator
spec:
 nodeDisruptionPolicy:
   files:
     - path: /etc/example/test
       actions:
         - type: None
     - path: /etc/example/
       actions:
         - reload:
             serviceName: crio.service
           type: Reload
Create an MC targeting the infra/worker pool that adds a file under /etc/example. Observe the daemon logs, this should cause a CRIO reload.
apiVersion: machineconfiguration.openshift.io/v1
kind: MachineConfig
metadata:
 labels:
   machineconfiguration.openshift.io/role: infra
 name:  111-test-file
spec:
 config:
   ignition:
     version: 3.2.0
   storage:
     files:
     - contents:
         source: data:text/plain;charset=utf-8;base64,SSBhbSB2ZXJzaW9uIDEKasas
       path: /etc/example/file
       user:
         name: core
Now create another MC targeting the same pool that adds a file under /etc/example/test. Observe the daemon logs, this should not cause any action.
apiVersion: machineconfiguration.openshift.io/v1
kind: MachineConfig
metadata:
 labels:
   machineconfiguration.openshift.io/role: infra
 name:  112-test-file
spec:
 config:
   ignition:
     version: 3.2.0
   storage:
     files:
     - contents:
         source: data:text/plain;charset=utf-8;base64,SSBhbSB2ZXJzaW9uIDEKasas
       path: /etc/example/test/file
       user:
         name: core
Note: Be sure to add a new MC, and not to overwrite the previous one from step (2). If you overwrite the first test MC, it will cause both policies to be in effect, as you are removing the old test file.

That's it! Nice job! 🚀

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-07-11T19:53:02Z

@djoshy: This pull request references MCO-1125 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

Details

In response to this:

- What I did

Add support for paths in file based NodeDisruptionPolicies. If multiple paths apply to a a path, the closest match will be considered.

Moved some of the "backdoor" directory based exceptions into the MCO's default policies.

Updated docs to reflect new defaults and path support.

- How to verify it

All previous NodeDisruptionPolicy behavior should still behave the same(node disruption e2e should pass)

To test the multi-path based policies:

Define more than one file based policy:
apiVersion: operator.openshift.io/v1
kind: MachineConfiguration
metadata:
 name: cluster
 namespace: openshift-machine-config-operator
spec:
 nodeDisruptionPolicy:
   files:
     - path: /etc/example/test
       actions:
         - type: None
     - path: /etc/example/
       actions:
         - reload:
             serviceName: crio.service
           type: Reload
Create an MC targeting the infra/worker pool that adds a file under /etc/example. Observe the daemon logs, this should cause a CRIO reload.
apiVersion: machineconfiguration.openshift.io/v1
kind: MachineConfig
metadata:
 labels:
   machineconfiguration.openshift.io/role: infra
 name:  111-test-file
spec:
 config:
   ignition:
     version: 3.2.0
   storage:
     files:
     - contents:
         source: data:text/plain;charset=utf-8;base64,SSBhbSB2ZXJzaW9uIDEKasas
       path: /etc/example/file
       user:
         name: core
Now create another MC targeting the same pool that adds a file under /etc/example/test. Observe the daemon logs, this should not cause any action.
apiVersion: machineconfiguration.openshift.io/v1
kind: MachineConfig
metadata:
 labels:
   machineconfiguration.openshift.io/role: infra
 name:  112-test-file
spec:
 config:
   ignition:
     version: 3.2.0
   storage:
     files:
     - contents:
         source: data:text/plain;charset=utf-8;base64,SSBhbSB2ZXJzaW9uIDEKasas
       path: /etc/example/test/file
       user:
         name: core
Note: Be sure to add a new MC, and not to overwrite the previous one from step (2). If you overwrite the first test MC, it will cause both policies to be in effect, as you are removing the old test file.

That's it! Nice job! 🚀

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-07-16T14:46:22Z

@djoshy: This pull request references MCO-1125 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

Details

In response to this:

- What I did

Add support for paths in file based NodeDisruptionPolicies. If multiple paths apply to a a path, the closest match will be considered.

Moved some of the "backdoor" directory based exceptions into the MCO's default policies.

Added a new default policy for the user CA cert to maintain feature parity until it moves to cert_writer.

Updated docs to reflect new defaults and path support.

- How to verify it

All previous NodeDisruptionPolicy behavior should still behave the same(node disruption e2e should pass)

The daemon should now behave correctly for user CA cert changes instead of rebooting.

To test the multi-path based policies:

Define more than one file based policy:
apiVersion: operator.openshift.io/v1
kind: MachineConfiguration
metadata:
 name: cluster
 namespace: openshift-machine-config-operator
spec:
 nodeDisruptionPolicy:
   files:
     - path: /etc/example/test
       actions:
         - type: None
     - path: /etc/example/
       actions:
         - reload:
             serviceName: crio.service
           type: Reload
Create an MC targeting the infra/worker pool that adds a file under /etc/example. Observe the daemon logs, this should cause a CRIO reload.
apiVersion: machineconfiguration.openshift.io/v1
kind: MachineConfig
metadata:
 labels:
   machineconfiguration.openshift.io/role: infra
 name:  111-test-file
spec:
 config:
   ignition:
     version: 3.2.0
   storage:
     files:
     - contents:
         source: data:text/plain;charset=utf-8;base64,SSBhbSB2ZXJzaW9uIDEKasas
       path: /etc/example/file
       user:
         name: core
Now create another MC targeting the same pool that adds a file under /etc/example/test. Observe the daemon logs, this should not cause any action.
apiVersion: machineconfiguration.openshift.io/v1
kind: MachineConfig
metadata:
 labels:
   machineconfiguration.openshift.io/role: infra
 name:  112-test-file
spec:
 config:
   ignition:
     version: 3.2.0
   storage:
     files:
     - contents:
         source: data:text/plain;charset=utf-8;base64,SSBhbSB2ZXJzaW9uIDEKasas
       path: /etc/example/test/file
       user:
         name: core
Note: Be sure to add a new MC, and not to overwrite the previous one from step (2). If you overwrite the first test MC, it will cause both policies to be in effect, as you are removing the old test file.

That's it! Nice job! 🚀

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

sergiordlr · 2024-07-19T10:15:47Z

Verified OCPBUGS-35277 using IPI on AWS

Test cases passed with enabled techpreview:

"[sig-mco] MCO security Author:rioliu-NonHyperShiftHOST-NonPreRelease-Longduration-High-71991-post action of user-ca-bundle change will skip drain,reboot and restart crio service [Disruptive] [Serial]"
"[sig-mco] MCO security Author:sregidor-NonHyperShiftHOST-High-67660-MCS generates ignition configs with certs [Disruptive] [Serial]"

openshift-ci-robot · 2024-07-19T10:15:53Z

@djoshy: This pull request references MCO-1125 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

Details

In response to this:

- What I did

Add support for paths in file based NodeDisruptionPolicies. If multiple paths apply to a a path, the closest match will be considered.

Moved some of the "backdoor" directory based exceptions into the MCO's default policies.

Added a new default policy for the user CA cert to maintain feature parity until it moves to cert_writer.

Updated docs to reflect new defaults and path support.

- How to verify it

All previous NodeDisruptionPolicy behavior should still behave the same(node disruption e2e should pass)

The daemon should now behave correctly for user CA cert changes instead of rebooting.

To test the multi-path based policies:

Define more than one file based policy:
apiVersion: operator.openshift.io/v1
kind: MachineConfiguration
metadata:
 name: cluster
 namespace: openshift-machine-config-operator
spec:
 nodeDisruptionPolicy:
   files:
     - path: /etc/example/test
       actions:
         - type: None
     - path: /etc/example/
       actions:
         - reload:
             serviceName: crio.service
           type: Reload
Create an MC targeting the infra/worker pool that adds a file under /etc/example. Observe the daemon logs, this should cause a CRIO reload.
apiVersion: machineconfiguration.openshift.io/v1
kind: MachineConfig
metadata:
 labels:
   machineconfiguration.openshift.io/role: infra
 name:  111-test-file
spec:
 config:
   ignition:
     version: 3.2.0
   storage:
     files:
     - contents:
         source: data:text/plain;charset=utf-8;base64,SSBhbSB2ZXJzaW9uIDEKasas
       path: /etc/example/file
       user:
         name: core
Now create another MC targeting the same pool that adds a file under /etc/example/test. Observe the daemon logs, this should not cause any action.
apiVersion: machineconfiguration.openshift.io/v1
kind: MachineConfig
metadata:
 labels:
   machineconfiguration.openshift.io/role: infra
 name:  112-test-file
spec:
 config:
   ignition:
     version: 3.2.0
   storage:
     files:
     - contents:
         source: data:text/plain;charset=utf-8;base64,SSBhbSB2ZXJzaW9uIDEKasas
       path: /etc/example/test/file
       user:
         name: core
Note: Be sure to add a new MC, and not to overwrite the previous one from step (2). If you overwrite the first test MC, it will cause both policies to be in effect, as you are removing the old test file.

That's it! Nice job! 🚀

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

sergiordlr · 2024-07-19T10:18:23Z

/remove-label qe-approved

openshift-ci-robot · 2024-07-19T10:18:28Z

@djoshy: This pull request references MCO-1125 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

Details

In response to this:

- What I did

Add support for paths in file based NodeDisruptionPolicies. If multiple paths apply to a a path, the closest match will be considered.

Moved some of the "backdoor" directory based exceptions into the MCO's default policies.

Added a new default policy for the user CA cert to maintain feature parity until it moves to cert_writer.

Updated docs to reflect new defaults and path support.

- How to verify it

All previous NodeDisruptionPolicy behavior should still behave the same(node disruption e2e should pass)

The daemon should now behave correctly for user CA cert changes instead of rebooting.

To test the multi-path based policies:

Define more than one file based policy:
apiVersion: operator.openshift.io/v1
kind: MachineConfiguration
metadata:
 name: cluster
 namespace: openshift-machine-config-operator
spec:
 nodeDisruptionPolicy:
   files:
     - path: /etc/example/test
       actions:
         - type: None
     - path: /etc/example/
       actions:
         - reload:
             serviceName: crio.service
           type: Reload
Create an MC targeting the infra/worker pool that adds a file under /etc/example. Observe the daemon logs, this should cause a CRIO reload.
apiVersion: machineconfiguration.openshift.io/v1
kind: MachineConfig
metadata:
 labels:
   machineconfiguration.openshift.io/role: infra
 name:  111-test-file
spec:
 config:
   ignition:
     version: 3.2.0
   storage:
     files:
     - contents:
         source: data:text/plain;charset=utf-8;base64,SSBhbSB2ZXJzaW9uIDEKasas
       path: /etc/example/file
       user:
         name: core
Now create another MC targeting the same pool that adds a file under /etc/example/test. Observe the daemon logs, this should not cause any action.
apiVersion: machineconfiguration.openshift.io/v1
kind: MachineConfig
metadata:
 labels:
   machineconfiguration.openshift.io/role: infra
 name:  112-test-file
spec:
 config:
   ignition:
     version: 3.2.0
   storage:
     files:
     - contents:
         source: data:text/plain;charset=utf-8;base64,SSBhbSB2ZXJzaW9uIDEKasas
       path: /etc/example/test/file
       user:
         name: core
Note: Be sure to add a new MC, and not to overwrite the previous one from step (2). If you overwrite the first test MC, it will cause both policies to be in effect, as you are removing the old test file.

That's it! Nice job! 🚀

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

sergiordlr · 2024-07-19T10:19:18Z

/hold

Still verifying the path functionality

openshift-ci-robot · 2024-07-19T13:22:43Z

@djoshy: This pull request references MCO-1125 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

Details

In response to this:

- What I did

Add support for paths in file based NodeDisruptionPolicies. If multiple policies apply to a file being updated, the closest match will be considered.

Moved some of the "backdoor" directory based exceptions into the MCO's default policies.

Added a new default policy for the user CA cert to maintain feature parity until it moves to cert_writer.

Updated docs to reflect new defaults and path support.

- How to verify it

All previous NodeDisruptionPolicy behavior should still behave the same(node disruption e2e should pass)

The daemon should now behave correctly for user CA cert changes instead of rebooting.

To test the multi-path based policies:

Define more than one file based policy:
apiVersion: operator.openshift.io/v1
kind: MachineConfiguration
metadata:
 name: cluster
 namespace: openshift-machine-config-operator
spec:
 nodeDisruptionPolicy:
   files:
     - path: /etc/example/test
       actions:
         - type: None
     - path: /etc/example/
       actions:
         - reload:
             serviceName: crio.service
           type: Reload
Create an MC targeting the infra/worker pool that adds a file under /etc/example. Observe the daemon logs, this should cause a CRIO reload.
apiVersion: machineconfiguration.openshift.io/v1
kind: MachineConfig
metadata:
 labels:
   machineconfiguration.openshift.io/role: infra
 name:  111-test-file
spec:
 config:
   ignition:
     version: 3.2.0
   storage:
     files:
     - contents:
         source: data:text/plain;charset=utf-8;base64,SSBhbSB2ZXJzaW9uIDEKasas
       path: /etc/example/file
       user:
         name: core
Now create another MC targeting the same pool that adds a file under /etc/example/test. Observe the daemon logs, this should not cause any action.
apiVersion: machineconfiguration.openshift.io/v1
kind: MachineConfig
metadata:
 labels:
   machineconfiguration.openshift.io/role: infra
 name:  112-test-file
spec:
 config:
   ignition:
     version: 3.2.0
   storage:
     files:
     - contents:
         source: data:text/plain;charset=utf-8;base64,SSBhbSB2ZXJzaW9uIDEKasas
       path: /etc/example/test/file
       user:
         name: core
Note: Be sure to add a new MC, and not to overwrite the previous one from step (2). If you overwrite the first test MC, it will cause both policies to be in effect, as you are removing the old test file.

That's it! Nice job! 🚀

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

sergiordlr · 2024-07-19T15:01:17Z

Verified path support using IPI on AWS

Configure 3 paths in the Machineconfiguration nodedisruption section

(dir) /etc/test-file-policy-subdir-75109/extradir/
action none
(dir) /etc/test-file-policy-subdir-75109
action restart crio
(file) /etc/test-file-policy-subdir-75109/test-file.txt
action reload crio

1 Create a MC for /etc/test-file-policy-subdir-75109/test-file.txt
2 Check that crio.service was reloaded
3 Create a MC for /etc/test-file-policy-subdir-75109/test-dir.txt
4 Check that crio.service was restarted
5 Create a MC for /etc/test-file-policy-subdir-75109/extradir/test-file.txt
6 Check that no action is executed

The commands for every step can be found in test case: OCP-75109 - NodeDisruptionPolicy files allow paths to be defined for non-disruptive updates

/label qe-approved

openshift-ci · 2024-07-19T15:01:32Z

@sergiordlr: Those labels are not set on the issue: qe-approved

Details

In response to this:

Verified path support using IPI on AWS

Configure 3 paths in the Machineconfiguration nodedisruption section

(dir) /etc/test-file-policy-subdir-75109/extradir/
action none

(dir) /etc/test-file-policy-subdir-75109
action restart crio

(file) /etc/test-file-policy-subdir-75109/test-file.txt
action reload crio

1 Create a MC for /etc/test-file-policy-subdir-75109/test-file.txt
2 Check that crio.service was reloaded
3 Create a MC for /etc/test-file-policy-subdir-75109/test-dir.txt
4 Check that crio.service was restarted
5 Create a MC for /etc/test-file-policy-subdir-75109/extradir/test-file.txt
6 Check that no action is executed

The commands for every step can be found in test case: OCP-75109 - NodeDisruptionPolicy files allow paths to be defined for non-disruptive updates

/remove-label qe-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

sergiordlr · 2024-07-19T15:04:40Z

/label qe-approved

openshift-ci-robot · 2024-07-19T15:04:47Z

@djoshy: This pull request references MCO-1125 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

Details

In response to this:

- What I did

Add support for paths in file based NodeDisruptionPolicies. If multiple policies apply to a file being updated, the closest match will be considered.

Moved some of the "backdoor" directory based exceptions into the MCO's default policies.

Added a new default policy for the user CA cert to maintain feature parity until it moves to cert_writer.

Updated docs to reflect new defaults and path support.

- How to verify it

All previous NodeDisruptionPolicy behavior should still behave the same(node disruption e2e should pass)

The daemon should now behave correctly for user CA cert changes instead of rebooting.

To test the multi-path based policies:

Define more than one file based policy:
apiVersion: operator.openshift.io/v1
kind: MachineConfiguration
metadata:
 name: cluster
 namespace: openshift-machine-config-operator
spec:
 nodeDisruptionPolicy:
   files:
     - path: /etc/example/test
       actions:
         - type: None
     - path: /etc/example/
       actions:
         - reload:
             serviceName: crio.service
           type: Reload
Create an MC targeting the infra/worker pool that adds a file under /etc/example. Observe the daemon logs, this should cause a CRIO reload.
apiVersion: machineconfiguration.openshift.io/v1
kind: MachineConfig
metadata:
 labels:
   machineconfiguration.openshift.io/role: infra
 name:  111-test-file
spec:
 config:
   ignition:
     version: 3.2.0
   storage:
     files:
     - contents:
         source: data:text/plain;charset=utf-8;base64,SSBhbSB2ZXJzaW9uIDEKasas
       path: /etc/example/file
       user:
         name: core
Now create another MC targeting the same pool that adds a file under /etc/example/test. Observe the daemon logs, this should not cause any action.
apiVersion: machineconfiguration.openshift.io/v1
kind: MachineConfig
metadata:
 labels:
   machineconfiguration.openshift.io/role: infra
 name:  112-test-file
spec:
 config:
   ignition:
     version: 3.2.0
   storage:
     files:
     - contents:
         source: data:text/plain;charset=utf-8;base64,SSBhbSB2ZXJzaW9uIDEKasas
       path: /etc/example/test/file
       user:
         name: core
Note: Be sure to add a new MC, and not to overwrite the previous one from step (2). If you overwrite the first test MC, it will cause both policies to be in effect, as you are removing the old test file.

That's it! Nice job! 🚀

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

yuqi-zhang

General logic makes sense to me! I think 2 things here:

let's add some additional unit testing around FindClosestFilePolicyPathMatch. I don't think there should be any edge cases but best to be safe, especially if you have multiple policies
let's make sure we capture this change in other documentation as well (maybe enhancement? for sure the openshift docs)

djoshy · 2024-07-22T18:08:22Z

let's add some additional unit testing around FindClosestFilePolicyPathMatch. I don't think there should be any edge cases but best to be safe, especially if you have multiple policies

Added a few cases I could think of, let me know if that works!

let's make sure we capture this change in other documentation as well (maybe enhancement? for sure the openshift docs)

I'll make a card in the epic to track this (:

djoshy · 2024-07-22T20:04:15Z

/retest-required

yuqi-zhang

/lgtm

Tests lgtm, thanks!

pkg/daemon/update_test.go

djoshy · 2024-07-23T12:45:37Z

/unhold

yuqi-zhang · 2024-07-23T12:56:09Z

/lgtm

openshift-ci · 2024-07-23T12:57:03Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [djoshy,yuqi-zhang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

djoshy · 2024-07-23T15:17:32Z

/test e2e-gcp-op-techpreview

djoshy · 2024-07-23T16:31:01Z

/test e2e-gcp-op
/test e2e-gcp-op-techpreview

openshift-ci · 2024-07-23T19:29:29Z

@djoshy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-vsphere-ovn-upi	`9d52686`	link	false	`/test e2e-vsphere-ovn-upi`
ci/prow/e2e-vsphere-ovn-zones	`9d52686`	link	false	`/test e2e-vsphere-ovn-zones`
ci/prow/e2e-vsphere-ovn-upi-zones	`9d52686`	link	false	`/test e2e-vsphere-ovn-upi-zones`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-bot · 2024-07-23T22:58:34Z

[ART PR BUILD NOTIFIER]

Distgit: ose-machine-config-operator
This PR has been included in build ose-machine-config-operator-container-v4.18.0-202407232010.p0.g3acda20.assembly.stream.el9.
All builds following this will include this PR.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 11, 2024

openshift-ci bot requested review from cheesesashimi and dkhater-redhat July 11, 2024 19:47

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2024

djoshy force-pushed the node-disrupt-path branch from 08f3826 to 72cfc73 Compare July 16, 2024 14:42

djoshy changed the title ~~MCO-1125: Allow paths to be defined for non-disruptive updates~~ MCO-1125: OCPBUGS-35277: Allow paths to be defined for non-disruptive updates Jul 16, 2024

add directory support for NodeDisruptionPolicy

59a0955

djoshy force-pushed the node-disrupt-path branch from 72cfc73 to 59a0955 Compare July 16, 2024 14:48

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jul 19, 2024

openshift-ci bot removed the qe-approved Signifies that QE has signed off on this PR label Jul 19, 2024

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 19, 2024

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jul 19, 2024

yuqi-zhang approved these changes Jul 21, 2024

View reviewed changes

yuqi-zhang reviewed Jul 23, 2024

View reviewed changes

pkg/daemon/update_test.go Outdated Show resolved Hide resolved

openshift-ci bot assigned yuqi-zhang Jul 23, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2024

daemon: add unit tests for path based policies

9d52686

djoshy force-pushed the node-disrupt-path branch from b5d9002 to 9d52686 Compare July 23, 2024 12:43

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2024

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 23, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2024

openshift-merge-bot bot merged commit 3acda20 into openshift:master Jul 23, 2024

djoshy deleted the node-disrupt-path branch July 26, 2024 17:53

djoshy mentioned this pull request Jul 30, 2024

MCO-1065: MCO-1171: API bump for ManagedBootImages and NodeDisruptionPolicy GA #4496

Merged

MCO-1125: OCPBUGS-35277: Allow paths to be defined for non-disruptive updates #4472

MCO-1125: OCPBUGS-35277: Allow paths to be defined for non-disruptive updates #4472

Uh oh!

Conversation

djoshy commented Jul 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Jul 11, 2024 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Jul 11, 2024 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Jul 16, 2024 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sergiordlr commented Jul 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Jul 19, 2024 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sergiordlr commented Jul 19, 2024

Uh oh!

openshift-ci-robot commented Jul 19, 2024 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sergiordlr commented Jul 19, 2024

Uh oh!

openshift-ci-robot commented Jul 19, 2024 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sergiordlr commented Jul 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Jul 19, 2024

Uh oh!

sergiordlr commented Jul 19, 2024

Uh oh!

openshift-ci-robot commented Jul 19, 2024 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yuqi-zhang left a comment

Choose a reason for hiding this comment

Uh oh!

djoshy commented Jul 22, 2024

Uh oh!

djoshy commented Jul 22, 2024

Uh oh!

yuqi-zhang left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

djoshy commented Jul 23, 2024

Uh oh!

yuqi-zhang commented Jul 23, 2024

Uh oh!

openshift-ci bot commented Jul 23, 2024

Uh oh!

djoshy commented Jul 23, 2024

Uh oh!

djoshy commented Jul 23, 2024

Uh oh!

openshift-ci bot commented Jul 23, 2024

Uh oh!

openshift-bot commented Jul 23, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

djoshy commented Jul 11, 2024 •

edited

Loading

openshift-ci-robot commented Jul 11, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Jul 11, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Jul 16, 2024 •

edited by openshift-ci bot

Loading

sergiordlr commented Jul 19, 2024 •

edited

Loading

openshift-ci-robot commented Jul 19, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Jul 19, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Jul 19, 2024 •

edited by openshift-ci bot

Loading

sergiordlr commented Jul 19, 2024 •

edited

Loading

openshift-ci-robot commented Jul 19, 2024 •

edited by openshift-ci bot

Loading