Match image reference in osimageurl configmap

[jlebon]

Minor regression from #404. For the substitution to take place, the
pullspec has to match exactly.

---

I'm still confirming it, but I think this is the root of my issues in #363 (comment). The masters are getting their osImageURL from the bootstrap path (which gets it from the image-references file in the payload), while the controller gets it from the configmap, so the mismatch was causing a checksum diff.

I think the e2e-aws tests didn't fail on this because it follows a slightly different path? openshift/origin#21919

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlebon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [jlebon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jlebon]

/hold

[cgwalters]

#363 has d58765b

Are you sure you were testing with that commit included?

[jlebon]

Are you sure you were testing with that commit included?

Oh wow, completely missed that. I had only cherry-picked the HEAD. 😇
OK, so sanity confirmed.

Thoughts on the added text here?

[cgwalters]

I think my vote is after we branch, make it a completely dummy value not resembling the real ones. But at this point I'd probably stick with trying to get #363 in as is? Just since it's a known quantity.

[openshift-ci-robot]

@jlebon: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-op	4248c32	link	/test e2e-aws-op
ci/prow/e2e-aws	4248c32	link	/test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.