-
Notifications
You must be signed in to change notification settings - Fork 461
image-references: Update maipo oscontainer #404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
image-references: Update maipo oscontainer #404
Conversation
This isn't the long term path, but let's do this until we have that implemented.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashcrow, cgwalters The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test e2e-aws |
|
Can we add the corresponding OS version as a comment there? |
|
/flake /test e2e-aws |
|
Different flake ... /test e2e-aws |
|
/test e2e-aws |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
For reference I was confused about how things work; the images referenced here are basically never really used...we should probably replace them with dummy values now. The source of truth (AIUI) is the imagestreams maintained at api.ci which feed into the release controller, which uses them to update the release payload's openshift/origin#21998 was trying to do this a different way but for now we're going to do some manual tagging. |
Minor regression from openshift#404. For the substitution to take place, the pullspec has to match exactly.
This isn't the long term path, but let's do this until
we have that implemented.