Skip to content

Conversation

@cgwalters
Copy link
Member

This isn't the long term path, but let's do this until
we have that implemented.

This isn't the long term path, but let's do this until
we have that implemented.
@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 11, 2019
@ashcrow
Copy link
Member

ashcrow commented Feb 11, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 11, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashcrow, cgwalters

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ashcrow
Copy link
Member

ashcrow commented Feb 11, 2019

aws_route_table_association.route_net.1: timeout while waiting for state to become 'success'

/test e2e-aws

@jlebon
Copy link
Member

jlebon commented Feb 11, 2019

Can we add the corresponding OS version as a comment there?

@ashcrow
Copy link
Member

ashcrow commented Feb 11, 2019

/flake

/test e2e-aws

@ashcrow
Copy link
Member

ashcrow commented Feb 11, 2019

Different flake ...

/test e2e-aws

@ashcrow
Copy link
Member

ashcrow commented Feb 11, 2019

/test e2e-aws

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 5656913 into openshift:master Feb 12, 2019
@cgwalters
Copy link
Member Author

For reference I was confused about how things work; the images referenced here are basically never really used...we should probably replace them with dummy values now.

The source of truth (AIUI) is the imagestreams maintained at api.ci which feed into the release controller, which uses them to update the release payload's machine-os-content and oc adm release new will use that digested pull spec and replace the value here.

openshift/origin#21998 was trying to do this a different way but for now we're going to do some manual tagging.

jlebon added a commit to jlebon/machine-config-operator that referenced this pull request Feb 14, 2019
Minor regression from openshift#404. For the substitution to take place, the
pullspec has to match exactly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants