Skip to content

Nutanix platform #2852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yannickstruyf3 wants to merge 4 commits into from
Closed

Nutanix platform #2852

yannickstruyf3 wants to merge 4 commits into from

Conversation

@yannickstruyf3
Copy link

@yannickstruyf3 yannickstruyf3 commented Dec 2, 2021

Adding the Nutanix platform to the MCO Operator.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 2, 2021

Hi @yannickstruyf3. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 2, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yannickstruyf3
To complete the pull request process, please assign yuqi-zhang after the PR has been reviewed.
You can assign the PR to them by writing /assign @yuqi-zhang in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 2, 2021
@openshift-ci openshift-ci bot requested review from jkyros and sinnykumari December 2, 2021 13:04
@kikisdeliveryservice
Copy link
Contributor

kikisdeliveryservice commented Dec 2, 2021

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 2, 2021
kikisdeliveryservice
kikisdeliveryservice reviewed Dec 2, 2021
View reviewed changes
Copy link
Contributor

@kikisdeliveryservice kikisdeliveryservice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 questions:

  1. does this require changes in https://github.com/openshift/machine-config-operator/tree/master/templates/common

  2. if so, can you also add OWNERS for this so your team can be responsible for your templates/etc: https://github.com/openshift/machine-config-operator/blob/master/OWNERS_ALIASES

@sinnykumari
Copy link
Contributor

sinnykumari commented Dec 3, 2021

You need to get openshift/api#1059 merged first and then get the new openshift/api containing fixes vendored in MCO repo https://github.com/openshift/api/.

Putting hold until above has been done
/hold
Please remove hold once all the per-requesites has been done and is ready for review.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 3, 2021
@yannickstruyf3
Copy link
Author

yannickstruyf3 commented Dec 9, 2021

@kikisdeliveryservice I added the approvers and also an update to the controllerconfig.crd.yaml

@openshift-ci openshift-ci bot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Dec 9, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Dec 9, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2021

@yannickstruyf3: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 15, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 21, 2021

@yannickstruyf3: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/bootstrap-unit 2283c1d link false /test bootstrap-unit
ci/prow/verify 2283c1d link true /test verify
ci/prow/e2e-vsphere-upgrade 2283c1d link false /test e2e-vsphere-upgrade
ci/prow/unit 2283c1d link true /test unit
ci/prow/images 2283c1d link true /test images
ci/prow/e2e-ovn-step-registry 2283c1d link false /test e2e-ovn-step-registry
ci/prow/e2e-aws-workers-rhel8 2283c1d link false /test e2e-aws-workers-rhel8
ci/prow/e2e-aws-upgrade-single-node 2283c1d link false /test e2e-aws-upgrade-single-node
ci/prow/e2e-aws-single-node 2283c1d link false /test e2e-aws-single-node
ci/prow/e2e-aws-disruptive 2283c1d link false /test e2e-aws-disruptive
ci/prow/e2e-gcp-op-single-node 2283c1d link false /test e2e-gcp-op-single-node
ci/prow/e2e-aws-serial 2283c1d link false /test e2e-aws-serial
ci/prow/e2e-metal-ipi 2283c1d link false /test e2e-metal-ipi
ci/prow/e2e-aws-workers-rhel7 2283c1d link false /test e2e-aws-workers-rhel7
ci/prow/okd-e2e-aws 2283c1d link false /test okd-e2e-aws
ci/prow/okd-images 2283c1d link false /test okd-images
ci/prow/e2e-gcp-op 2283c1d link true /test e2e-gcp-op
ci/prow/e2e-aws 2283c1d link true /test e2e-aws
ci/prow/e2e-agnostic-upgrade 2283c1d link true /test e2e-agnostic-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@thunderboltsid
Copy link
Contributor

thunderboltsid commented Feb 3, 2022

Rebased version of this PR can be found at #2942

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkyros jkyros Awaiting requested review from jkyros

@sinnykumari sinnykumari Awaiting requested review from sinnykumari

1 more reviewer

@kikisdeliveryservice kikisdeliveryservice kikisdeliveryservice left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yannickstruyf3 @kikisdeliveryservice @sinnykumari @thunderboltsid