Bug 2040671: Configure-ovs: Ensure DHCP finishes for both address families #2929

trozet · 2022-01-24T23:07:43Z

When activating the br-ex connection, NM would return success if only
one of the address families got an IP. We should wait for both families
in the case of dualstack.

Signed-off-by: Tim Rozet [email protected]

trozet · 2022-01-24T23:08:24Z

/test e2e-metal-ipi-ovn-dualstack

trozet · 2022-01-25T14:15:44Z

/test e2e-metal-ipi-ovn-dualstack

trozet · 2022-01-25T14:37:02Z

/test ci/prow/e2e-metal-ipi-ovn-dualstack

openshift-ci · 2022-01-25T14:37:04Z

@trozet: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test cluster-bootimages
/test e2e-agnostic-upgrade
/test e2e-aws
/test e2e-gcp-op
/test images
/test unit
/test verify

The following commands are available to trigger optional jobs:

/test bootstrap-unit
/test e2e-aws-disruptive
/test e2e-aws-proxy
/test e2e-aws-serial
/test e2e-aws-single-node
/test e2e-aws-upgrade
/test e2e-aws-upgrade-single-node
/test e2e-aws-workers-rhel7
/test e2e-aws-workers-rhel8
/test e2e-azure
/test e2e-azure-upgrade
/test e2e-gcp-op-single-node
/test e2e-gcp-single-node
/test e2e-gcp-upgrade
/test e2e-metal-assisted
/test e2e-metal-ipi
/test e2e-metal-ipi-ovn-dualstack
/test e2e-metal-ipi-ovn-ipv6
/test e2e-openstack
/test e2e-openstack-parallel
/test e2e-ovirt
/test e2e-ovirt-upgrade
/test e2e-ovn-step-registry
/test e2e-vsphere
/test e2e-vsphere-upgrade
/test e2e-vsphere-upi
/test okd-e2e-aws
/test okd-e2e-gcp-op
/test okd-e2e-upgrade
/test okd-e2e-vsphere
/test okd-images

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-machine-config-operator-master-bootstrap-unit
pull-ci-openshift-machine-config-operator-master-e2e-agnostic-upgrade
pull-ci-openshift-machine-config-operator-master-e2e-aws
pull-ci-openshift-machine-config-operator-master-e2e-aws-disruptive
pull-ci-openshift-machine-config-operator-master-e2e-aws-serial
pull-ci-openshift-machine-config-operator-master-e2e-aws-single-node
pull-ci-openshift-machine-config-operator-master-e2e-aws-upgrade-single-node
pull-ci-openshift-machine-config-operator-master-e2e-aws-workers-rhel7
pull-ci-openshift-machine-config-operator-master-e2e-aws-workers-rhel8
pull-ci-openshift-machine-config-operator-master-e2e-gcp-op
pull-ci-openshift-machine-config-operator-master-e2e-gcp-op-single-node
pull-ci-openshift-machine-config-operator-master-e2e-metal-ipi
pull-ci-openshift-machine-config-operator-master-e2e-ovn-step-registry
pull-ci-openshift-machine-config-operator-master-e2e-vsphere-upgrade
pull-ci-openshift-machine-config-operator-master-images
pull-ci-openshift-machine-config-operator-master-okd-e2e-aws
pull-ci-openshift-machine-config-operator-master-okd-images
pull-ci-openshift-machine-config-operator-master-unit
pull-ci-openshift-machine-config-operator-master-verify

Details

In response to this:

/test ci/prow/e2e-metal-ipi-ovn-dualstack

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

When activating the br-ex connection, NM would return success if only one of the address families got an IP. We should wait for both families in the case of dualstack. Signed-off-by: Tim Rozet <[email protected]>

trozet · 2022-01-25T16:56:51Z

/test e2e-metal-ipi-ovn-dualstack

openshift-ci · 2022-01-25T20:41:16Z

@trozet: This pull request references Bugzilla bug 2040671, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.0) matches configured target release for branch (4.10.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

Details

In response to this:

Bug 2040671: Configure-ovs: Ensure DHCP finishes for both address families

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

flavio-fernandes

/lgtm

trozet · 2022-01-25T21:45:08Z

/assign @kikisdeliveryservice

sadasu · 2022-01-25T21:48:55Z

/retest

elfosardo · 2022-01-26T09:23:33Z

/retest

sadasu · 2022-01-26T14:03:48Z

/retest

cybertron · 2022-01-26T17:25:04Z

Bah, my local tests of this were failing because I made the change on the wrong connection (br-ex instead of ovs-if-br-ex). This one does the right thing for me locally too.

/lgtm

kikisdeliveryservice · 2022-01-26T18:20:24Z

sounds like this is good to go!

/approve

openshift-ci · 2022-01-26T18:21:03Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cybertron, flavio-fernandes, kikisdeliveryservice, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2022-01-26T18:51:47Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2022-01-26T20:30:08Z

@trozet: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-e2e-aws	`8d3d4cf`	link	false	`/test okd-e2e-aws`
ci/prow/e2e-aws-workers-rhel8	`8d3d4cf`	link	false	`/test e2e-aws-workers-rhel8`
ci/prow/e2e-aws-upgrade-single-node	`8d3d4cf`	link	false	`/test e2e-aws-upgrade-single-node`
ci/prow/e2e-aws-disruptive	`8d3d4cf`	link	false	`/test e2e-aws-disruptive`
ci/prow/e2e-aws-workers-rhel7	`8d3d4cf`	link	false	`/test e2e-aws-workers-rhel7`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci · 2022-01-26T20:32:20Z

@trozet: All pull requests linked via external trackers have merged:

Bugzilla bug 2040671 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2040671: Configure-ovs: Ensure DHCP finishes for both address families

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 24, 2022

openshift-ci bot requested review from jkyros and mkenigs January 24, 2022 23:09

trozet force-pushed the ipv6-may-fail branch from 797c2d7 to 5173dab Compare January 25, 2022 14:15

Configure-ovs: Ensure DHCP finishes for both address families

8d3d4cf

When activating the br-ex connection, NM would return success if only one of the address families got an IP. We should wait for both families in the case of dualstack. Signed-off-by: Tim Rozet <[email protected]>

trozet force-pushed the ipv6-may-fail branch from 5173dab to 8d3d4cf Compare January 25, 2022 16:56

trozet changed the title ~~[WIP] Configure-ovs: Ensure DHCP finishes for both address families~~ Bug 2040671: Configure-ovs: Ensure DHCP finishes for both address families Jan 25, 2022

flavio-fernandes reviewed Jan 25, 2022

View reviewed changes

openshift-ci bot assigned flavio-fernandes Jan 25, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2022

openshift-ci bot assigned kikisdeliveryservice Jan 25, 2022

This was referenced Jan 25, 2022

configure-ovs: Add extra delay #2924

Closed

Bug 2040671: configure-ovs: restart NetworkManager-wait-online #2927

Closed

openshift-ci bot assigned cybertron Jan 26, 2022

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2022

openshift-merge-robot merged commit 3f93fa2 into openshift:master Jan 26, 2022

Bug 2040671: Configure-ovs: Ensure DHCP finishes for both address families #2929

Bug 2040671: Configure-ovs: Ensure DHCP finishes for both address families #2929

Uh oh!

Conversation

trozet commented Jan 24, 2022

Uh oh!

trozet commented Jan 24, 2022

Uh oh!

trozet commented Jan 25, 2022

Uh oh!

trozet commented Jan 25, 2022

Uh oh!

openshift-ci bot commented Jan 25, 2022

Uh oh!

trozet commented Jan 25, 2022

Uh oh!

openshift-ci bot commented Jan 25, 2022

Uh oh!

flavio-fernandes left a comment

Choose a reason for hiding this comment

Uh oh!

trozet commented Jan 25, 2022

Uh oh!

sadasu commented Jan 25, 2022

Uh oh!

elfosardo commented Jan 26, 2022

Uh oh!

sadasu commented Jan 26, 2022

Uh oh!

cybertron commented Jan 26, 2022

Uh oh!

kikisdeliveryservice commented Jan 26, 2022

Uh oh!

openshift-ci bot commented Jan 26, 2022

Uh oh!

openshift-bot commented Jan 26, 2022

Uh oh!

openshift-ci bot commented Jan 26, 2022

Uh oh!

openshift-ci bot commented Jan 26, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants