Skip to content

configure-ovs: improvements & reset openvswitch configuration on every boot #2864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Dec 16, 2021
Merged

configure-ovs: improvements & reset openvswitch configuration on every boot #2864

openshift-merge-robot merged 2 commits into from
Dec 16, 2021

Conversation

@jcaamano
Copy link
Contributor

@jcaamano jcaamano commented Dec 10, 2021 •
edited
Loading

Improvements for configure-ovs script

  • On error, clean up any configuration to avoid interference. This
    configuration will be saved on a temporary directory for
    troubleshooting.
  • Consolidated logic to rollback any applied configuration, to activate
    a connection profile, reload NM, print network state information and
    exit handling.
  • Avoid using nmcli device connect as it will generate a persistent
    connection profile if there wasn't any, ipossibly changing the state
    the node was initially deployed with.
  • Change configure-ovs to rebuild the ovs configuration on every boot.
    This allows to take in new network configuration that administrator
    intends to apply to the cluster on day-2.

Signed-off-by: Jaime Caamaño Ruiz [email protected]

@jcaamano jcaamano force-pushed the ovs-reset-on-boot branch 2 times, most recently from ec013db to c45196d Compare December 11, 2021 02:26
@sinnykumari
Copy link
Contributor

sinnykumari commented Dec 13, 2021

/assign @trozet PTAL

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 13, 2021

@sinnykumari: GitHub didn't allow me to assign the following users: PTAL.

Note that only openshift members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

Details

In response to this:

/assign @trozet PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcaamano jcaamano force-pushed the ovs-reset-on-boot branch 3 times, most recently from a7e4801 to f097b0e Compare December 13, 2021 18:58
trozet
trozet suggested changes Dec 13, 2021
View reviewed changes
@jcaamano jcaamano changed the title Reset OVN-K openvswitch configuration on every boot configure-ovs: improvements & reset openvswitch configuration on every boot Dec 13, 2021
@jcaamano jcaamano force-pushed the ovs-reset-on-boot branch 2 times, most recently from addd92d to d44d021 Compare December 14, 2021 08:52
@jcaamano
Copy link
Contributor Author

jcaamano commented Dec 14, 2021

/retest

@jcaamano
Copy link
Contributor Author

jcaamano commented Dec 14, 2021

/test ?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 14, 2021

@jcaamano: The following commands are available to trigger required jobs:

  • /test cluster-bootimages
  • /test e2e-agnostic-upgrade
  • /test e2e-aws
  • /test e2e-gcp-op
  • /test images
  • /test unit
  • /test verify

The following commands are available to trigger optional jobs:

  • /test bootstrap-unit
  • /test e2e-aws-disruptive
  • /test e2e-aws-proxy
  • /test e2e-aws-serial
  • /test e2e-aws-single-node
  • /test e2e-aws-upgrade
  • /test e2e-aws-upgrade-single-node
  • /test e2e-aws-workers-rhel7
  • /test e2e-aws-workers-rhel8
  • /test e2e-azure
  • /test e2e-azure-upgrade
  • /test e2e-gcp-op-single-node
  • /test e2e-gcp-single-node
  • /test e2e-gcp-upgrade
  • /test e2e-metal-assisted
  • /test e2e-metal-ipi
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-ovn-ipv6
  • /test e2e-openstack
  • /test e2e-openstack-parallel
  • /test e2e-ovirt
  • /test e2e-ovirt-upgrade
  • /test e2e-ovn-step-registry
  • /test e2e-vsphere
  • /test e2e-vsphere-upgrade
  • /test e2e-vsphere-upi
  • /test okd-e2e-aws
  • /test okd-e2e-gcp-op
  • /test okd-e2e-upgrade
  • /test okd-e2e-vsphere
  • /test okd-images

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-machine-config-operator-master-bootstrap-unit
  • pull-ci-openshift-machine-config-operator-master-e2e-agnostic-upgrade
  • pull-ci-openshift-machine-config-operator-master-e2e-aws
  • pull-ci-openshift-machine-config-operator-master-e2e-aws-disruptive
  • pull-ci-openshift-machine-config-operator-master-e2e-aws-serial
  • pull-ci-openshift-machine-config-operator-master-e2e-aws-single-node
  • pull-ci-openshift-machine-config-operator-master-e2e-aws-upgrade-single-node
  • pull-ci-openshift-machine-config-operator-master-e2e-aws-workers-rhel7
  • pull-ci-openshift-machine-config-operator-master-e2e-aws-workers-rhel8
  • pull-ci-openshift-machine-config-operator-master-e2e-gcp-op
  • pull-ci-openshift-machine-config-operator-master-e2e-gcp-op-single-node
  • pull-ci-openshift-machine-config-operator-master-e2e-metal-ipi
  • pull-ci-openshift-machine-config-operator-master-e2e-ovn-step-registry
  • pull-ci-openshift-machine-config-operator-master-e2e-vsphere-upgrade
  • pull-ci-openshift-machine-config-operator-master-images
  • pull-ci-openshift-machine-config-operator-master-okd-e2e-aws
  • pull-ci-openshift-machine-config-operator-master-okd-images
  • pull-ci-openshift-machine-config-operator-master-unit
  • pull-ci-openshift-machine-config-operator-master-verify
Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcaamano
Copy link
Contributor Author

jcaamano commented Dec 14, 2021

/test e2e-metal-ipi-ovn-dualstack
/test e2e-metal-ipi-ovn-ipv6

@jcaamano jcaamano force-pushed the ovs-reset-on-boot branch 3 times, most recently from 7e3520f to ea612ff Compare December 14, 2021 17:12
@jcaamano
Improvements for configure-ovs script
9cc7ac4 
* On error, clean up any configuration to avoid interference. This
  configuration will be saved on a temporary directory for
  troubleshooting.
* Consolidated logic to rollback any applied configuration, to activate
  a connection profile, reload NM, print network state information and
  exit handling.
* Avoid using `nmcli device connect` as it will generate a persistent
  connection profile if there wasn't any, ipossibly changing the state
  the node was initially deployed with.

Signed-off-by: Jaime Caamaño Ruiz <[email protected]>
@jcaamano
Reset OVN-K openvswitch configuration on every boot
9e3e74d 
Signed-off-by: Jaime Caamaño Ruiz <[email protected]>
trozet
trozet approved these changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@trozet trozet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@trozet
Copy link
Contributor

trozet commented Dec 14, 2021

/assign @kikisdeliveryservice

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 14, 2021
@jcaamano
Copy link
Contributor Author

jcaamano commented Dec 14, 2021

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 15, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@jcaamano
Copy link
Contributor Author

jcaamano commented Dec 15, 2021

/retest-required

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 15, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 15, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 15, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 15, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 15, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@jcaamano
Copy link
Contributor Author

jcaamano commented Dec 15, 2021

/retest-required

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 15, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@jcaamano
Copy link
Contributor Author

jcaamano commented Dec 16, 2021

/retest-required

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 16, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 16, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 16, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 16, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 16, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 16, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 16, 2021 •
edited
Loading

@jcaamano: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-upgrade-single-node 9e3e74d link false /test e2e-aws-upgrade-single-node
ci/prow/e2e-metal-ipi-ovn-ipv6 9e3e74d link false /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-aws-disruptive 9e3e74d link false /test e2e-aws-disruptive
ci/prow/e2e-metal-ipi-ovn-dualstack 9e3e74d link false /test e2e-metal-ipi-ovn-dualstack

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 16, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

8 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 16, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 16, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 16, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 16, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 16, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 16, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 16, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 16, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@sinnykumari
Copy link
Contributor

sinnykumari commented Dec 16, 2021

/skip

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 16, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit a451512 into openshift:master Dec 16, 2021
@zaneb zaneb mentioned this pull request Jan 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sinnykumari sinnykumari sinnykumari approved these changes

@cheesesashimi cheesesashimi Awaiting requested review from cheesesashimi

@kikisdeliveryservice kikisdeliveryservice Awaiting requested review from kikisdeliveryservice

+1 more reviewer

@trozet trozet trozet approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kikisdeliveryservice kikisdeliveryservice

@trozet trozet

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jcaamano @sinnykumari @trozet @openshift-bot @kikisdeliveryservice @openshift-merge-robot