Bug 1952358: vSphere platform none vmxnet3v4 fix

[jcpowermac]

This adds templates/common/none directory
with the fix platform: vsphere for vmxnet3 v4.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jcpowermac
To complete the pull request process, please assign yuqi-zhang after the PR has been reviewed.
You can assign the PR to them by writing /assign @yuqi-zhang in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jcpowermac]

I am unsure who the owners should be. Probably not vsphere

[jcpowermac]

/bugzilla refresh

[openshift-ci-robot]

@jcpowermac: This pull request references Bugzilla bug 1952358, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.8.0) matches configured target release for branch (4.8.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @mike-nguyen

Details

In response to this:

Bug 1952358: vSphere platform none vmxnet3v4 fix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@jcpowermac: This pull request references Bugzilla bug 1952358, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.8.0) matches configured target release for branch (4.8.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @mike-nguyen

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jcpowermac]

related
#2472
#2482
#2495

[jcpowermac]

/assign @yuqi-zhang

[jcpowermac]

/assign @cuppett

[yuqi-zhang]

Two quick questions:

1. Aside from metal-on-vsphere, do we know if there are other use cases for none?
2. As an alternative, we could ship this as a base template, and gate on vsphere platform (I guess the script already does, because vmxnet3 should only be used on vsphere right?). It should not affect other platforms and doesn't open the potential can of worms of a "none" platform. Would there be other downsides to this?

[jcpowermac]

Two quick questions:

1. Aside from metal-on-vsphere, do we know if there are other use cases for none?

Any cloud platform that we currently don't support directly and baremetal upi. There could be more and I am forgetting

2. As an alternative, we could ship this as a base template, and gate on vsphere platform (I guess the script already does, because vmxnet3 should only be used on vsphere right?). It should not affect other platforms and doesn't open the potential can of worms of a "none" platform. Would there be other downsides to this?

I think this is up to the MCO team. I just tried out adding the none template directory and it worked. I figured that we are limiting our potential for an issue. If mco feels more comfortable moving it to base I have no problem moving it.

[jcpowermac]

/close

[openshift-ci-robot]

@jcpowermac: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@jcpowermac: This pull request references Bugzilla bug 1952358. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1952358: vSphere platform none vmxnet3v4 fix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.