Bug 1935539: vSphere: Disable tx udp_csum segmentation #2472

jcpowermac · 2021-03-20T00:40:46Z

Based on one of VMware's recommendations disable
both:

tx-udp_tnl-segmentation
tx-udp_tnl-csum-segmentation

This could potentially replace the more generic offload disable.

Based on one of VMware's recommendations disable both: tx-udp_tnl-segmentation tx-udp_tnl-csum-segmentation This could potentially replace the more generic offload disable.

jcpowermac · 2021-03-20T00:41:42Z

This could potentially replace:
#2471
But since its more targetted I would like to test it out before replacing the above.

jcpowermac · 2021-03-20T00:41:53Z

/test e2e-vsphere

wking · 2021-03-20T03:34:47Z

/lgtm

openshift-ci-robot · 2021-03-20T03:34:58Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcpowermac, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~templates/common/vsphere/OWNERS~~ [jcpowermac]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2021-03-20T12:50:55Z

@jcpowermac: This pull request references Bugzilla bug 1935539, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.8.0) matches configured target release for branch (4.8.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @zhaozhanqi

Details

In response to this:

Bug 1935539: vSphere: Disable tx udp_csum segmentation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jcpowermac · 2021-03-20T12:51:13Z

Since vsphere passed and this is more targetted to the issue going forward with this PR.

jcpowermac · 2021-03-20T12:55:59Z

/test e2e-aws
/test e2e-gcp-op

openshift-bot · 2021-03-20T13:02:44Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-03-20T13:15:44Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-03-20T14:20:43Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-03-20T14:33:43Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-03-20T14:59:42Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-03-20T15:12:44Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-03-20T15:38:43Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-03-20T16:04:41Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-03-20T16:56:43Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-03-20T17:09:41Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-03-20T17:35:41Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-03-20T18:27:42Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-03-20T19:06:42Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-03-20T19:19:40Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-03-20T19:32:40Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-03-20T19:45:41Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-03-20T20:24:39Z

/retest

Please review the full test history for this PR and help us cut down flakes.

wking · 2021-03-20T20:37:38Z

e2e-gcp-op keeps hitting the same unrelated panic: test timed out after 1h15m0s. I think we should /override ci/prow/e2e-gcp-op, but we need a root approver for that.

wking · 2021-03-20T21:57:54Z

#2474 will address the timeout panics.

openshift-bot · 2021-03-20T22:21:39Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-03-20T22:34:38Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-03-20T23:52:39Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-03-21T00:20:28Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-03-21T00:31:39Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-03-21T01:11:15Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-03-21T01:13:01Z

@jcpowermac: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-workers-rhel7	`be3cb87`	link	`/test e2e-aws-workers-rhel7`
ci/prow/okd-e2e-aws	`be3cb87`	link	`/test okd-e2e-aws`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2021-03-21T01:23:39Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2021-03-21T02:21:59Z

@jcpowermac: All pull requests linked via external trackers have merged:

openshift/machine-config-operator#2472

Bugzilla bug 1935539 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1935539: vSphere: Disable tx udp_csum segmentation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wking · 2021-03-21T03:27:54Z

/cherrypick release-4.7

openshift-cherrypick-robot · 2021-03-21T03:28:32Z

@wking: new pull request created: #2475

Details

In response to this:

/cherrypick release-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

abhat · 2021-03-22T13:28:01Z

@jcpowermac what is the performance impact of this? We are essentially disabling offload of tx inner packet checksumming and segmentation of larger packets for vxlan. We need some quantification of the impact perhaps?

cc @wking, @trozet, @danwinship.

jcpowermac · 2021-03-22T13:29:45Z

@jcpowermac what is the performance impact of this? We are essentially disabling offload of tx inner packet checksumming and segmentation of larger packets for vxlan. We need some quantification of the impact perhaps?

cc @wking, @trozet, @danwinship.

It wasn't enabled in 4.6 because the driver wasn't updated until 4.7/RHEL 8.3. So there wouldn't be a performance impact since it was never on before.

vSphere: Disable tx udp_csum segmentation

be3cb87

Based on one of VMware's recommendations disable both: tx-udp_tnl-segmentation tx-udp_tnl-csum-segmentation This could potentially replace the more generic offload disable.

jcpowermac changed the title ~~vSphere: Disable tx udp_csum segmentation~~ [wip] vSphere: Disable tx udp_csum segmentation Mar 20, 2021

openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 20, 2021

openshift-ci-robot requested review from kikisdeliveryservice and patrickdillon March 20, 2021 00:41

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2021

openshift-ci-robot assigned wking Mar 20, 2021

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2021

jcpowermac changed the title ~~[wip] vSphere: Disable tx udp_csum segmentation~~ Bug 1935539: vSphere: Disable tx udp_csum segmentation Mar 20, 2021

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 20, 2021

openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Mar 20, 2021

openshift-ci-robot requested a review from zhaozhanqi March 20, 2021 12:50

jcpowermac mentioned this pull request Mar 20, 2021

Bug 1935539: vSphere: Disable tx checksum offload #2471

Closed

openshift-merge-robot merged commit 46d63d9 into openshift:master Mar 21, 2021

openshift-cherrypick-robot mentioned this pull request Mar 21, 2021

Bug 1941246: vSphere: Disable tx udp_csum segmentation #2475

Closed

openshift-ci-robot mentioned this pull request Mar 26, 2021

Bug 1935539: vSphere: udp tnl workaround cannot use nmcli #2482

Merged

jomeier mentioned this pull request Apr 12, 2021

Router connectivity issue with OpenShiftSDN in 4.6 okd-project/okd#430

Closed

jcpowermac mentioned this pull request Apr 30, 2021

Bug 1952358: vSphere platform none vmxnet3v4 fix #2558

Closed

Bug 1935539: vSphere: Disable tx udp_csum segmentation #2472

Bug 1935539: vSphere: Disable tx udp_csum segmentation #2472

Uh oh!

Conversation

jcpowermac commented Mar 20, 2021

Uh oh!

jcpowermac commented Mar 20, 2021

Uh oh!

jcpowermac commented Mar 20, 2021

Uh oh!

wking commented Mar 20, 2021

Uh oh!

openshift-ci-robot commented Mar 20, 2021

Uh oh!

openshift-ci-robot commented Mar 20, 2021

Uh oh!

jcpowermac commented Mar 20, 2021

Uh oh!

jcpowermac commented Mar 20, 2021

Uh oh!

openshift-bot commented Mar 20, 2021

Uh oh!

openshift-bot commented Mar 20, 2021

Uh oh!

openshift-bot commented Mar 20, 2021

Uh oh!

openshift-bot commented Mar 20, 2021

Uh oh!

openshift-bot commented Mar 20, 2021

Uh oh!

openshift-bot commented Mar 20, 2021

Uh oh!

openshift-bot commented Mar 20, 2021

Uh oh!

openshift-bot commented Mar 20, 2021

Uh oh!

openshift-bot commented Mar 20, 2021

Uh oh!

openshift-bot commented Mar 20, 2021

Uh oh!

openshift-bot commented Mar 20, 2021

Uh oh!

openshift-bot commented Mar 20, 2021

Uh oh!

openshift-bot commented Mar 20, 2021

Uh oh!

openshift-bot commented Mar 20, 2021

Uh oh!

openshift-bot commented Mar 20, 2021

Uh oh!

openshift-bot commented Mar 20, 2021

Uh oh!

openshift-bot commented Mar 20, 2021

Uh oh!

wking commented Mar 20, 2021

Uh oh!

wking commented Mar 20, 2021

Uh oh!

openshift-bot commented Mar 20, 2021

Uh oh!

openshift-bot commented Mar 20, 2021

Uh oh!

openshift-bot commented Mar 20, 2021

Uh oh!

openshift-bot commented Mar 21, 2021

Uh oh!

openshift-bot commented Mar 21, 2021

Uh oh!

openshift-bot commented Mar 21, 2021

Uh oh!

openshift-ci bot commented Mar 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-bot commented Mar 21, 2021

Uh oh!

openshift-ci-robot commented Mar 21, 2021

Uh oh!

wking commented Mar 21, 2021

Uh oh!

openshift-cherrypick-robot commented Mar 21, 2021

openshift-ci bot commented Mar 21, 2021 •

edited

Loading