Skip to content

templates: change additional kubelet service files with new log-level #2261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sjenning wants to merge 1 commit into from
Closed

templates: change additional kubelet service files with new log-level #2261

sjenning wants to merge 1 commit into from

Conversation

@sjenning
Copy link
Contributor

@sjenning sjenning commented Nov 30, 2020 •
edited
Loading

@rphillips

#2211 did not change the log level for all platforms

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2020
rphillips
rphillips reviewed Nov 30, 2020
View reviewed changes
templates/master/01-master-kubelet/baremetal/units/kubelet.service.yaml Outdated
Copy link
Contributor

@rphillips rphillips Nov 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding a baremetal config?

@rphillips
Copy link
Contributor

rphillips commented Nov 30, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2020
@cgwalters
Copy link
Member

cgwalters commented Nov 30, 2020

Ah yep, we still really need to de-dup the templates. Probably handle these explicitly in the code.

@cgwalters
Copy link
Member

cgwalters commented Nov 30, 2020

/approve

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 30, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, rphillips, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

darkmuggle
darkmuggle reviewed Nov 30, 2020
View reviewed changes
templates/master/01-master-kubelet/on-prem/units/kubelet.service.yaml
ExecStartPre=/bin/mkdir --parents /etc/kubernetes/manifests
ExecStartPre=/bin/rm -f /var/lib/kubelet/cpu_manager_state
Environment="KUBELET_LOG_LEVEL=4"
Environment="KUBELET_LOG_LEVEL=3"
Copy link

@darkmuggle darkmuggle Nov 30, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honest question: why not move this its own override to /etc/systemd/system/kubelet.service.d/kubelog.conf with

[Unit]
Environment="KUBELET_LOG_LEVEL=3"

That would set the log level in one stop.

@sjenning
Copy link
Contributor Author

sjenning commented Nov 30, 2020

/hold
might do what Ben suggests instead. @rphillips can you do that?

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 30, 2020
@rphillips
Copy link
Contributor

rphillips commented Nov 30, 2020

yep... on it

@rphillips rphillips mentioned this pull request Nov 30, 2020
Merged
@sjenning
Copy link
Contributor Author

sjenning commented Nov 30, 2020

close in favor of #2262

@sjenning sjenning closed this Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp

2 more reviewers

@rphillips rphillips rphillips left review comments

@darkmuggle darkmuggle darkmuggle left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@rphillips rphillips

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sjenning @rphillips @cgwalters @openshift-ci-robot @darkmuggle