-
Notifications
You must be signed in to change notification settings - Fork 462
Bug 1895385: Drop kubelet logging back down to level 3 #2211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1895385: Drop kubelet logging back down to level 3 #2211
Conversation
KUBELET_LOG_LEVEL was bumped to level 4 to aid in debugging some issue by node team (see openshift#1672). However customers upgrading to 4.5 in prod, are seeing this bump causing extra GBs of data to be saved. Closes: BZ 1895385
|
@kikisdeliveryservice: This pull request references Bugzilla bug 1895385, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Also some question if 3 is too high? Or is 3 the necessary level for proper debugging of kubelet? |
|
From a large production cluster point of view, 3 is still too high for everyday running in production. OCP 3.x ran at log level 2. Scott Worthington did some sampling on the issue on 4.5.17 in a 3 masters / 9 workers node cluster: There is also a big different in the level of detail / verbosity of each log line at level 4 versus level 2 which has additional storage implications. |
I'm comfortable dropping down to 3 as that was the previous default in OCP 4.x. We can see if 2 makes sense to node team as we do need sufficient logging for troubleshooting clusters and dropping down to 2 may make it harder from a support perspective. Overall, I'd rather just drop down to 3 now to fix the BZ and let node decide later after gathering info if they want to drop down to 2. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kikisdeliveryservice, rphillips The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/skip |
|
/cherry-pick release-4.6 |
|
@kikisdeliveryservice: once the present PR merges, I will cherry-pick it on top of release-4.6 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@kikisdeliveryservice: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@kikisdeliveryservice: All pull requests linked via external trackers have merged: Bugzilla bug 1895385 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@kikisdeliveryservice: new pull request created: #2213 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
KUBELET_LOG_LEVEL was bumped to level 4 to aid in
debugging some issue by node team (see #1672).
However customers upgrading to 4.5 in prod, are seeing this bump
causing extra GBs of data to be saved.
Closes: BZ 1895385