Skip to content

mcs: Log User-Agent #1705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jun 4, 2020
Merged

mcs: Log User-Agent #1705

openshift-merge-robot merged 1 commit into from
Jun 4, 2020

Conversation

@cgwalters
Copy link
Member

@cgwalters cgwalters commented Apr 30, 2020

It's super useful to see the bootimage version for debugging
things like https://bugzilla.redhat.com/show_bug.cgi?id=1829642
AKA
#1215 (comment)

@cgwalters
mcs: Log User-Agent
c756a56 
It's super useful to see the bootimage version for debugging
things like https://bugzilla.redhat.com/show_bug.cgi?id=1829642
AKA
openshift#1215 (comment)
@cgwalters
Copy link
Member Author

cgwalters commented Apr 30, 2020

(I didn't test this locally but if it works we'll see it in the CI logs)

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2020
@kikisdeliveryservice
Copy link
Contributor

kikisdeliveryservice commented Apr 30, 2020

Do you want this in asap? or is later ok?

@cgwalters
Copy link
Member Author

cgwalters commented Apr 30, 2020

Oh it can wait, no urgency, I just think it'll come in handy later.

Seems to work from the logs:

I0430 20:42:02.937780       1 api.go:103] Pool worker requested by address:"10.0.146.31:6312" User-Agent:"Ignition/0.35.0"

@kikisdeliveryservice
Copy link
Contributor

kikisdeliveryservice commented Apr 30, 2020

/test e2e-aws

@sinnykumari
Copy link
Contributor

sinnykumari commented May 4, 2020 •
edited
Loading

From the MCS log, it says:

I0430 20:43:24.258823       1 api.go:103] Pool worker requested by address:"10.0.32.3:35348" User-Agent:"Ignition/0.35.0"

Does User-Agent has what we wanted to know about bootimage version?
 damm, somehow missed the last message

@cgwalters
Copy link
Member Author

cgwalters commented May 4, 2020

Does User-Agent has what we wanted to know about bootimage version?

It helps a bit, e.g. RHCOS 4.1 has Ignition 0.31. I don't see us relying on this - it's just an extra bit of information we can gather.

@sinnykumari
Copy link
Contributor

sinnykumari commented May 4, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 4, 2020
@openshift-bot
Copy link
Contributor

openshift-bot commented May 4, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented May 4, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented May 4, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented May 4, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented May 4, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented May 4, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@runcom runcom removed the lgtm Indicates that a PR is ready to be merged. label May 8, 2020
@runcom
Copy link
Member

runcom commented May 8, 2020 •
edited
Loading

Nice:

I0430 20:43:24.258823       1 api.go:103] Pool worker requested by address:"10.0.32.3:35348" User-Agent:"Ignition/0.35.0"

Looks like what we'd need for v2->v3 as well 👍0.{2|3}.z is spec 2 whether 2.y.z is gonna be what we'll see when someone requests spec 3

@ashcrow ashcrow mentioned this pull request May 18, 2020
Merged
@kikisdeliveryservice
Copy link
Contributor

kikisdeliveryservice commented Jun 3, 2020

since @runcom removed lgtm will defer to him to readd it once he re-reviews

/assign @runcom

@kikisdeliveryservice
Copy link
Contributor

kikisdeliveryservice commented Jun 3, 2020

not sure what he wants to do as i dont see any changes since the LGTM was removed so... ill let him remove this and verify it's ok with him.

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 3, 2020
@LorbusChris LorbusChris mentioned this pull request Jun 3, 2020
Closed
@runcom
Copy link
Member

runcom commented Jun 4, 2020

/hold cancel
/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jun 4, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 4, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, runcom, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [cgwalters,runcom,sinnykumari]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 4, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 8ddf77f into openshift:master Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericavonb ericavonb Awaiting requested review from ericavonb

@kikisdeliveryservice kikisdeliveryservice Awaiting requested review from kikisdeliveryservice

Assignees

@runcom runcom

@sinnykumari sinnykumari

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@cgwalters @kikisdeliveryservice @sinnykumari @openshift-bot @runcom @openshift-ci-robot @openshift-merge-robot