Skip to content

DNM: Migrate internals to Ignition spec v3.1 #1778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
LorbusChris wants to merge 1 commit into from
Closed

DNM: Migrate internals to Ignition spec v3.1 #1778

LorbusChris wants to merge 1 commit into from

Conversation

@LorbusChris
Copy link
Contributor

@LorbusChris LorbusChris commented Jun 3, 2020 •
edited
Loading

This migrates all internal on-disk state representation over to
Ignition config spec v3.1.

Compatibilty with older boot images is retained:
In the MCS, the User Agent on the request is inspected so it can
respond with a supported version, translated in needed.

Contains all 3 commits from #1703.

Will be superseded by #1873

@LorbusChris LorbusChris marked this pull request as draft June 4, 2020 14:23
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 4, 2020
@LorbusChris LorbusChris mentioned this pull request Jun 5, 2020
Merged
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 7, 2020
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 24, 2020
@LorbusChris LorbusChris force-pushed the switch-to-ign-3-1 branch 2 times, most recently from cebad41 to 1a52c9b Compare June 25, 2020 16:25
@LorbusChris LorbusChris mentioned this pull request Jun 25, 2020
Merged
@LorbusChris LorbusChris marked this pull request as ready for review June 25, 2020 16:54
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 25, 2020
@LorbusChris
Copy link
Contributor Author

LorbusChris commented Jun 25, 2020

/cc @yuqi-zhang @runcom @ashcrow
/hold

@yuqi-zhang
Copy link
Contributor

yuqi-zhang commented Jun 25, 2020

I'm working on the last bit for this, there is a bunch of de-duplication and extra translating/error handling that would be needed.

@yuqi-zhang
Copy link
Contributor

yuqi-zhang commented Jun 25, 2020

So this is a first pass WIP PR: #1873 that handles the upgrade path as well. (The rendering is roughly the same as what's in this PR, I started working on it without realizing this one existed)

@LorbusChris LorbusChris force-pushed the switch-to-ign-3-1 branch 7 times, most recently from a0326c4 to 06a32d7 Compare June 28, 2020 05:20
@LorbusChris
Copy link
Contributor Author

LorbusChris commented Jun 28, 2020

/retest

1 similar comment
@LorbusChris
Copy link
Contributor Author

LorbusChris commented Jun 28, 2020

/retest

@LorbusChris LorbusChris force-pushed the switch-to-ign-3-1 branch 2 times, most recently from eaa8026 to 5e96c24 Compare June 29, 2020 18:25
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 29, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: LorbusChris
To complete the pull request process, please assign kikisdeliveryservice
You can assign the PR to them by writing /assign @kikisdeliveryservice in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@LorbusChris LorbusChris changed the title Migrate internals to Ignition spec v3.1 DNM: Migrate internals to Ignition spec v3.1 Jun 30, 2020
@LorbusChris LorbusChris mentioned this pull request Jun 30, 2020
Merged
@LorbusChris
Copy link
Contributor Author

LorbusChris commented Jun 30, 2020

This PR will be superseded by #1873.
Leaving it open for now as reference. Deduplication of units/files is still missing here to enable upgrades, and there still seems to be an error in TestIgn3Cfg here after the migration.

@LorbusChris LorbusChris force-pushed the switch-to-ign-3-1 branch 4 times, most recently from afc2689 to 61aea41 Compare July 1, 2020 18:28
@LorbusChris
Copy link
Contributor Author

LorbusChris commented Jul 1, 2020

/retest

@LorbusChris
Copy link
Contributor Author

LorbusChris commented Jul 1, 2020

/test e2e-gcp-upgrade

@LorbusChris
Copy link
Contributor Author

LorbusChris commented Jul 2, 2020

/retest

@LorbusChris
*: Use Ignition spec v3.1 internally
f8b4f4f 
This migrates all internal on-disk state representation over to
Ignition config spec v3.1.

Compatibilty with older boot images is retained:
In the MCS, the User Agent on the request is inspected so it can
respond with a supported version, translated if needed.
@LorbusChris
Copy link
Contributor Author

LorbusChris commented Jul 6, 2020

/retest

1 similar comment
@LorbusChris
Copy link
Contributor Author

LorbusChris commented Jul 6, 2020

/retest

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 6, 2020

@LorbusChris: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 f8b4f4f link /test e2e-aws-scaleup-rhel7
ci/prow/e2e-ovn-step-registry f8b4f4f link /test e2e-ovn-step-registry
ci/prow/e2e-metal-ipi f8b4f4f link /test e2e-metal-ipi

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@LorbusChris
Copy link
Contributor Author

LorbusChris commented Jul 9, 2020

#1873 is on the finishing straight 🎉
/close

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 9, 2020

@LorbusChris: Closed this PR.

Details

In response to this:

#1873 is on the finishing straight 🎉
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yuqi-zhang
Copy link
Contributor

yuqi-zhang commented Jul 9, 2020

This PR was a great reference, thanks! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adduarte adduarte Awaiting requested review from adduarte

@Fedosin Fedosin Awaiting requested review from Fedosin

@ashcrow ashcrow Awaiting requested review from ashcrow

@runcom runcom Awaiting requested review from runcom

@yuqi-zhang yuqi-zhang Awaiting requested review from yuqi-zhang

Assignees

No one assigned

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LorbusChris @yuqi-zhang @openshift-ci-robot