[release-4.4] Bug 1821799: OpenStack: disable tx checksum offload for workers #1627

openshift-cherrypick-robot · 2020-04-07T18:08:20Z

This is an automated cherry-pick of #1620

/assign mandre

This patch adds the workaround suggested on [1] to make nodeport work, instead of ethtool we use NM to apply the fix for each connction before it is up. [1] https://bugzilla.redhat.com/show_bug.cgi?id=1794714 Brings the following ovirt fixes to openstack platform: - openshift#1606 - openshift#1621

openshift-ci-robot · 2020-04-07T18:08:22Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1821798, which is invalid:

expected the bug to target the "4.4.0" release, but it targets "4.5.0" instead
expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead
expected Bugzilla bug 1821798 to depend on a bug targeting the "4.5.0" release and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.4] Bug 1821798: OpenStack: disable tx checksum offload for workers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mandre · 2020-04-07T18:09:09Z

/retitle [release-4.4] Bug 1821799: OpenStack: disable tx checksum offload for workers

openshift-ci-robot · 2020-04-07T18:09:35Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1821799, which is invalid:

expected dependent Bugzilla bug 1821798 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.4] Bug 1821799: OpenStack: disable tx checksum offload for workers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sinnykumari · 2020-04-08T06:48:57Z

/retest

mandre · 2020-04-08T07:36:23Z

/test e2e-openstack

mandre · 2020-04-08T08:43:49Z

/test e2e-openstack

mandre · 2020-04-08T13:58:23Z

/bugzilla refresh

openshift-ci-robot · 2020-04-08T13:58:31Z

@mandre: This pull request references Bugzilla bug 1821799, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.4.0) matches configured target release for branch (4.4.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1821798 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1821798 targets the "4.5.0" release, matching the expected (4.5.0) release
bug has dependents

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pierreprinetti · 2020-04-08T15:14:29Z

/approve
/lgtm
/label platform/openstack

openshift-ci-robot · 2020-04-08T15:14:30Z

@pierreprinetti: The label(s) platform/openstack cannot be applied, because the repository doesn't have them

Details

In response to this:

/approve
/lgtm
/label platform/openstack

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pierreprinetti · 2020-04-08T15:15:27Z

/approve
/lgtm

mandre · 2020-04-08T15:19:40Z

Hmm @pierreprinetti should be able to approve this PR.

/approve

openshift-ci-robot · 2020-04-08T15:23:10Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre, openshift-cherrypick-robot, pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~templates/worker/00-worker/openstack/OWNERS~~ [mandre]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

pierreprinetti · 2020-04-08T15:23:29Z

It was just some latency apparently!

openshift-bot · 2020-04-08T15:32:56Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-08T15:59:01Z

/retest

Please review the full test history for this PR and help us cut down flakes.

sdodson · 2020-04-08T16:54:47Z

Why are we only doing this for workers? In compact clusters (no workers) masters would also need this, no?

openshift-bot · 2020-04-08T18:08:52Z

/retest

Please review the full test history for this PR and help us cut down flakes.

mandre · 2020-04-08T19:42:59Z

Why are we only doing this for workers? In compact clusters (no workers) masters would also need this, no?

Good point. This should indeed probably be added to both workers and masters. I'll bring this to ovirt team who implemented the same workaround for their platform.
Anyway, since this is a backport, shouldn't we go ahead with the patch and cascade a new fix from master for the requested change?

sdodson · 2020-04-08T20:14:02Z

Anyway, since this is a backport, shouldn't we go ahead with the patch and cascade a new fix from master for the requested change?

yeah, that's fine.

openshift-bot · 2020-04-09T01:56:48Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-09T02:35:47Z

/retest

Please review the full test history for this PR and help us cut down flakes.

sinnykumari · 2020-04-09T05:24:48Z

/retest

openshift-bot · 2020-04-09T05:50:46Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-09T07:34:47Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-09T08:26:46Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-09T09:18:46Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-09T10:36:48Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-09T11:28:53Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-09T12:07:46Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-09T14:04:46Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-09T14:17:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-04-09T16:31:11Z

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-scaleup-rhel7	`24afb37`	link	`/test e2e-aws-scaleup-rhel7`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ashcrow · 2020-04-09T18:02:32Z

/retest

openshift-ci-robot · 2020-04-09T19:24:17Z

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: openshift/machine-config-operator#1627. Bugzilla bug 1821799 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.4] Bug 1821799: OpenStack: disable tx checksum offload for workers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot assigned mandre Apr 7, 2020

openshift-cherrypick-robot mentioned this pull request Apr 7, 2020

Bug 1821798: OpenStack: disable tx checksum offload for workers #1620

Merged

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 7, 2020

openshift-ci-robot changed the title ~~[release-4.4] Bug 1821798: OpenStack: disable tx checksum offload for workers~~ [release-4.4] Bug 1821799: OpenStack: disable tx checksum offload for workers Apr 7, 2020

openshift-ci-robot requested review from mandre and russellb April 7, 2020 18:09

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 8, 2020

openshift-ci-robot assigned pierreprinetti Apr 8, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2020

sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 8, 2020

openshift-merge-robot merged commit aea5863 into openshift:release-4.4 Apr 9, 2020

[release-4.4] Bug 1821799: OpenStack: disable tx checksum offload for workers #1627

[release-4.4] Bug 1821799: OpenStack: disable tx checksum offload for workers #1627

Uh oh!

Conversation

openshift-cherrypick-robot commented Apr 7, 2020

Uh oh!

openshift-ci-robot commented Apr 7, 2020

Uh oh!

mandre commented Apr 7, 2020

Uh oh!

openshift-ci-robot commented Apr 7, 2020

Uh oh!

sinnykumari commented Apr 8, 2020

Uh oh!

mandre commented Apr 8, 2020

Uh oh!

mandre commented Apr 8, 2020

Uh oh!

mandre commented Apr 8, 2020

Uh oh!

openshift-ci-robot commented Apr 8, 2020

Uh oh!

pierreprinetti commented Apr 8, 2020

Uh oh!

openshift-ci-robot commented Apr 8, 2020

Uh oh!

pierreprinetti commented Apr 8, 2020

Uh oh!

mandre commented Apr 8, 2020

Uh oh!

openshift-ci-robot commented Apr 8, 2020

Uh oh!

pierreprinetti commented Apr 8, 2020

Uh oh!

openshift-bot commented Apr 8, 2020

Uh oh!

openshift-bot commented Apr 8, 2020

Uh oh!

sdodson commented Apr 8, 2020

Uh oh!

openshift-bot commented Apr 8, 2020

Uh oh!

mandre commented Apr 8, 2020

Uh oh!

sdodson commented Apr 8, 2020

Uh oh!

openshift-bot commented Apr 9, 2020

Uh oh!

openshift-bot commented Apr 9, 2020

Uh oh!

sinnykumari commented Apr 9, 2020

Uh oh!

openshift-bot commented Apr 9, 2020

Uh oh!

openshift-bot commented Apr 9, 2020

Uh oh!

openshift-bot commented Apr 9, 2020

Uh oh!

openshift-bot commented Apr 9, 2020

Uh oh!

openshift-bot commented Apr 9, 2020

Uh oh!

openshift-bot commented Apr 9, 2020

Uh oh!

openshift-bot commented Apr 9, 2020

Uh oh!

openshift-bot commented Apr 9, 2020

Uh oh!

openshift-bot commented Apr 9, 2020

Uh oh!

openshift-ci-robot commented Apr 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ashcrow commented Apr 9, 2020

Uh oh!

openshift-ci-robot commented Apr 9, 2020

Uh oh!

Reviewers

Assignees

Labels

openshift-ci-robot commented Apr 9, 2020 •

edited

Loading