ovirt: disable tx checksum offload for workers #1606

Gal-Zaidman · 2020-04-01T18:42:36Z

This patch adds the workaround suggested on [1]
to make nodeport work, instead of ethtool we use
NM to apply the fix for each connction before it is up.

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1794714

Signed-off-by: Gal Zaidman [email protected]

- What I did

- How to verify it

- Description for the changelog

Gal-Zaidman · 2020-04-01T19:59:21Z

/retest

Gal-Zaidman · 2020-04-01T20:00:37Z

/cc rgolangh

Gal-Zaidman · 2020-04-01T20:01:07Z

/cc dcbw

templates/worker/00-worker/ovirt/files/ovirt-disable-tx-checksum-offload.yaml

rgolangh · 2020-04-02T07:55:49Z

also, use /test e2e-ovirt when you think its ready

Gal-Zaidman · 2020-04-02T08:25:26Z

/test e2e-ovirt

Gal-Zaidman · 2020-04-02T09:36:51Z

/test e2e-ovirt

cgwalters · 2020-04-02T12:11:24Z

So this is an openshift-sdn bug that only seems to manifest on oVirt, is that right? What's the timeframe for the SDN fix landing (or rephrased, when can we remove this and how do we track things to ensure it's removed?)

rgolangh · 2020-04-02T12:27:55Z

I suggest to open a bug which depends on 1794714, for the removal of this machine-config item.

Gal-Zaidman · 2020-04-02T12:42:56Z

So this is an openshift-sdn bug that only seems to manifest on oVirt, is that right?

On ovirt all other platforms according to comment#8

What's the timeframe for the SDN fix landing (or rephrased, when can we remove this and how do we track things to ensure it's removed?)

Don't know what is the timeframe but as you can see it is currently handled by RHEL and on high priority

This patch adds the workaround suggested on [1] to make nodeport work, instead of ethtool we use NM to apply the fix for each connction before it is up. [1] https://bugzilla.redhat.com/show_bug.cgi?id=1794714 Signed-off-by: Gal Zaidman <[email protected]>

Gal-Zaidman · 2020-04-02T16:36:13Z

/test e2e-ovirt

Gal-Zaidman · 2020-04-02T17:53:25Z

I suggest to open a bug which depends on 1794714, for the removal of this machine-config item.

created:

rgolangh · 2020-04-03T13:55:16Z

/lgtm

Gal-Zaidman · 2020-04-04T16:14:15Z

/assign @ericavonb

cgwalters · 2020-04-04T16:58:31Z

/approve
because there's a promise/mechanism to ensure this workaround is dropped when it's not necessary anymore.

openshift-bot · 2020-04-04T17:12:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

runcom · 2020-04-04T17:21:48Z

/approve

openshift-ci-robot · 2020-04-04T17:22:17Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, Gal-Zaidman, rgolangh, runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [cgwalters,runcom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2020-04-04T19:18:22Z

@Gal-Zaidman: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-scaleup-rhel7	`2226748`	link	`/test e2e-aws-scaleup-rhel7`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2020-04-04T19:23:00Z

/retest

Please review the full test history for this PR and help us cut down flakes.

rgolangh · 2020-04-05T07:16:53Z

/cherry-pick release-4.4

openshift-cherrypick-robot · 2020-04-05T07:17:04Z

@rgolangh: new pull request created: #1617

Details

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mandre · 2020-04-06T15:22:42Z

We're likely going to do the same for OpenStack.

On PR [1] we added a workaround for Bug [2], this fails when the worker starts for the first time since openshift-sdn is created only when the sdn pod is starting. Instead we will disable by default leave as is only when running with OVNkubernetes [1] On PR openshift#1606, [2] https://bugzilla.redhat.com/show_bug.cgi?id=1794714 Signed-off-by: Gal Zaidman <[email protected]>

This patch adds the workaround suggested on [1] to make nodeport work, instead of ethtool we use NM to apply the fix for each connction before it is up. [1] https://bugzilla.redhat.com/show_bug.cgi?id=1794714 Brings the following ovirt fixes to openstack platform: - openshift#1606 - openshift#1621

kikisdeliveryservice · 2020-04-07T20:51:09Z

Related: https://bugzilla.redhat.com/show_bug.cgi?id=1821005

On PR [1] we added a workaround for Bug [2], this fails when the worker starts for the first time since openshift-sdn is created only when the sdn pod is starting. Instead we will disable by default leave as is only when running with OVNkubernetes [1] On PR openshift#1606, [2] https://bugzilla.redhat.com/show_bug.cgi?id=1794714 Signed-off-by: Gal Zaidman <[email protected]>

This patch adds the workaround suggested on [1] to make nodeport work, instead of ethtool we use NM to apply the fix for each connction before it is up. [1] https://bugzilla.redhat.com/show_bug.cgi?id=1794714 Brings the following ovirt fixes to openstack platform: - openshift#1606 - openshift#1621

openshift-ci-robot requested review from cgwalters and sinnykumari April 1, 2020 18:43

openshift-ci-robot requested a review from rgolangh April 1, 2020 20:00

openshift-ci-robot requested a review from dcbw April 1, 2020 20:01

Gal-Zaidman commented Apr 1, 2020

View reviewed changes

templates/worker/00-worker/ovirt/files/ovirt-disable-tx-checksum-offload.yaml Outdated Show resolved Hide resolved

kikisdeliveryservice assigned rgolangh Apr 2, 2020

rgolangh reviewed Apr 2, 2020

View reviewed changes

templates/worker/00-worker/ovirt/files/ovirt-disable-tx-checksum-offload.yaml Outdated Show resolved Hide resolved

templates/worker/00-worker/ovirt/files/ovirt-disable-tx-checksum-offload.yaml Outdated Show resolved Hide resolved

Gal-Zaidman force-pushed the diasable-checksum branch from 82e5237 to 58f058b Compare April 2, 2020 08:22

Gal-Zaidman force-pushed the diasable-checksum branch from 58f058b to 2226748 Compare April 2, 2020 16:34

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2020

openshift-ci-robot assigned ericavonb Apr 4, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2020

openshift-merge-robot merged commit 48cb244 into openshift:master Apr 4, 2020

openshift-cherrypick-robot mentioned this pull request Apr 5, 2020

[release-4.4] Bug 1820975: ovirt: disable tx checksum offload for workers #1617

Closed

mandre mentioned this pull request Apr 6, 2020

Bug 1821798: OpenStack: disable tx checksum offload for workers #1620

Merged

Gal-Zaidman mentioned this pull request Apr 6, 2020

Bug 1821005: oVirt, fix disable tx checksum offload for workers #1621

Merged

kikisdeliveryservice mentioned this pull request Apr 7, 2020

Bug 1820975: oVirt, fix disable tx checksum offload for workers #1628

Merged

Gal-Zaidman mentioned this pull request Apr 15, 2020

ovirt e2e: fix nodeport issue on CI bug 1794714 openshift/release#7614

Closed

openshift-ci-robot mentioned this pull request Sep 8, 2020

Bug 1820305: remove disable checksum workaround for workers #2063

Merged

wking mentioned this pull request Mar 19, 2021

Bug 1935539: vSphere: Disable tx checksum offload #2471

Closed

ovirt: disable tx checksum offload for workers #1606

ovirt: disable tx checksum offload for workers #1606

Uh oh!

Conversation

Gal-Zaidman commented Apr 1, 2020

Uh oh!

Gal-Zaidman commented Apr 1, 2020

Uh oh!

Gal-Zaidman commented Apr 1, 2020

Uh oh!

Gal-Zaidman commented Apr 1, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rgolangh commented Apr 2, 2020

Uh oh!

Gal-Zaidman commented Apr 2, 2020

Uh oh!

Gal-Zaidman commented Apr 2, 2020

Uh oh!

cgwalters commented Apr 2, 2020

Uh oh!

rgolangh commented Apr 2, 2020

Uh oh!

Gal-Zaidman commented Apr 2, 2020

Uh oh!

Gal-Zaidman commented Apr 2, 2020

Uh oh!

Gal-Zaidman commented Apr 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rgolangh commented Apr 3, 2020

Uh oh!

Gal-Zaidman commented Apr 4, 2020

Uh oh!

cgwalters commented Apr 4, 2020

Uh oh!

openshift-bot commented Apr 4, 2020

Uh oh!

runcom commented Apr 4, 2020

Uh oh!

openshift-ci-robot commented Apr 4, 2020

Uh oh!

openshift-ci-robot commented Apr 4, 2020

Uh oh!

openshift-bot commented Apr 4, 2020

Uh oh!

rgolangh commented Apr 5, 2020

Uh oh!

openshift-cherrypick-robot commented Apr 5, 2020

Uh oh!

mandre commented Apr 6, 2020

Uh oh!

kikisdeliveryservice commented Apr 7, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Gal-Zaidman commented Apr 2, 2020 •

edited

Loading