Skip to content

Bug 1801638: [release-4.3] baremetal: all resolvconf editing to NM dispatcher #1470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Feb 21, 2020
Merged

Bug 1801638: [release-4.3] baremetal: all resolvconf editing to NM dispatcher #1470

openshift-merge-robot merged 1 commit into from
Feb 21, 2020

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Feb 13, 2020

This is an automated cherry-pick of #1456

/assign celebdor

@celebdor
baremetal: all resolvconf editing to NM dispatcher
5056e93 
Before this patch, the search domain modification was dependant on
dhclient. Unfortunately, the interaction of both components sometimes
fails. This patch makes sure that we preserve what comes from the dhcp
client (whichever may be) but we set what we need in VIP managing
environments.

Signed-off-by: Antoni Segura Puimedon <antoni@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 13, 2020
Merged
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 13, 2020

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1801662, which is invalid:

  • expected the bug to target the "4.3.z" release, but it targets "4.4.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead
  • expected dependent Bugzilla bug 1801638 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.3] Bug 1801662: baremetal: all resolvconf editing to NM dispatcher

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 13, 2020
@celebdor
Copy link
Contributor

celebdor commented Feb 13, 2020

/title [release-4.3] Bug 1801638: baremetal: all resolvconf editing to NM dispatcher

@celebdor
Copy link
Contributor

celebdor commented Feb 13, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 13, 2020

@celebdor: This pull request references Bugzilla bug 1801662, which is invalid:

  • expected the bug to target the "4.3.z" release, but it targets "4.4.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead
  • expected Bugzilla bug 1801662 to depend on a bug in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@celebdor
Copy link
Contributor

celebdor commented Feb 13, 2020

/retitle [release-4.3] Bug 1801638: baremetal: all resolvconf editing to NM dispatcher

@openshift-ci-robot openshift-ci-robot changed the title [release-4.3] Bug 1801662: baremetal: all resolvconf editing to NM dispatcher [release-4.3] Bug 1801638: baremetal: all resolvconf editing to NM dispatcher Feb 13, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 13, 2020

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1801638, which is invalid:

  • expected dependent Bugzilla bug 1801662 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.3] Bug 1801638: baremetal: all resolvconf editing to NM dispatcher

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2020
@kikisdeliveryservice
Copy link
Contributor

kikisdeliveryservice commented Feb 13, 2020

This is the backport from yesterday's PR.

@yboaron @mandre @cybertron @bcrochet please review and lgtm.

@russellb
Copy link
Contributor

russellb commented Feb 18, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 18, 2020

@russellb: This pull request references Bugzilla bug 1801638, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is VERIFIED instead
  • expected dependent Bugzilla bug 1801662 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@russellb
Copy link
Contributor

russellb commented Feb 18, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 18, 2020
@runcom
Copy link
Member

runcom commented Feb 18, 2020

/approve

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 18, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kikisdeliveryservice, openshift-cherrypick-robot, runcom, russellb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [kikisdeliveryservice,runcom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@runcom runcom changed the title [release-4.3] Bug 1801638: baremetal: all resolvconf editing to NM dispatcher Bug 1801638: [release-4.3] baremetal: all resolvconf editing to NM dispatcher Feb 19, 2020
@bparees
Copy link

bparees commented Feb 19, 2020

@celebdor @russellb this needs a valid 4.3.z bug that depends on a 4.4 bug. Currently this PR references a 4.3.z bug that's already verified.

@hexfusion hexfusion mentioned this pull request Feb 20, 2020
Merged
@celebdor
Copy link
Contributor

celebdor commented Feb 20, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 20, 2020

@celebdor: This pull request references Bugzilla bug 1801638, which is invalid:

  • expected dependent Bugzilla bug 1801662 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@celebdor
Copy link
Contributor

celebdor commented Feb 20, 2020

This was verified on a 4.3 IPv6 branch. Initially on @jparrill 's baremetal environment but verified by others since then. The bugzilla bot won't allow this to merge until the 4.4 bugzilla is verified, but AFAIU, 4.4 IPv6 still needs a few merges before the verification can take place. I would suggest merging this due to its aforementioned 4.3 verification.

@bparees bparees added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 20, 2020
@bparees
Copy link

bparees commented Feb 20, 2020

manually overriding BZ requirement since this change was verified on a 4.3-ipv6 branch and i have confirmed the PR has merged to 4.4(master a week ago). It's not reasonable to get a 4.4 BZ verified in this case since we don't have ipv6 testing on 4.4 currently.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 20, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 20, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 21, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 21, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 21, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 21, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit d13c324 into openshift:release-4.3 Feb 21, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 21, 2020

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged. Bugzilla bug 1801638 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1801638: [release-4.3] baremetal: all resolvconf editing to NM dispatcher

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cgwalters cgwalters Awaiting requested review from cgwalters

@yuqi-zhang yuqi-zhang Awaiting requested review from yuqi-zhang

1 more reviewer

@kikisdeliveryservice kikisdeliveryservice kikisdeliveryservice approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@russellb russellb

@celebdor celebdor

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@openshift-cherrypick-robot @openshift-ci-robot @celebdor @kikisdeliveryservice @russellb @runcom @bparees @openshift-bot @openshift-merge-robot