Bug 1801662: baremetal: all resolvconf editing to NM dispatcher #1456
Conversation
Before this patch, the search domain modification was dependant on dhclient. Unfortunately, the interaction of both components sometimes fails. This patch makes sure that we preserve what comes from the dhcp client (whichever may be) but we set what we need in VIP managing environments. Signed-off-by: Antoni Segura Puimedon <antoni@redhat.com>
openshift-ci-robot
added
the
size/S
openshift-ci-robot
requested review from
bcrochet,
cybertron,
mandre,
rgolangh and
yboaron
|
this needs a BZ to merge (ie Bz in title etc...) |
celebdor
changed the title
openshift-ci-robot
added
the
bugzilla/invalid-bug
|
@celebdor: This pull request references Bugzilla bug 1801662, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
openshift-ci-robot
added
bugzilla/valid-bug
|
@celebdor: This pull request references Bugzilla bug 1801662, which is valid. The bug has been moved to the POST state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
kikisdeliveryservice
left a comment
kikisdeliveryservice
left a comment
There was a problem hiding this comment.
@yboaron @mandre @cybertron @bcrochet @rgolangh please review and lgtm.
|
/skip |
openshift-ci-robot
added
the
approved
|
/lgtm |
|
@celebdor: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bcrochet, celebdor, kikisdeliveryservice, yboaron The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@celebdor: Bugzilla bug 1801662 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick 4.3 |
|
@celebdor: cannot checkout 4.3: error checking out 4.3: exit status 1. output: error: pathspec '4.3' did not match any file(s) known to git. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.3 |
|
@celebdor: new pull request created: #1470 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Before this patch, the search domain modification was dependant on dhclient. Unfortunately, the interaction of both components sometimes fails. This patch makes sure that we preserve what comes from the dhcp client (whichever may be) but we set what we need in VIP managing environments. This ports the BM change openshift#1456 to OpenStack platform.
Before this patch, the search domain modification was dependant on dhclient. Unfortunately, the interaction of both components sometimes fails. This patch makes sure that we preserve what comes from the dhcp client (whichever may be) but we set what we need in VIP managing environments. This ports the BM change openshift#1456 to OpenStack platform.
9 participants
Before this patch, the search domain modification was dependant on
dhclient. Unfortunately, the interaction of both components sometimes
fails. This patch makes sure that we preserve what comes from the dhcp
client (whichever may be) but we set what we need in VIP managing
environments.