[fcos] Cherry-pick commits to enable cluster-etcd-operator #1415
Conversation
This is necessary to prevent races
EtcdInformer is only used by the MCO pod to reconcile image names. This pulls out the logic of creating etcd informer from the generic controller context to MCO pod start method.
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
openshift-ci-robot
added
size/L
On an upgrade from a 4.3 cluster to a cluster-etcd-operator enabled cluster discovery fails because the expected operator environment is not getting created.
|
/retest |
1 similar comment
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LorbusChris, vrutkovs The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@vrutkovs: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/override ci/prow/e2e-aws so that it passes bootstrap |
|
@vrutkovs: Overrode contexts on behalf of vrutkovs: ci/prow/e2e-aws DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6 participants
Cherrypick of #1288, #1408 and #1316 on fcos branch
/cc @LorbusChris