Skip to content

templates: etcd-member: add waitforkube init container #1316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jan 23, 2020
Merged

templates: etcd-member: add waitforkube init container #1316

openshift-merge-robot merged 1 commit into from
Jan 23, 2020

Conversation

@hexfusion
Copy link
Contributor

@hexfusion hexfusion commented Dec 9, 2019 •
edited
Loading

This PR adds an init container waitforkube if CEO is enabled.

Depends on openshift/cluster-etcd-operator#46

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 9, 2019
@kikisdeliveryservice kikisdeliveryservice requested review from kikisdeliveryservice and removed request for ashcrow December 9, 2019 23:03
@kikisdeliveryservice
Copy link
Contributor

kikisdeliveryservice commented Dec 9, 2019

i think you might need a make update here.

@hexfusion hexfusion changed the title WIP templates: etcd-member: add wait-for-kube init container templates: etcd-member: add waitforkube init container Dec 10, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 10, 2019
@openshift-ci-robot openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 10, 2019
@hexfusion hexfusion force-pushed the add_wait branch 4 times, most recently from c1f0284 to a314aef Compare December 10, 2019 01:04
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 10, 2019
@hexfusion
Copy link
Contributor Author

hexfusion commented Dec 10, 2019

/hold

wait for CEO PR to land which adds the command waitforkube

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 10, 2019
@hexfusion
Copy link
Contributor Author

hexfusion commented Dec 10, 2019

i think you might need a make update here.

I had used keys that were not yet valid, updated to reflect Images.clusterEtcdOperatorImageKey properly.

alaypatel07
alaypatel07 reviewed Dec 17, 2019
View reviewed changes
Copy link
Contributor

@alaypatel07 alaypatel07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this with the typo fix and other necessary MCO/CEO changes, was able to get a successful bootstrap run!

@hexfusion
templates: add wait-for-kube
64e1c88 
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@hexfusion
Copy link
Contributor Author

hexfusion commented Jan 20, 2020

/retest

@hexfusion
Copy link
Contributor Author

hexfusion commented Jan 20, 2020

/test e2e-gcp-upgrade

@hexfusion
Copy link
Contributor Author

hexfusion commented Jan 22, 2020

/retest

@hexfusion
Copy link
Contributor Author

hexfusion commented Jan 22, 2020

/hold cancel

cc @kikisdeliveryservice

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 22, 2020
@runcom
Copy link
Member

runcom commented Jan 22, 2020

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 22, 2020
@hexfusion
Copy link
Contributor Author

hexfusion commented Jan 22, 2020

/test e2e-aws-scaleup-rhel7

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@alaypatel07
Copy link
Contributor

alaypatel07 commented Jan 22, 2020

/lgtm

thanks @hexfusion

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 22, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alaypatel07, hexfusion, runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hexfusion
Copy link
Contributor Author

hexfusion commented Jan 22, 2020

/test e2e-gcp-upgrade

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@runcom
Copy link
Member

runcom commented Jan 22, 2020

/skip

1 similar comment
@runcom
Copy link
Member

runcom commented Jan 22, 2020

/skip

@hexfusion
Copy link
Contributor Author

hexfusion commented Jan 22, 2020

level=fatal msg="failed to fetch Cluster: failed to generate asset "Cluster": failed to create cluster: failed to apply using Terraform"

flake

/test e2e-aws

@hexfusion
Copy link
Contributor Author

hexfusion commented Jan 22, 2020

level=fatal msg="failed to fetch Cluster: failed to generate asset "Cluster": failed to create cluster: failed to apply using Terraform"

flake .....

/test e2e-aws

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@hexfusion
Copy link
Contributor Author

hexfusion commented Jan 22, 2020

/test e2e-aws

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@hexfusion
Copy link
Contributor Author

hexfusion commented Jan 22, 2020

more flakes

/test e2e-aws

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 23, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 23, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 23, 2020 •
edited
Loading

@hexfusion: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 64e1c88 link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 23, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 23, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 2810704 into openshift:master Jan 23, 2020
@vrutkovs vrutkovs mentioned this pull request Jan 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yuqi-zhang yuqi-zhang Awaiting requested review from yuqi-zhang

@kikisdeliveryservice kikisdeliveryservice Awaiting requested review from kikisdeliveryservice

1 more reviewer

@alaypatel07 alaypatel07 alaypatel07 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@runcom runcom

@alaypatel07 alaypatel07

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@hexfusion @kikisdeliveryservice @runcom @openshift-bot @alaypatel07 @openshift-ci-robot @openshift-merge-robot