remove make binaries from Dockerfiles and use -mod=vendor when building #1232
Conversation
It's called by make install already Signed-off-by: Antonio Murdaca <[email protected]>
Avoids redownloading every dependency (especially with docker/podman where there's no local cache) Signed-off-by: Antonio Murdaca <[email protected]>
openshift-ci-robot
added
the
size/XS
openshift-ci-robot
requested review from
LorbusChris and
kikisdeliveryservice
openshift-ci-robot
added
the
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, runcom The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
gcp iam failure? reported /test e2e-gcp-upgrade |
|
/skip |
|
Hm, it looks like that e2e-gcp-op test failed because it couldn't evict the router: I can't imagine that this PR broke it so |
|
this failed test is killing us... /test e2e-gcp-op |
|
I think we need to get to the bottom of why the router pod isn't evicting. |
|
/override e2e-gcp-op |
|
@cgwalters: /override requires a failed status context to operate on.
Only the following contexts were expected:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/e2e-gcp-op |
|
@cgwalters: Overrode contexts on behalf of cgwalters: ci/prow/e2e-gcp-op DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@runcom: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/override ci/prow/e2e-gcp-op |
|
@cgwalters: Overrode contexts on behalf of cgwalters: ci/prow/e2e-gcp-op DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
5 participants
Fixes an issue with builds in ART as well, please look at individual commit messages.
cc @cgwalters