Bug 1766356: templates: tell NetworkManager to ignore interfaces #1231
Conversation
|
FYI @dcbw |
openshift-ci-robot
added
the
size/XS
|
@squeed: This pull request references Bugzilla bug 1766356, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
openshift-ci-robot
requested review from
LorbusChris and
kikisdeliveryservice
|
Ohh exciting. FWIW, in theory this could (and possibly should) go directly in RHCOS too, but...we don't have a nice convenient ci-gated place for that. Sadly the RHCOS bits are internal (xref openshift/os#388) - but here's where this changed https://gitlab.cee.redhat.com/coreos/redhat-coreos/merge_requests/638 /approve |
openshift-ci-robot
added
the
approved
|
I think longer term rather than that inline matching which is somehow reminiscent of modem commands we should do something like have a way to attach metadata about an "owner" to network interfaces, so that not-NetworkManager processes could signal to NM directly about this. A somewhat related situation for example is the default podman/docker veth devices, which at one point NM saw and said "oh hey, an ethernet device, let me DHCP on it". Maybe in udev somehow? Or maybe patch the kernel to add xattrs on sysfs? |
I don't have a good intuition for where that line should fall. Since third-party network providers could theoretically have to mirror this (using the correct CRs), keeping it open seems like being a good citizen.
That might work. Honestly, any networking device created by For something as complicated as an ovs bridge, I really can't think of a specific rule. We, as an SDN provider, want full control of our interface. The CNV people, who also create ovs bridges, want those interfaces to be managed normally. At this point, branching on the name is the only thing I can think of. In my days as CNI maintainer, I've definitely wanted the ability to set arbitrary metadata on an interface... |
|
/lgtm |
|
/skip |
|
/retest |
1 similar comment
|
/retest |
|
any hints on how to debug this? |
|
It's not this PR, same symptom here #1232 (comment) |
|
Gotcha. If there's anything I can do to speed this along, let me know. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
The recent os bump includes the OVS plugin for NetworkManager, causing it to manage interfaces that were previously left unmanaged. This functionality will be used, so we can't tell it to ignore all interfaces of type openvswitch. So, add the interfaces created by openshift-sdn and ovn-kubernetes to the Unmanaged list.
|
Rebased on master, added |
|
/skip |
|
/lgtm |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, dcbw, squeed The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/skip |
|
@squeed: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/skip |
|
level=error msg="Error: Error waiting for instance (i-02e9b659694cad6cf) to become ready: Failed to reach target state. Reason: Server.InternalError: Internal error on launch" /test e2e-aws |
|
@squeed: All pull requests linked via external trackers have merged. Bugzilla bug 1766356 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
7 participants
The recent os bump includes the OVS plugin for NetworkManager, causing it to manage interfaces that were previously left unmanaged.
This functionality will be used, so we can't tell it to ignore all interfaces of type openvswitch. So, add the interfaces created by openshift-sdn and ovn-kubernetes to the Unmanaged list.