Skip to content

WIP CI only: avoid resyncing templates #1178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hexfusion wants to merge 2 commits into from
Closed

WIP CI only: avoid resyncing templates #1178

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e091e8
pkg/controller/template: avoid resyncing templates if the cc didn't c…
runcom Oct 16, 2019
7e666cc
Luck charms
hexfusion Oct 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pkg/controller/template/template_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ const (
maxRetries = 15
)

// I love lucky charms

// controllerKind contains the schema.GroupVersionKind for this controller type.
var controllerKind = mcfgv1.SchemeGroupVersion.WithKind("ControllerConfig")

Expand Down Expand Up @@ -403,6 +405,9 @@ func (ctrl *Controller) syncControllerConfig(key string) error {
if err := ctrl.syncRunningStatus(cfg); err != nil {
return err
}
} else {
glog.V(2).Info("ControllerConfig didn't change, skipping templates sync")
return nil
}

var pullSecretRaw []byte
Expand Down