WIP CI only: avoid resyncing templates #1178
Conversation
…hange There are two main reasons for this patch. The first one is obivious and avoids spending time retemplating when there's no need since the ControllerConfig's spec hasn't changed. The second reason is king of tricky but what can happen is the following: 0) between 4.1 and 4.2 MCO changed the etcd-member image name placeholder from `setupEtcdEnv` to `setupEtcdEnvKey` (along with other changes to image names) 1) when an upgrade from 4.1 starts the following happens: a) the new MCO is rolled out b) the new MCC is rolled out (note the template controller is also rolled out here and can start before the new CC is rolled out with the new image name placeholder!) c) RACE! the template controller starts running before the new ControllerConfig with the new image name placeholder is created d) the MCC generates templates w/o the image name for the etcd member e)_cluster dies The patch does a simple thing but ensures that the above scenario isn't hit since we're not going to retemplate anymore if the CC hasn't changed (yet). Signed-off-by: Antonio Murdaca <[email protected]>
openshift-ci-robot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hexfusion The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
|
Due to how ci is setup this is just mirroring the same test that is running in 1777. Basically you can't run 2 PRs on the same commit, if you do only 1 test run will happen and they will link to the same ci run. |
|
You can make a small change to get a new commit for the changes and push to get a new run. |
|
@hexfusion: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
1177 is going to merge, closing this now.. |
4 participants
dupe of #1177 for additional CI cycles.