Skip to content

CORS-4315: enable primary IPv6 when infrastructure ipFamily is DualStackIPv6Primary #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Mar 4, 2026
+10 −0
Merged

CORS-4315: enable primary IPv6 when infrastructure ipFamily is DualStackIPv6Primary #171

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions pkg/actuators/machine/instances.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,6 +379,16 @@ func launchInstance(machine *machinev1beta1.Machine, machineProviderConfig *mach
},
}

// For dual-stack IPv6-primary clusters, instances must have a primary IPv6 address on their primary ENI
// to register with the IPv6 Target Groups of API and Ingress load balancers.
// See: https://docs.aws.amazon.com/elasticloadbalancing/latest/network/load-balancer-target-groups.html#target-group-ip-address-type
if infra != nil && infra.Status.PlatformStatus != nil && infra.Status.PlatformStatus.AWS != nil && infra.Status.PlatformStatus.AWS.IPFamily == configv1.DualStackIPv6Primary {
networkInterfaces[0].PrimaryIpv6 = aws.Bool(true)
// The subnet should automatically assign 1 IPv6 address from its IPv6 CIDR to the instance,
// but we need to redundantly request 1 here as AWS API requires so. Otherwise, we will run into InvalidParameterValue API error.
networkInterfaces[0].Ipv6AddressCount = aws.Int64(1)
}

// Public IP address assignment to instances created in Wavelength
// Zones' subnet requires the attribute AssociateCarrierIpAddress
// instead of AssociatePublicIpAddress.
Expand Down