Skip to content

CORS-4315: enable primary IPv6 when infrastructure ipFamily is DualStackIPv6Primary#171

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
tthvo:CORS-4315
Mar 4, 2026
Merged

CORS-4315: enable primary IPv6 when infrastructure ipFamily is DualStackIPv6Primary#171
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
tthvo:CORS-4315

Conversation

@tthvo
Copy link
Copy Markdown
Member

@tthvo tthvo commented Jan 21, 2026

Description

For dual-stack IPv6-primary clusters, instances must have a primary IPv6 address on their primary ENI to registery with the IPv6 Target Groups of API and Ingress load balancers. See AWS docs

Notes

This assumes that the containing subnet is dual-stack (has both IPv4 and IPv6 CIDRs) since we are requesting an IPv6 address for the instance. The subnets, created by installer/capa, will be dual-stack and will auto-assign an IPv6 address on launch.

…imary

For dual-stack IPv6-primary clusters, instances must have a primary IPv6
address on their primary ENI to registery with the IPv6 Target Groups of API
and Ingress load balancers.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 21, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jan 21, 2026

@tthvo: This pull request references CORS-4315 which is a valid jira issue.

Details

In response to this:

Description

For dual-stack IPv6-primary clusters, instances must have a primary IPv6 address on their primary ENI to registery with the IPv6 Target Groups of API and Ingress load balancers. See AWS docs

Notes

This assumes that the containing subnet is dual-stack (has both IPv4 and IPv6 CIDRs) since we are requesting an IPv6 address for the instance. The subnets, created by installer/capa, will be dual-stack and will auto-assign an IPv6 address on launch.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from nrb and theobarberbany January 21, 2026 23:17
@tthvo
Copy link
Copy Markdown
Member Author

tthvo commented Jan 21, 2026

/hold

This is a preview of the idea to adjust MAPA to react based on the infra status ipFamily.

Important: We have not finalized on which direction to go yet (i.e. auto react or explicit MAPA machine field) 👀

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 21, 2026
@tthvo
Copy link
Copy Markdown
Member Author

tthvo commented Jan 21, 2026

/cc @damdo @patrickdillon @sadasu

@sadasu
Copy link
Copy Markdown

sadasu commented Feb 25, 2026

/hold cancel

Important: We have not finalized on which direction to go yet (i.e. auto react or explicit MAPA machine field) 👀

I am OK with this approach where we look at Infra CR which I think is what you are calling "auto react" vs adding a new field to MAPA.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 25, 2026
@damdo
Copy link
Copy Markdown
Member

damdo commented Feb 25, 2026

/assign @nrb

Copy link
Copy Markdown

@sadasu sadasu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2026
@sunzhaohua2
Copy link
Copy Markdown

Hi @yunjiang29 want to check with you, will you test this pr?

@nrb
Copy link
Copy Markdown
Contributor

nrb commented Mar 2, 2026

/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 2, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nrb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2026
@tthvo
Copy link
Copy Markdown
Member Author

tthvo commented Mar 4, 2026

Hi @yunjiang29 want to check with you, will you test this pr?

Hi @sunzhaohua2, as the installer dualstack support is in progress, I can verify this PR myself via local testing (for dualstack) and via presubmit (for regression). Later on, Yunfei can test the full feature together.

@tthvo
Copy link
Copy Markdown
Member Author

tthvo commented Mar 4, 2026

/verified by @tthvo

Machines are assigned primary IPv6 address as expected.

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 4, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@tthvo: This PR has been marked as verified by @tthvo.

Details

In response to this:

/verified by @tthvo

Machines are assigned primary IPv6 address as expected.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 4, 2026

@tthvo: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 0dd849f into openshift:main Mar 4, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants